1 TRADE PER DAY

• 10/18/2021 at 11:16 AM #179862
  coh123

  Hi there,

   

  This forum has been incredibly useful so far for a lot of things so thank you.

  I have seen a couple of posts regarding the 1 trade per day coding but non of them seem to work for me so I was wondering if there was just a standard code you can input into the strategy?

  Many thanks

  

  coh123

  Participant

  Topics: 3

  Replies: 8

  Been thanked: 0 times
  10/18/2021 at 11:39 AM #179863
  MauroPro

  Try to add this to your code:

  singleDayTrade = (barIndex-tradeIndex(1)>intradayBarIndex)

   

   

   

  

  MauroPro

  Participant

  Topics: 53

  Replies: 450

  Been thanked: 89 times
  10/18/2021 at 2:37 PM #179873
  coh123

  Thanks for trying but it doesn’t seem to work.

  

  coh123

  Participant

  Topics: 3

  Replies: 8

  Been thanked: 0 times
  10/18/2021 at 3:28 PM #179876
  MauroPro

  Very strange, it should work.

  In any case, try this snippet (Nicolas):

  if intradaybarindex=0 or day<>day[1] then
  count=0
  endif

  if ( (not onmarket and onmarket[1] and not onmarket[2]) or (tradeindex(1)=tradeindex(2) and tradeindex(1)=barindex[1] and tradeindex(1)>0) or (not onmarket and onmarket[1])) then
  count=count+1
  endif

  Then:

  if “myConditions” and count<1 then

  …

   

  

  MauroPro

  Participant

  Topics: 53

  Replies: 450

  Been thanked: 89 times
  10/18/2021 at 3:52 PM #179879
  coh123

  Unfortunately that doesn’t work either. I’ll put the code below to see if anyone can figure out why…

  // Definition of code parameters
  DEFPARAM CumulateOrders = False // Cumulating positions deactivated

  // Conditions to enter long positions
  indicator1 = (DHigh(1) + DLow(1) + DClose(1))/3-(DHigh(1)-DLow(1))
  c1 = (close <= indicator1)
  indicator2 = RSI[14](close)
  c2 = (indicator2 <= 30)
  indicator3 = MACDline[12,26,9](close)
  c3 = (indicator3 <= -0.0015)
  indicator4 = DLow(1)-2*(DHigh(1)-(DHigh(1) + DLow(1) + DClose(1))/3)
  c4 = (close >= indicator4)

  if intradaybarindex=0 or day<>day[1] then
  count=0
  endif

  if ( (not onmarket and onmarket[1] and not onmarket[2]) or (tradeindex(1)=tradeindex(2) and tradeindex(1)=barindex[1] and tradeindex(1)>0) or (not onmarket and onmarket[1])) then
  count=count+1
  endif

  // initiate a new BUY order
  if c1 AND c2 AND c3 AND c4 and count<1 THEN
  BUY 10 CONTRACT AT MARKET
  endif

   

  // Conditions to exit long positions
  indicator5 = MACDline[12,26,9](close)
  c5 = (indicator5 >= 0)

  IF c5 THEN
  SELL AT MARKET
  ENDIF

  // Conditions to enter short positions
  indicator6 = MACDline[12,26,9](close)
  c6 = (indicator6 >= 0.0015)
  indicator7 = RSI[14](close)
  c7 = (indicator7 >= 70)
  indicator8 = (DHigh(1) + DLow(1) + DClose(1))/3+(DHigh(1)-DLow(1))
  c8 = (close >= indicator8)
  indicator9 = DHigh(1)+2*((DHigh(1) + DLow(1) + DClose(1))/3-DLow(1))
  c9 = (close <= indicator9)

  IF c6 AND c7 AND c8 AND c9 and count<1 THEN
  SELLSHORT 10 CONTRACT AT MARKET
  ENDIF

  // Conditions to exit short positions
  indicator10 = MACDline[12,26,9](close)
  c10 = (indicator10 <= -0.0015)

  IF c10 THEN
  EXITSHORT AT MARKET
  ENDIF

   

  // Stops and targets
  SET STOP pLOSS 6
  SET TARGET pPROFIT 32

  

  coh123

  Participant

  Topics: 3

  Replies: 8

  Been thanked: 0 times
  10/18/2021 at 6:18 PM #179884
  robertogozzi

  OTD (One Trade per Day) works fine for me:

  // Definition of code parameters DEFPARAM CumulateOrders = False // Cumulating positions deactivated // Conditions to enter long positions indicator1 = (DHigh(1) + DLow(1) + DClose(1))/3-(DHigh(1)-DLow(1)) c1 = (close <= indicator1) indicator2 = RSI[14](close) c2 = (indicator2 <= 30) indicator3 = MACDline[12,26,9](close) c3 = (indicator3 <= -0.0015) indicator4 = DLow(1)-2*(DHigh(1)-(DHigh(1) + DLow(1) + DClose(1))/3) c4 = (close >= indicator4) //if intradaybarindex=0 or day<>day[1] then //count=0 //endif //if ( (not onmarket and onmarket[1] and not onmarket[2]) or (tradeindex(1)=tradeindex(2) and tradeindex(1)=barindex[1] and tradeindex(1)>0) or (not onmarket and onmarket[1])) then //count=count+1 //endif OTD = (Barindex - TradeIndex(1) > IntradayBarIndex) //OR 1 // initiate a new BUY order //if c1 AND c2 AND c3 AND c4 and count<1 THEN if c1 AND c2 AND c3 AND c4 and OTD THEN BUY 10 CONTRACT AT MARKET endif // Conditions to exit long positions indicator5 = MACDline[12,26,9](close) c5 = (indicator5 >= 0) IF c5 THEN SELL AT MARKET ENDIF // Conditions to enter short positions indicator6 = MACDline[12,26,9](close) c6 = (indicator6 >= 0.0015) indicator7 = RSI[14](close) c7 = (indicator7 >= 70) indicator8 = (DHigh(1) + DLow(1) + DClose(1))/3+(DHigh(1)-DLow(1)) c8 = (close >= indicator8) indicator9 = DHigh(1)+2*((DHigh(1) + DLow(1) + DClose(1))/3-DLow(1)) c9 = (close <= indicator9) //IF c6 AND c7 AND c8 AND c9 and count<1 THEN IF c6 AND c7 AND c8 AND c9 and OTD THEN SELLSHORT 10 CONTRACT AT MARKET ENDIF // Conditions to exit short positions indicator10 = MACDline[12,26,9](close) c10 = (indicator10 <= -0.0015) IF c10 THEN EXITSHORT AT MARKET ENDIF // Stops and targets SET STOP pLOSS 6 SET TARGET pPROFIT 32

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65

  // Definition of code parameters DEFPARAM CumulateOrders = False // Cumulating positions deactivated   // Conditions to enter long positions indicator1 = (DHigh(1) + DLow(1) + DClose(1))/3-(DHigh(1)-DLow(1)) c1 = (close <= indicator1) indicator2 = RSI[14](close) c2 = (indicator2 <= 30) indicator3 = MACDline[12,26,9](close) c3 = (indicator3 <= -0.0015) indicator4 = DLow(1)-2*(DHigh(1)-(DHigh(1) + DLow(1) + DClose(1))/3) c4 = (close >= indicator4)   //if intradaybarindex=0 or day<>day[1] then //count=0 //endif   //if ( (not onmarket and onmarket[1] and not onmarket[2]) or (tradeindex(1)=tradeindex(2) and tradeindex(1)=barindex[1] and tradeindex(1)>0) or (not onmarket and onmarket[1])) then //count=count+1 //endif OTD = (Barindex - TradeIndex(1) > IntradayBarIndex) //OR 1 // initiate a new BUY order //if c1 AND c2 AND c3 AND c4 and count<1 THEN if c1 AND c2 AND c3 AND c4 and OTD THEN BUY 10 CONTRACT AT MARKET endif     // Conditions to exit long positions indicator5 = MACDline[12,26,9](close) c5 = (indicator5 >= 0)   IF c5 THEN SELL AT MARKET ENDIF   // Conditions to enter short positions indicator6 = MACDline[12,26,9](close) c6 = (indicator6 >= 0.0015) indicator7 = RSI[14](close) c7 = (indicator7 >= 70) indicator8 = (DHigh(1) + DLow(1) + DClose(1))/3+(DHigh(1)-DLow(1)) c8 = (close >= indicator8) indicator9 = DHigh(1)+2*((DHigh(1) + DLow(1) + DClose(1))/3-DLow(1)) c9 = (close <= indicator9)   //IF c6 AND c7 AND c8 AND c9 and count<1 THEN IF c6 AND c7 AND c8 AND c9 and OTD THEN SELLSHORT 10 CONTRACT AT MARKET ENDIF   // Conditions to exit short positions indicator10 = MACDline[12,26,9](close) c10 = (indicator10 <= -0.0015)   IF c10 THEN EXITSHORT AT MARKET ENDIF     // Stops and targets SET STOP pLOSS 6 SET TARGET pPROFIT 32

  try backtesting the same code, just removing the two comment slashes from line 21.

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17188

  Been thanked: 4064 times
  10/18/2021 at 6:53 PM #179888
  coh123

  Hi Roberto,

  Really appreciate you integrating the code for me!

  It is quite strange because I backtested the code you sent back as well as the code I had previously and over 6 years yours bankrupted the account and the other made £4k haha. I tested again with a larger account size and it just had a steady stream of losses till money lost again. Is there something in the code that perhaps makes it sell? Again, I’m still very much learning but something doesn’t seem quite right! 🙂

  

  coh123

  Participant

  Topics: 3

  Replies: 8

  Been thanked: 0 times
  10/19/2021 at 3:51 AM #179894
  PeterSt

  IF c6 AND c7 AND c8 AND c9 and OTD THEN SELLSHORT 10 CONTRACT AT MARKET ENDIF // Conditions to exit short positions indicator10 = MACDline[12,26,9](close) c10 = (indicator10 <= -0.0015) IF c10 THEN EXITSHORT AT MARKET ENDIF

  1 2 3 4 5 6 7 8 9 10 11

  IF c6 AND c7 AND c8 AND c9 and OTD THEN   SELLSHORT 10 CONTRACT AT MARKET ENDIF // Conditions to exit short positions indicator10 = MACDline[12,26,9](close) c10 = (indicator10 <= -0.0015) IF c10 THEN   EXITSHORT AT MARKET ENDIF

  No matter the origin, if you code like that (above), it becomes unreadable for yourself. Also, the result will be unpredictable (which is almost the same ;-)).

  // Conditions to exit short positions indicator10 = MACDline[12,26,9](close) c10 = (indicator10 <= -0.0015) IF c6 AND c7 AND c8 AND c9 and OTD THEN SELLSHORT 10 CONTRACT AT MARKET ELSIF c10 THEN EXITSHORT AT MARKET ENDIF

  1 2 3 4 5 6 7 8 9

  // Conditions to exit short positions indicator10 = MACDline[12,26,9](close) c10 = (indicator10 <= -0.0015)   IF c6 AND c7 AND c8 AND c9 and OTD THEN   SELLSHORT 10 CONTRACT AT MARKET ELSIF c10 THEN   EXITSHORT AT MARKET ENDIF

  If you code like the above, you depict mutual exclusive situations, which with the first example are not mutually exclusive at all.

  A bit more tightly coded would be like this :

  IF c6 AND c7 AND c8 AND c9 and OTD THEN SELLSHORT 10 CONTRACT AT MARKET ELSE // Conditions to exit short positions indicator10 = MACDline[12,26,9](close) c10 = (indicator10 <= -0.0015) If c10 THEN EXITSHORT AT MARKET ENDIF ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14

  IF c6 AND c7 AND c8 AND c9 and OTD THEN   SELLSHORT 10 CONTRACT AT MARKET ELSE     // Conditions to exit short positions     indicator10 = MACDline[12,26,9](close)   c10 = (indicator10 <= -0.0015)     If c10 THEN     EXITSHORT AT MARKET   ENDIF   ENDIF

  But this still would leave you with all kind of doubts, and it should be like this :

  If Not OnMarket then EnteredMarket = 0 If Not EnteredMarket then // Superfluous here, but good habit. // Conditions to go Short. IF c6 AND c7 AND c8 AND c9 and OTD THEN SELLSHORT 10 CONTRACT AT MARKET EnteredMarket = 1 ENDIF ENDIF If Not EnteredMarket then // Nit superfluous at all. // Other conditions for going Short or ... Long. IF ... then // ... EnteredMarket = 1 ENDIF ENDIF ENDIF // Not OnMarket ? If Not EnteredMarket then // A bit of overkill, but in certain situations even this is good habit. If ShortOnMarket then // Conditions to exit short positions indicator10 = MACDline[12,26,9](close) c10 = (indicator10 <= -0.0015) If c10 THEN EXITSHORT AT MARKET ENDIF ENDIF // ShortOnMarket ? ENDIF // Not EnteredMarket ?

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44

  If Not OnMarket then     EnteredMarket = 0     If Not EnteredMarket then   // Superfluous here, but good habit.       // Conditions to go Short.       IF c6 AND c7 AND c8 AND c9 and OTD THEN       SELLSHORT 10 CONTRACT AT MARKET       EnteredMarket = 1     ENDIF     ENDIF     If Not EnteredMarket then   // Nit superfluous at all.       // Other conditions for going Short or ... Long.       IF ... then       // ...       EnteredMarket = 1     ENDIF     ENDIF   ENDIF   // Not OnMarket ?   If Not EnteredMarket then   // A bit of overkill, but in certain situations even this is good habit.     If ShortOnMarket then       // Conditions to exit short positions       indicator10 = MACDline[12,26,9](close)     c10 = (indicator10 <= -0.0015)       If c10 THEN       EXITSHORT AT MARKET     ENDIF     ENDIF   // ShortOnMarket ?   ENDIF   // Not EnteredMarket ?

  This leaves no doubt about what is happening and “what you are doing”;
  Try to rebuild the code like this and you may automatically run into the culprit(s) why it is not working out, even before running your re-coded program.
  Never think this is long-winded and a waste of time, because clarity above all !

  Good luck now !

  

  PeterSt

  Participant

  Topics: 73

  Replies: 2545

  Been thanked: 830 times
  10/19/2021 at 4:07 AM #179895
  PeterSt

  I found a bug !
  🙂

  If Not OnMarket then EnteredMarket = 0 If Not EnteredMarket then // Superfluous here, but good habit. // The above is wrong and it should be like this : EnteredMarket = 0 If Not OnMarket then If Not EnteredMarket then // Superfluous here, but good habit.

  1 2 3 4 5 6 7 8 9 10 11 12 13

  If Not OnMarket then   EnteredMarket = 0   If Not EnteredMarket then   // Superfluous here, but good habit. // The above is wrong and it should be like this :   EnteredMarket = 0   If Not OnMarket then      If Not EnteredMarket then   // Superfluous here, but good habit.

  1 user thanked author for this post.

  coh123

  

  PeterSt

  Participant

  Topics: 73

  Replies: 2545

  Been thanked: 830 times
  10/19/2021 at 10:58 AM #179939
  coh123

  Wow, that has worked. I’m really grateful thank you.

  

  coh123

  Participant

  Topics: 3

  Replies: 8

  Been thanked: 0 times
  02/10/2022 at 3:28 PM #188013
  drive

  Thx, Roberto

  but really dont know what you are meaning,

  thx for your support

   

  

  drive

  Participant

  Topics: 2

  Replies: 2

  Been thanked: 0 times
  02/10/2022 at 3:51 PM #188014
  robertogozzi

  drive wrote:

  Thx, Roberto

  but really dont know what you are meaning,

  thx for your support

  Why are you answering here? Please do NO scatter infor all over the forum! Keep posting in your own topic. Thanks 🙂

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17188

  Been thanked: 4064 times
• Author
  Posts