Any reasons why this code is not working

• 01/01/2019 at 11:56 AM #87817
  rama

  book profit or loss

  pr=2 mp=40 mp1=-30 floatingprofit = (((close-positionprice)*pointvalue)*countofposition)/pipsize //actual trade gains if floatingprofit>=(mp or mp1) then SELL AT close-pr stop endif floatingprofit = (((positionprice-close)*pointvalue)*countofposition)/pipsize //actual trade gains if floatingprofit>=(mp or mp1) then EXITSHORT AT close+pr stop endif

  1 2 3 4 5 6 7 8 9 10 11 12 13

  pr=2 mp=40 mp1=-30   floatingprofit = (((close-positionprice)*pointvalue)*countofposition)/pipsize //actual trade gains if floatingprofit>=(mp or mp1) then SELL AT close-pr stop endif   floatingprofit = (((positionprice-close)*pointvalue)*countofposition)/pipsize //actual trade gains if floatingprofit>=(mp or mp1) then EXITSHORT AT close+pr stop endif

  I want to close all open positions short or long

  if loss is >=30

  or profit >=40

  

  rama

  Participant

  Topics: 35

  Replies: 67

  Been thanked: 4 times
  01/01/2019 at 12:13 PM #87819
  GraHal

  Just a thought … below won’t work if, for example, you are trying to exit within the bid-ask spread range (spread = 4 or more?).

  I guess you’ve tried higher values for pr?

  pr=2 SELL AT close-pr stop EXITSHORT AT close+pr stop

  1 2 3 4 5

  pr=2   SELL AT close-pr stop   EXITSHORT AT close+pr stop

   

  

  GraHal

  Participant

  Topics: 214

  Replies: 8830

  Been thanked: 2200 times
  01/01/2019 at 3:14 PM #87824
  Vonasi

  COUNTOFPOSITION can be positive or negative which will completely mess up your calculations.

  Also as GraHal says CLOSE +/- 2 will very likely be too close for a minimum order distance on most markets.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  01/01/2019 at 7:52 PM #87835
  GraHal

  Isn’t COUNTOFPOSITION either 0 or greater?

  When can it be negative?

  

  GraHal

  Participant

  Topics: 214

  Replies: 8830

  Been thanked: 2200 times
  01/01/2019 at 9:28 PM #87836
  Vonasi

  GraHal wrote:

  Isn’t COUNTOFPOSITION either 0 or greater?

  When can it be negative?

  When you are short.

  

  1 user thanked author for this post.

  GraHal

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  01/01/2019 at 10:18 PM #87839
  GraHal

  @rama try below (AND increase pr > spread) … let us know if it works.

  floatingprofit = (((close-positionprice)*pointvalue)*countoflongshares)/pipsize //actual trade gains if floatingprofit>=(mp or mp1) then SELL AT close-pr stop endif floatingprofit = (((positionprice-close)*pointvalue)*countofshortshares)/pipsize //actual trade gains if floatingprofit>=(mp or mp1) then EXITSHORT AT close+pr stop endif

  1 2 3 4 5 6 7 8 9

  floatingprofit = (((close-positionprice)*pointvalue)*countoflongshares)/pipsize //actual trade gains if floatingprofit>=(mp or mp1) then SELL AT close-pr stop endif floatingprofit = (((positionprice-close)*pointvalue)*countofshortshares)/pipsize //actual trade gains if floatingprofit>=(mp or mp1) then EXITSHORT AT close+pr stop endif

   

  

  GraHal

  Participant

  Topics: 214

  Replies: 8830

  Been thanked: 2200 times
  01/02/2019 at 11:09 AM #87859
  rama

  I am testing the new code, I have tried with PR =1 and MP=any value(without mp1 condition) it works well

  I am trying to add loss in the same code that is where it has problem

  

  rama

  Participant

  Topics: 35

  Replies: 67

  Been thanked: 4 times
  01/02/2019 at 11:22 AM #87860
  GraHal

  try below and let us know

  if (floatingprofit>= mp) or (floatingprofit <= mp1) then

  1	if (floatingprofit>= mp) or (floatingprofit <= mp1) then

   

  

  GraHal

  Participant

  Topics: 214

  Replies: 8830

  Been thanked: 2200 times
  01/03/2019 at 3:27 PM #87959
  rama

  I am running the program now with ,I will let you know the results

  1	if (floatingprofit>= mp) or (floatingprofit <= mp1) then

   

  

  rama

  Participant

  Topics: 35

  Replies: 67

  Been thanked: 4 times
  01/03/2019 at 5:10 PM #87961
  verygrubby

  Vonasi wrote:

  COUNTOFPOSITION can be positive or negative

  I think the definition in the manual should be tweaked to make that a bit more obvious. All it says at the moment is “Counts the number of open shares or lots.”

  Can a clarification be added (eg “a buy position would should as +1 and a sell position would show as -1”)?

  *when I say manual I mean here: https://www.prorealcode.com/documentation/countofposition/

   

  1 user thanked author for this post.

  GraHal

  

  verygrubby

  Participant

  Topics: 20

  Replies: 99

  Been thanked: 21 times
• Author
  Posts