Calling indicator

This topic has 11 replies, 3 voices, and was last updated 5 years ago by umebon.

Tagged: CALL

Viewing 12 posts - 1 through 12 (of 12 total)

07/08/2019 at 6:38 PM #102207

umebon

I’m need help how the code is for calling values from an indicator. The indicator is made by Thomas on this forum(thanks for sharing!) and i want to use the return of mytdaylow, mytdayhigh and mytdaycenter in my trading system but I don’t understand how too call it.

Return mydayhigh COLOURED (255, 0, 0)style(line, 2) AS "High", mydaylow COLOURED (0, 255, 0)style(line, 2) AS "Low", mytdayhigh COLOURED (0, 255, 0)style(dottedline, 4) AS "Today High", mytdaylow COLOURED (255, 0, 0)style(dottedline, 4) AS "Today Low", mytdaycenter COLOURED (255,153,0,255)style(dottedline, 4)as "Today Centerline"

Return mydayhigh COLOURED (255, 0, 0)style(line, 2) AS "High", mydaylow COLOURED (0, 255, 0)style(line, 2) AS "Low", mytdayhigh COLOURED (0, 255, 0)style(dottedline, 4) AS "Today High", mytdaylow COLOURED (255, 0, 0)style(dottedline, 4) AS "Today Low", mytdaycenter COLOURED (255,153,0,255)style(dottedline, 4)as "Today Centerline"

umebon

Participant

Topics: 29

Replies: 48

Been thanked: 4 times

07/08/2019 at 7:07 PM #102210

Vonasi

The syntax for CALL is:

myValue1, myValue2, myValue3 = CALL "myIndicator"[parameter1,parameter2]

1	myValue1, myValue2, myValue3 = CALL "myIndicator"[parameter1,parameter2]

where myvalue are the returned values and parameter is the variables required by the indicator (so for example a period or setting).

So for your indicator replace myValue1 etc with your returned names and replace parameters with any that your indicator needs.

If a value is not used in your strategy then just replace its name with ‘ignored’.

1 user thanked author for this post.

umebon

Vonasi

Moderator

Topics: 192

Replies: 5088

Been thanked: 1811 times

07/08/2019 at 7:12 PM #102211

umebon

Tnx, and what parameter do I use?

Here is the whole code from the indicator that i use by Thomas

// myCandel-Infos-V1.2
// 18.06.2019 (Release 1.2)
// Thomas Geisler
// Sharing ProRealTime knowledge
// https://www.prorealcode.com/library/
 
defparam drawonlastbaronly=true // Zeichung nur am letzten Bar
//--init--
alpha = 255
lookback = 1
Info = 1
Arrows = 1
DayTrend = 1
Centerline = 1
HighLowIntraday = 1
HighLow = 0
Trendforce = 0
OBVforce = 0
//-- end--
 
//--Info--
// previous Candle Range[1] and ATR[10] and EMA-ATR[20]of ATR[1]
myRange = round(Range[1])
myATR = round(AverageTrueRange[10](close[0]))
myEATR = round(ExponentialAverage[20](AverageTrueRange[10](close[0])))
If Info = 1 then
if myATR < ExponentialAverage[20](myATR) then
DrawText("                           #myRange#/#myATR#/#myEATR#",barindex,open,Serif,Bold,12) coloured(153,153,153,alpha)
else
DrawText("                           #myRange#/#myATR#/#myEATR#",barindex,open,Serif,Bold,12) coloured(255,153,0,alpha)
endif
endif
//--end--
 
//--Dailys highest high and lowest Low--
if HighLow then
if openday <> openday[1] then
dayindex = dayindex + 1
dayhigh = 0
daylow = close
//dayopen = open
//dayclose = close
 
if dayindex > lookback then
for j = 1 to barindex
if dayindex[j] = dayindex - lookback then
mydayhigh = dayhigh[j]
mydaylow = daylow[j]
break
endif
next
endif
endif
 
dayhigh = max(dayhigh,high)
daylow = min(daylow,low)
endif
 
if dayindex < lookback or not highlow then
mydayhigh = undefined
mydaylow = undefined
endif
 
if dayindex < lookback or not Centerline then
mytdaycenter = undefined
endif
//--end--
 
//-- proof close over/under high or low of intraday range--
mytdayhigh=DHigh(0)
mytdaylow=DLow(0)
DM0 = (mytdayhigh-mytdaylow)/2+mytdaylow
 
If DayTrend = 1 then
if close > DM0 then
DrawText("                         • over",barindex,open-10,Serif,Bold,12) coloured(0,255,0,alpha)
else
DrawText("                         • under",barindex,open+10,Serif,Bold,12) coloured(255,0,0,alpha)
endif
endif
//--end--
 
//--Centerline, center of range between intraday high/low--
If CenterLine = 1 then
mytdaycenter = DM0
else
mytdaycenter = undefined
endif
//--end--
 
//--Show Intraday HighLow as dotted line--
If HighLowIntraday = 1 then
mytdayhigh = DHigh(0)
mytdaylow = DLow(0)
else
mytdayhigh = undefined
mytdaylow = undefined
endif
//--end--
 
 
//--Arrows--
//Trend bzw Trend force
if Arrows = 1 then
BullTrend = (Close - LOWEST[20](LOW)) / AVERAGETRUERANGE[10]
BearTrend = (HIGHEST[20](HIGH) - Close) / AVERAGETRUERANGE[10]
Trend = (BullTrend - BearTrend)
TrendEMA = ExponentialAverage[20](Trend)
 
// On Balance Volumen zur Bestimmung der Kaufkraft der Bewegung/Trend
myOBV = OBV
myOBVA1 = ExponentialAverage[20](myOBV)
myOBVA2 = ExponentialAverage[10](myOBV)
 
if Trendforce = 1 and OBVforce = 1 then
If Trend > TrendEMA and myOBV > myOBVA1 and myOBV > myOBVA2 then
DRAWARROWup(barindex,low-2) coloured(0,255,0,alpha)
elsif Trend < TrendEMA and myOBV < myOBVA1 and myOBV < myOBVA2 then
DRAWARROWdown(barindex,high+2)coloured(255,0,0,alpha)
endif
elsIf OBVforce = 1 and not Trendforce then
if myOBV > myOBVA1 and myOBV > myOBVA2 then
DRAWARROWup(barindex,low-2) coloured(0,255,0,alpha)
elsif myOBV < myOBVA1 and myOBV < myOBVA2 then
DRAWARROWdown(barindex,high+2)coloured(255,0,0,alpha)
endif
elsIf Trendforce = 1 and not OBVforce then
if Trend > TrendEMA then
DRAWARROWup(barindex,low-2) coloured(0,255,0,alpha)
elsif Trend < TrendEMA then
DRAWARROWdown(barindex,high+2)coloured(255,0,0,alpha)
endif
endif
endif
//--end--
 
Return mydayhigh COLOURED (255, 0, 0)style(line, 2) AS "High", mydaylow COLOURED (0, 255, 0)style(line, 2) AS "Low", mytdayhigh COLOURED (0, 255, 0)style(dottedline, 4) AS "Today High", mytdaylow COLOURED (255, 0, 0)style(dottedline, 4) AS "Today Low", mytdaycenter COLOURED (255,153,0,255)style(dottedline, 4)as "Today Centerline"
 
 
// End and make money

100

101

102

103

104

105

106

107

108

109

110

111

112

113

114

115

116

117

118

119

120

121

122

123

124

125

126

127

128

129

130

131

132

133

134

135

136

137

138

139

140

// myCandel-Infos-V1.2

// 18.06.2019 (Release 1.2)

// Thomas Geisler

// Sharing ProRealTime knowledge

// https://www.prorealcode.com/library/

defparam drawonlastbaronly=true // Zeichung nur am letzten Bar

//--init--

alpha = 255

lookback = 1

Info = 1

Arrows = 1

DayTrend = 1

Centerline = 1

HighLowIntraday = 1

HighLow = 0

Trendforce = 0

OBVforce = 0

//-- end--

//--Info--

// previous Candle Range[1] and ATR[10] and EMA-ATR[20]of ATR[1]

myRange = round(Range[1])

myATR = round(AverageTrueRange[10](close[0]))

myEATR = round(ExponentialAverage[20](AverageTrueRange[10](close[0])))

If Info = 1 then

if myATR < ExponentialAverage[20](myATR) then

DrawText(" #myRange#/#myATR#/#myEATR#",barindex,open,Serif,Bold,12) coloured(153,153,153,alpha)

else

DrawText(" #myRange#/#myATR#/#myEATR#",barindex,open,Serif,Bold,12) coloured(255,153,0,alpha)

endif

//--end--

//--Dailys highest high and lowest Low--

if HighLow then

if openday <> openday[1] then

dayindex = dayindex + 1

dayhigh = 0

daylow = close

//dayopen = open

//dayclose = close

if dayindex > lookback then

for j = 1 to barindex

if dayindex[j] = dayindex - lookback then

mydayhigh = dayhigh[j]

mydaylow = daylow[j]

break

endif

dayhigh = max(dayhigh,high)

daylow = min(daylow,low)

endif

if dayindex < lookback or not highlow then

mydayhigh = undefined

mydaylow = undefined

endif

if dayindex < lookback or not Centerline then

mytdaycenter = undefined

endif

//--end--

//-- proof close over/under high or low of intraday range--

mytdayhigh=DHigh(0)

mytdaylow=DLow(0)

DM0 = (mytdayhigh-mytdaylow)/2+mytdaylow

If DayTrend = 1 then

if close > DM0 then

DrawText(" • over",barindex,open-10,Serif,Bold,12) coloured(0,255,0,alpha)

else

DrawText(" • under",barindex,open+10,Serif,Bold,12) coloured(255,0,0,alpha)

endif

//--end--

//--Centerline, center of range between intraday high/low--

If CenterLine = 1 then

mytdaycenter = DM0

else

mytdaycenter = undefined

endif

//--end--

//--Show Intraday HighLow as dotted line--

If HighLowIntraday = 1 then

mytdayhigh = DHigh(0)

mytdaylow = DLow(0)

else

mytdayhigh = undefined

mytdaylow = undefined

endif

//--end--

//--Arrows--

//Trend bzw Trend force

if Arrows = 1 then

BullTrend = (Close - LOWEST[20](LOW)) / AVERAGETRUERANGE[10]

BearTrend = (HIGHEST[20](HIGH) - Close) / AVERAGETRUERANGE[10]

Trend = (BullTrend - BearTrend)

TrendEMA = ExponentialAverage[20](Trend)

// On Balance Volumen zur Bestimmung der Kaufkraft der Bewegung/Trend

myOBV = OBV

myOBVA1 = ExponentialAverage[20](myOBV)

myOBVA2 = ExponentialAverage[10](myOBV)

if Trendforce = 1 and OBVforce = 1 then

If Trend > TrendEMA and myOBV > myOBVA1 and myOBV > myOBVA2 then

DRAWARROWup(barindex,low-2) coloured(0,255,0,alpha)

elsif Trend < TrendEMA and myOBV < myOBVA1 and myOBV < myOBVA2 then

DRAWARROWdown(barindex,high+2)coloured(255,0,0,alpha)

endif

elsIf OBVforce = 1 and not Trendforce then

if myOBV > myOBVA1 and myOBV > myOBVA2 then

DRAWARROWup(barindex,low-2) coloured(0,255,0,alpha)

elsif myOBV < myOBVA1 and myOBV < myOBVA2 then

DRAWARROWdown(barindex,high+2)coloured(255,0,0,alpha)

endif

elsIf Trendforce = 1 and not OBVforce then

if Trend > TrendEMA then

DRAWARROWup(barindex,low-2) coloured(0,255,0,alpha)

elsif Trend < TrendEMA then

DRAWARROWdown(barindex,high+2)coloured(255,0,0,alpha)

endif

//--end--

// End and make money

umebon

Participant

Topics: 29

Replies: 48

Been thanked: 4 times

07/08/2019 at 7:51 PM #102213

Vonasi

If there are any parameters that you have to set or can modify in the indicator window after it is applied to a chart then these are the parameters.

Vonasi

Moderator

Topics: 192

Replies: 5088

Been thanked: 1811 times

07/08/2019 at 8:00 PM #102214

umebon

I want the closing price (close) for each (day high, day low and day center) (5min) is that what I should put as a parameter or how do I write too get it?

umebon

Participant

Topics: 29

Replies: 48

Been thanked: 4 times

07/08/2019 at 10:18 PM #102220

Vonasi

I found some time to try to get CALL to work with that indicator but I couldn’t. There are no parameters needed but even if I created one by // out the lookback = 1 and creating lookback as a changeable parameter it still gives an error message.

The following strategy should just call the indicator (named MyIndicator(13) in my case) and draw the same lines on the chart but it gives the attached error.

ignored,ignored,mytdayhigh,mytdaylow,mytdaycenter = CALL "MyIndicator(13)"[1]

buy 1 contract at -high limit

graphonprice mytdayhigh 
graphonprice mytdaylow 
graphonprice mytdaycenter

ignored,ignored,mytdayhigh,mytdaylow,mytdaycenter = CALL "MyIndicator(13)"[1]

buy 1 contract at -high limit

graphonprice mytdayhigh

graphonprice mytdaylow

graphonprice mytdaycenter

I tested the same on a different indicator and it worked just fine so there is something about this indicator that it does not like.

You could just hard code the indicator into your strategy rather than use CALL while we all work out what is wrong.

Vonasi

Moderator

Topics: 192

Replies: 5088

Been thanked: 1811 times

07/08/2019 at 10:25 PM #102222

Vonasi

From a quick scan through of the code it seems that the values that you want are just the daily high and daily low and a mid point between them which you can simply get by adding the following to your strategy:

mytdayhigh=DHigh(0)
mytdaylow=DLow(0)
mytdaycentre = (mytdayhigh-mytdaylow)/2+mytdaylow

mytdayhigh=DHigh(0)

mytdaylow=DLow(0)

mytdaycentre = (mytdayhigh-mytdaylow)/2+mytdaylow

Vonasi

Moderator

Topics: 192

Replies: 5088

Been thanked: 1811 times

07/09/2019 at 7:22 AM #102238

umebon

Ok, I get the same error message when I run the program. It should work if we identify the problem. Thanks for the help and we keep in touch if we find a solotion.

umebon

Participant

Topics: 29

Replies: 48

Been thanked: 4 times

07/09/2019 at 8:06 AM #102246

Nicolas

Just add (Close) at the end of the CALL instruction and it should work.

1 user thanked author for this post.

umebon

Nicolas

Keymaster

Topics: 81

Replies: 20863

Been thanked: 4773 times

07/09/2019 at 8:50 AM #102251

Vonasi

So the correct format is (change indicator name to whatever you have it named as):

ignored,ignored,mytdayhigh,mytdaylow,mytdaycenter = CALL "MyIndicator"(close)

1	ignored,ignored,mytdayhigh,mytdaylow,mytdaycenter = CALL "MyIndicator"(close)

This deals with the required customclose that the indicator needs. I’ve had this issue before (this time I was putting the close in the [ ] which is why I could not get it to work!) Maybe the documentation for CALL needs a little update to cover this issue?

1 user thanked author for this post.

umebon

Vonasi

Moderator

Topics: 192

Replies: 5088

Been thanked: 1811 times

07/09/2019 at 9:10 AM #102252

Nicolas

I modified the CALL documentation.

2 users thanked author for this post.

umebon,

Vonasi

Nicolas

Keymaster

Topics: 81

Replies: 20863

Been thanked: 4773 times

07/15/2019 at 8:54 AM #102573

umebon

I am on vacation and I will take a look at this when I am back. Superthanks for the help so far!!

umebon

Participant

Topics: 29

Replies: 48

Been thanked: 4 times

Author

Posts

Viewing 12 posts - 1 through 12 (of 12 total)

Find exclusive trading pro-tools on