Cant find the bug with my candlesticks indicator

• 08/29/2017 at 1:04 PM #44842
  paddan

  Hi, i have got this indicator to detect and put a dot under every candle that has a body which is 50% or lower than the whole range. Problem is that it is in consequent, some candles it misses and some candles are not 50% or less that get a dot. Robertogozzi which wrote the code cant find the bug either. I would really be thankful if someone could help me solve this. Best!

  DEFPARAM CalculateOnLastBars = 1000 R=0 G=255 B=0 F=255 IF close > open THEN UpperShadow = high – close LowerShadow = open – low ELSE UpperShadow = high – open LowerShadow = close – low ENDIF Shadows = UpperShadow + LowerShadow Body = range – Shadows IF Body <= (Shadows / 2) THEN DotVal = low – (100 * pipsize) DRAWTEXT(“•”,barindex,DotVal,Dialog,Bold,12) coloured(R,G,B,F) ENDIF RETURN

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19

  DEFPARAM CalculateOnLastBars = 1000 R=0 G=255 B=0 F=255 IF close > open THEN    UpperShadow = high – close    LowerShadow = open – low ELSE    UpperShadow = high – open    LowerShadow = close – low ENDIF Shadows = UpperShadow  + LowerShadow Body = range – Shadows IF Body <= (Shadows / 2) THEN    DotVal = low – (100 * pipsize)    DRAWTEXT(“•”,barindex,DotVal,Dialog,Bold,12) coloured(R,G,B,F) ENDIF RETURN

   

  

  paddan

  Participant

  Topics: 2

  Replies: 11

  Been thanked: 1 time
  08/29/2017 at 1:18 PM #44845
  Alberto Menichetti

  I think the problem could be that the conditions you are testing for are “on-going”; only when the bar closes you can know for sure if that bar needs a dot

  

  Alberto Menichetti

  Participant

  Topics: 4

  Replies: 13

  Been thanked: 2 times
  08/29/2017 at 1:21 PM #44848
  JC_Bywan

  Line 15… would get rid of the “/2” to make it “IF Body <= Shadows THEN”, so that you get a 50% frontier of body vs range
  

  2 users thanked author for this post.

  robertogozzi, paddan

  

  JC_Bywan

  Moderator

  Topics: 20

  Replies: 2651

  Been thanked: 916 times
  08/29/2017 at 2:08 PM #44850
  paddan

  Really thank you! It helped me. Just wondering if you know a easy way to get those dots in the middle of every candle instead of below? Just if you knew a easy way to do that i would love you! 🙂

  

  paddan

  Participant

  Topics: 2

  Replies: 11

  Been thanked: 1 time
  08/29/2017 at 2:22 PM #44854
  JC_Bywan

  Line 16, I’d try replacing it with Dotval= (high+low)/2 in case you want middle of whole candle. Or if you prefer middle of body only rather than whole candle then you could also try with Dotval= (open+close)/2

  

  JC_Bywan

  Moderator

  Topics: 20

  Replies: 2651

  Been thanked: 916 times
  08/29/2017 at 3:12 PM #44861
  paddan

  Ok thanks! But somehow the indicator doesnt work, see image. Some candles which is obvious dont get the dot. I thought the problem was solved first. =/

  

  paddan

  Participant

  Topics: 2

  Replies: 11

  Been thanked: 1 time
  08/29/2017 at 3:32 PM #44863
  JC_Bywan

  Is this attachment on a weekly timeframe by any chance? There’s a platform bug for graphical instructions in weekly (and x weeks) timeframes only, that display any text or arrow one candle too early… All other timeframes are without this bug.

  So even if you didn’t say what timeframe this graph is, all dots look furiously in the wrong place to me, but at the right height if shifting all of them to the right by one candle, which is a strong match for the weekly graphical bug. So am I guessing right, your graph here is weekly but other smaller timeframes are ok?

   

  

  JC_Bywan

  Moderator

  Topics: 20

  Replies: 2651

  Been thanked: 916 times
  08/29/2017 at 5:51 PM #44869
  paddan

  No its not only weeks. the attached is daily. =/

  

  paddan

  Participant

  Topics: 2

  Replies: 11

  Been thanked: 1 time
  08/29/2017 at 6:01 PM #44874
  JC_Bywan

  last attachment in daily seems ok, dots on candles where they should be at first glance, what’s wrong with it?

   

  

  JC_Bywan

  Moderator

  Topics: 20

  Replies: 2651

  Been thanked: 916 times
  08/30/2017 at 7:14 AM #44893
  paddan

  there is a few which is missing dots.

  

  paddan

  Participant

  Topics: 2

  Replies: 11

  Been thanked: 1 time
  08/30/2017 at 8:05 AM #44895
  robertogozzi

  I tried it on DAX & EURUSD, daily charts, and it seems to be working fine!

  I did not take the the time to check each candle and do the math, but could not find any odd result.

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17148

  Been thanked: 4037 times
  08/30/2017 at 8:16 AM #44898
  paddan

  yes it looks good on yours! hmm strange.. what is wrong with mine then…

  

  paddan

  Participant

  Topics: 2

  Replies: 11

  Been thanked: 1 time
  08/30/2017 at 8:33 AM #44899
  robertogozzi

  What instrument is in your screenshot?

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17148

  Been thanked: 4037 times
  08/30/2017 at 12:37 PM #44918
  paddan

  gold

  

  paddan

  Participant

  Topics: 2

  Replies: 11

  Been thanked: 1 time
  08/30/2017 at 1:46 PM #44931
  robertogozzi

  It works perfectly on GOLD daily chart, as from the attached screenshot. I highlighted the same candles you circled.

  Here is the code, in case mine and yours mismatch, aside from where you want a dot plotted:

  DEFPARAM CalculateOnLastBars = 1000 R=0 G=255 B=0 F=255 IF close > open THEN UpperShadow = high - close LowerShadow = open - low ELSE UpperShadow = high - open LowerShadow = close - low ENDIF Shadows = UpperShadow + LowerShadow Body = range - Shadows IF Body <= Shadows THEN DotVal = low - (10 * pipsize) DRAWTEXT("•",barindex,DotVal,Dialog,Bold,12) coloured(R,G,B,F) ENDIF RETURN

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19

  DEFPARAM CalculateOnLastBars = 1000 R=0 G=255 B=0 F=255 IF close > open THEN    UpperShadow = high - close    LowerShadow = open - low ELSE    UpperShadow = high - open    LowerShadow = close - low ENDIF Shadows = UpperShadow  + LowerShadow Body = range - Shadows IF Body <= Shadows THEN    DotVal = low - (10 * pipsize)    DRAWTEXT("•",barindex,DotVal,Dialog,Bold,12) coloured(R,G,B,F) ENDIF RETURN

   

  If it’s the same…. maybe a graphical issue, the numer of pixels…. I really couldn’t tell!

  2 users thanked author for this post.

  Nicolas, paddan

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17148

  Been thanked: 4037 times
• Author
  Posts