Close of cross-over candle

• 11/08/2016 at 8:16 PM #16206
  Attienel

  Hallo there,

  Please help me.

  indicator1 = Average[8](close) indicator2 = Average[24](close) c1 = (indicator1 CROSSES OVER indicator2)

  1 2 3

  indicator1 = Average[8](close) indicator2 = Average[24](close) c1 = (indicator1 CROSSES OVER indicator2)

  I want to calculate the Close of the candle (c1 above) when the cross-over occurred (or just after the cross-over occurred). I want to enter a trade once a candle following the cross-over closes above the close of the cross-over candle.

  

  Attienel

  Participant

  Topics: 5

  Replies: 12

  Been thanked: 1 time
  11/09/2016 at 10:40 AM #16220
  Nicolas

  You need here to store the Close value when your condition c1 occurred:

  c1 = (indicator1 CROSSES OVER indicator2) if c1 then val = Close endif

  1 2 3 4

  c1 = (indicator1 CROSSES OVER indicator2) if c1 then val = Close endif

  Then you can test if the next Closes will cross over this value. But it’s also possible that the price is already above this level .. so you have to deal with this too.

  c2 = Close crosses over val

  1	c2 = Close crosses over val

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4775 times
  11/09/2016 at 12:40 PM #16226
  Attienel

  Thank you Nic, you’ve put me on the path to success.

  I amended my code but now don’t get any Long entries. Can you possibly see what is wrong with my code?

   

  // Definition of code parameters DEFPARAM CumulateOrders = False // Cumulating positions deactivated // Conditions to enter long positions indicator1 = Average[8](close) indicator2 = Average[24](close) c1 = (indicator1 CROSSES OVER indicator2) if c1 then val = Close endif c2 = Close crosses over val c3 = Average[8](close) > Average[24](close) IF c1 THEN WHILE c3 IF c2 THEN BUY 1 CONTRACT AT MARKET ENDIF WEND ENDIF // Conditions to exit long positions indicator3 = Average[24](close) c4 = (close < indicator3) IF c4 THEN SELL AT MARKET ENDIF // Conditions to enter short positions indicator4 = Average[8](close) indicator5 = Average[24](close) c5 = (indicator4 CROSSES UNDER indicator5) IF c5 THEN SELLSHORT 1 CONTRACT AT MARKET ENDIF // Conditions to exit short positions indicator6 = Average[24](close) c6 = (close > indicator6) IF c6 THEN EXITSHORT AT MARKET ENDIF // Stops and targets SET STOP %LOSS 2

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50

  // Definition of code parameters DEFPARAM CumulateOrders = False // Cumulating positions deactivated   // Conditions to enter long positions indicator1 = Average[8](close) indicator2 = Average[24](close) c1 = (indicator1 CROSSES OVER indicator2)   if c1 then val = Close endif   c2 = Close crosses over val   c3 = Average[8](close) > Average[24](close)   IF c1 THEN WHILE c3 IF c2 THEN BUY 1 CONTRACT AT MARKET ENDIF WEND ENDIF   // Conditions to exit long positions indicator3 = Average[24](close) c4 = (close < indicator3)   IF c4 THEN SELL AT MARKET ENDIF // Conditions to enter short positions indicator4 = Average[8](close) indicator5 = Average[24](close) c5 = (indicator4 CROSSES UNDER indicator5)   IF c5 THEN SELLSHORT 1 CONTRACT AT MARKET ENDIF   // Conditions to exit short positions indicator6 = Average[24](close) c6 = (close > indicator6)   IF c6 THEN EXITSHORT AT MARKET ENDIF   // Stops and targets SET STOP %LOSS 2

   

  

  Attienel

  Participant

  Topics: 5

  Replies: 12

  Been thanked: 1 time
  11/09/2016 at 2:14 PM #16237
  Nicolas

  You should GRAPH you new “val” variable and see if it correctly stored the good information, also with Close to test the cross over “visually”

  GRAPH val coloured(255,0,0) GRAPH close coloured(0,200,20)

  1 2	GRAPH val coloured(255,0,0) GRAPH close coloured(0,200,20)

   

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4775 times
  11/09/2016 at 2:36 PM #16242
  JC_Bywan

  I haven’t tried it, but isn’t there a “DO” missing in line 18 for the “While… Do… Wend”?

  

  JC_Bywan

  Moderator

  Topics: 20

  Replies: 2679

  Been thanked: 946 times
  11/09/2016 at 4:54 PM #16243
  Attienel

  Hi, me again,

  I amended the code but it still doesn’t create Long positions.  After the initial cross-over, I wait for confirmation (c2 and c3), which could be a few candles down the line, before I enter a trade (post confirmation). Does my code reflect this?

  // Definition of code parameters DEFPARAM CumulateOrders = False // Cumulating positions deactivated // Conditions to enter long positions indicator1 = Average[8](close) indicator2 = Average[24](close) c1 = (indicator1 CROSSES OVER indicator2) if c1 then val = Close endif c2 = Close crosses over val c3 = Average[8](close) > Average[24](close) IF c1 THEN WHILE c3 DO IF c2 THEN BUY AT MARKET ENDIF WEND ENDIF GRAPH val coloured(255,0,0) GRAPH close coloured(0,200,20)

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24

  // Definition of code parameters DEFPARAM CumulateOrders = False // Cumulating positions deactivated   // Conditions to enter long positions indicator1 = Average[8](close) indicator2 = Average[24](close) c1 = (indicator1 CROSSES OVER indicator2)   if c1 then val = Close endif   c2 = Close crosses over val c3 = Average[8](close) > Average[24](close)   IF c1 THEN WHILE c3 DO IF c2 THEN BUY AT MARKET ENDIF WEND ENDIF GRAPH val coloured(255,0,0) GRAPH close coloured(0,200,20)

   

  

  Attienel

  Participant

  Topics: 5

  Replies: 12

  Been thanked: 1 time
  11/09/2016 at 5:44 PM #16250
  Nicolas

  > For clarity of messages on ProRealCode’s forums, please use the “insert code PRT” button to separate the text of the code part! Thank you! <<

  Did you learn something while debugging with GRAPH? Do the “val” variable correctly stored? Do the Close cross above it sometimes? ..

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4775 times
  11/09/2016 at 9:37 PM #16259
  Attienel

  Hi Nic,

  I will comply with the “insert code PRT” requirement.   Thanks for pointing that out.

  The “val” variable and Close variables are correctly stored and displayed on the graph. If I look at my chart, there are many instances where a candle following the cross-over candle closes above “val” but the code doesn’t trigger the respective entries so I can’t do proper debugging. Please see attached screen dump.

  Thanks

   

   

  

  Attienel

  Participant

  Topics: 5

  Replies: 12

  Been thanked: 1 time
• Author
  Posts