Coding question

• 03/01/2016 at 6:36 PM #3360
  Sofitech

  Hello. I have a question about how to modify a code from the library.
  I’ve seen the Renko box on price chart indicator. I would like to know how to modify indicators to make them calculated on the renko box and not on the price. In the Renko indicator, i’ve seen 2 information Top and Bottom of the box. Maybe the middle would be correct… well, the goal would be to have the indicator calculated just like if it was on renko chart.

  So, let’s take for example the “Stair Step” indicator How would you modify the code to make it calculated on renko box indicator ??
  Here is the code :

  //parameters :
  // Step = 0.0010 forex 10 pips, adapt to item you are trading
  // MAperiod = 20

  once ssMA = close
  MA = average[MAperiod](close)

  if(MA > ssMA + Step) THEN
  ssMA = MA
  ELSIF (MA < ssMA – Step) THEN
  ssMA = MA
  ELSE
  ssMA = ssMA
  ENDIF

  RETURN ssMA

  And here is the renko code :

  <span class="token comment" spellcheck="true">//parameters :</span> <span class="token comment" spellcheck="true">// boxsize = 100 //1 hour timeframe default size, adapt it for your </span> <span class="token keyword">once</span> topprice <span class="token operator">=</span> <span class="token keyword">close</span> <span class="token keyword">once</span> bottomprice <span class="token operator">=</span> <span class="token keyword">close</span> <span class="token operator">-</span> boxsize<span class="token operator">*</span><span class="token number">2</span> <span class="token keyword">if</span><span class="token punctuation">(</span><span class="token keyword">close</span> <span class="token operator">></span> topprice <span class="token operator">+</span> boxsize<span class="token operator">*</span><span class="token number">2</span><span class="token punctuation">)</span> <span class="token keyword">THEN</span> topprice <span class="token operator">=</span> <span class="token keyword">close</span> bottomprice <span class="token operator">=</span> topprice <span class="token operator">-</span> boxsize<span class="token operator">*</span><span class="token number">2</span> <span class="token keyword">ELSIF</span> <span class="token punctuation">(</span><span class="token keyword">close</span> <span class="token operator"><</span> bottomprice <span class="token operator">-</span> boxsize<span class="token operator">*</span><span class="token number">2</span><span class="token punctuation">)</span> <span class="token keyword">THEN</span> bottomprice <span class="token operator">=</span> <span class="token keyword">close</span> topprice <span class="token operator">=</span> bottomprice <span class="token operator">+</span> boxsize<span class="token operator">*</span><span class="token number">2</span> <span class="token keyword">ELSE</span> topprice <span class="token operator">=</span> topprice bottomprice <span class="token operator">=</span> bottomprice <span class="token keyword">ENDIF</span> <span class="token keyword">RETURN</span> topprice <span class="token keyword">as</span> <span class="token string">"box top"</span><span class="token punctuation">,</span> bottomprice <span class="token keyword">as</span> <span class="token string">"bottom box" </span>

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21

  <span class="token comment" spellcheck="true">//parameters :</span> <span class="token comment" spellcheck="true">// boxsize = 100 //1 hour timeframe default size, adapt it for your </span>   <span class="token keyword">once</span> topprice <span class="token operator">=</span> <span class="token keyword">close</span> <span class="token keyword">once</span> bottomprice <span class="token operator">=</span> <span class="token keyword">close</span> <span class="token operator">-</span> boxsize<span class="token operator">*</span><span class="token number">2</span>   <span class="token keyword">if</span><span class="token punctuation">(</span><span class="token keyword">close</span> <span class="token operator">></span> topprice <span class="token operator">+</span> boxsize<span class="token operator">*</span><span class="token number">2</span><span class="token punctuation">)</span> <span class="token keyword">THEN</span>    topprice <span class="token operator">=</span> <span class="token keyword">close</span>    bottomprice <span class="token operator">=</span> topprice <span class="token operator">-</span> boxsize<span class="token operator">*</span><span class="token number">2</span> <span class="token keyword">ELSIF</span> <span class="token punctuation">(</span><span class="token keyword">close</span> <span class="token operator"><</span> bottomprice <span class="token operator">-</span> boxsize<span class="token operator">*</span><span class="token number">2</span><span class="token punctuation">)</span> <span class="token keyword">THEN</span>    bottomprice <span class="token operator">=</span> <span class="token keyword">close</span>    topprice <span class="token operator">=</span> bottomprice <span class="token operator">+</span> boxsize<span class="token operator">*</span><span class="token number">2</span> <span class="token keyword">ELSE</span>    topprice <span class="token operator">=</span> topprice    bottomprice <span class="token operator">=</span> bottomprice <span class="token keyword">ENDIF</span>     <span class="token keyword">RETURN</span> topprice <span class="token keyword">as</span> <span class="token string">"box top"</span><span class="token punctuation">,</span> bottomprice <span class="token keyword">as</span> <span class="token string">"bottom box"   </span>

  

  Sofitech

  Participant

  Topics: 55

  Replies: 147

  Been thanked: 10 times
  03/01/2016 at 8:18 PM #3363
  Nicolas

  Well, if i understand correctly, you would like to make the stairstep moving average calculated with something else than a classical candle close? And in your case, that would be the close of a renko box? (or my so called indicator..:) )

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  03/01/2016 at 9:16 PM #3364
  Sofitech

  Yes ! Correct. To have the same result than on a renko chart… but on candlestick chart with your renko indicator.

  

  Sofitech

  Participant

  Topics: 55

  Replies: 147

  Been thanked: 10 times
  03/02/2016 at 8:28 AM #3365
  Nicolas

  First, you’ll have to adapt the renko indicator with a new variable that deal with what is the current close. Because indicators are often calculated on Close, my renko box indicator does not have one.

  if(close > topprice + boxsize*2) THEN topprice = close bottomprice = topprice - boxsize*2 boxclose = topprice ELSIF (close < bottomprice - boxsize*2) THEN bottomprice = close topprice = bottomprice + boxsize*2 boxclose = bottomprice ELSE topprice = topprice bottomprice = bottomprice boxclose = boxclose ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13

  if(close > topprice + boxsize*2) THEN    topprice = close    bottomprice = topprice - boxsize*2    boxclose = topprice ELSIF (close < bottomprice - boxsize*2) THEN    bottomprice = close    topprice = bottomprice + boxsize*2    boxclose = bottomprice ELSE    topprice = topprice    bottomprice = bottomprice    boxclose = boxclose ENDIF

  Then, instead of having :

  MA = average[MAperiod](close)

  1	MA = average[MAperiod](close)

   

  You should make :

  MA = average[MAperiod](boxclose)

  1	MA = average[MAperiod](boxclose)

   

  But you have to merge the 2 indicators first. Let me know if it works like you want.

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  03/02/2016 at 9:56 AM #3368
  Sofitech

  Thanks a lot for your answer.
  I let you see if it can work like i want and tell me if it is the case.
  Thanks again

  

  Sofitech

  Participant

  Topics: 55

  Replies: 147

  Been thanked: 10 times
  03/02/2016 at 11:44 AM #3370
  Nicolas

  

  Here is the full indicator code :

  //parameters : // boxsize = 100 //1 hour timeframe default size, adapt it for your // Step = 0.0010 forex 10 pips, adapt to item you are trading // MAperiod = 20 boxsize = 100*pipsize Step = 10*pipsize MAperiod = 20 once topprice = close once bottomprice = close - boxsize*2 once ssMA = close if(close > topprice + boxsize*2) THEN topprice = close bottomprice = topprice - boxsize*2 boxclose = topprice ELSIF (close < bottomprice - boxsize*2) THEN bottomprice = close topprice = bottomprice + boxsize*2 boxclose = bottomprice ELSE topprice = topprice bottomprice = bottomprice boxclose = boxclose ENDIF MA = average[MAperiod](boxclose) if(MA > ssMA + Step) THEN ssMA = MA ELSIF (MA < ssMA - Step) THEN ssMA = MA ELSE ssMA = ssMA ENDIF RETURN ssMA

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38

  //parameters : // boxsize = 100 //1 hour timeframe default size, adapt it for your // Step = 0.0010 forex 10 pips, adapt to item you are trading // MAperiod = 20   boxsize = 100*pipsize Step = 10*pipsize MAperiod = 20   once topprice = close once bottomprice = close - boxsize*2 once ssMA = close   if(close > topprice + boxsize*2) THEN   topprice = close   bottomprice = topprice - boxsize*2   boxclose = topprice ELSIF (close < bottomprice - boxsize*2) THEN   bottomprice = close   topprice = bottomprice + boxsize*2   boxclose = bottomprice ELSE   topprice = topprice   bottomprice = bottomprice   boxclose = boxclose ENDIF   MA = average[MAperiod](boxclose)   if(MA > ssMA + Step) THEN   ssMA = MA ELSIF (MA < ssMA - Step) THEN   ssMA = MA ELSE   ssMA = ssMA ENDIF   RETURN ssMA

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  03/02/2016 at 11:47 AM #3372
  Nicolas

  With the boxes, more visual :

  

  Just change the last line of the indicator by this :

  RETURN ssMA, topprice as "box top", bottomprice as "bottom box"

  1	RETURN ssMA, topprice as "box top", bottomprice as "bottom box"

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  03/02/2016 at 12:23 PM #3373
  Sofitech

  Just great. Thanks.

  

  Sofitech

  Participant

  Topics: 55

  Replies: 147

  Been thanked: 10 times
  03/02/2016 at 1:02 PM #3376
  Nicolas

  You are welcome. Just ask. 🙂

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  03/15/2016 at 12:45 PM #3769
  Nicolas

  Hey Sofitech, does it work like you want?

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
• Author
  Posts