Compare highest high between two points

• 06/21/2016 at 10:17 AM #9636
  ck1066

  Hi,

  I’m hoping someone will be able to help.

  How do I compare the highest high between the last 6 bars and last 30 bars in ProBuilder? I’ve tried the following syntax in my indicator without any success.

  highest[6](high[1]) > highest[30](high[1])

  Any help would be appreciated.

  Thanks

   

  

  ck1066

  Participant

  Topics: 22

  Replies: 34

  Been thanked: 0 times
  06/21/2016 at 11:42 AM #9640
  Nicolas

  Hi,

  An easy way to do it would be:

  hh1 = highest[6](high) hh2 = highest[30](high) test = hh1[1]>hh2[1]

  1 2 3 4

  hh1 = highest[6](high) hh2 = highest[30](high)   test = hh1[1]>hh2[1]

  By doing this you can compare offset of any of the hh1 and hh2 arrays value.

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  06/21/2016 at 7:52 PM #9645
  ck1066

  Thanks. I’ll give it a try.

  

  ck1066

  Participant

  Topics: 22

  Replies: 34

  Been thanked: 0 times
  06/23/2016 at 12:22 AM #9701
  ck1066

  Hi,

  tried the suggestion but didn’t work, and still need help.

  If I remove the code in bold it works, but without testing to see if it has made a higher high, in addition to a higher low. This is simply to test we are in an up trend using price action.

   

  ///////LONG POSITION ma1=ExponentialAverage[20](close) stochk=Stochastic[8,3](close) c1=close crosses over ma1 c2=close>ma1 lh1=lowest[6](low) lh2=lowest[40](low) <strong>hh1=highest[6](high) hh2=highest[40](high)</strong> c3=lh1[1]>lh2[1] c4=stochk>stochk[1] <strong>c5=hh1[1]>hh2[1]</strong> up=c1 and c2 and c3 and c4 and <strong>c5</strong>

  1 2 3 4 5 6 7 8 9 10 11 12 13

  ///////LONG POSITION ma1=ExponentialAverage[20](close) stochk=Stochastic[8,3](close) c1=close crosses over ma1 c2=close>ma1 lh1=lowest[6](low) lh2=lowest[40](low) <strong>hh1=highest[6](high) hh2=highest[40](high)</strong> c3=lh1[1]>lh2[1] c4=stochk>stochk[1] <strong>c5=hh1[1]>hh2[1]</strong> up=c1 and c2 and c3 and c4 and <strong>c5</strong>

   

  

  ck1066

  Participant

  Topics: 22

  Replies: 34

  Been thanked: 0 times
  06/23/2016 at 6:51 AM #9705
  ck1066

  Apologies for the formatting issue, that should be, if I remove lines 8,9, and 12 and change line 13 to exclude “and c5” it works without testing the last higher high against the previous higher high.

  

  ck1066

  Participant

  Topics: 22

  Replies: 34

  Been thanked: 0 times
  06/23/2016 at 8:18 AM #9711
  Nicolas

  As you can see in the picture below, the 6 periods highest high/lowest low channel is always included into the 40 periods. So to test a breakout of the 40 periods channel, you should test if the 6 periods one is inferior or superior with a candlestick offset more longer:

  c3=lh1[1]>lh2[10]

  1	c3=lh1[1]>lh2[10]

  Sorry, if I put you on the wrong track in my previous reply.

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  06/23/2016 at 8:51 AM #9720
  ck1066

  Thanks again for your prompt reply.

  Please see the attached image for what I’m trying to achieve within the code as I think we may have our wires crossed.

  Curent position is true if:

  Uptrend

  HH1>HH2 and

  HL1>HL2

  Downtrend

  LH1<LH2 and

  LL1<LL2

   

  the following code is my attempt. Lines 12,13 and 16 have been REM’d out as it’s currently not working

  res = 0 ma1=ExponentialAverage[20](close) //stochd = Average[3](Stochastic[8,3](close)) stochk=Stochastic[8,3](close) //rs=RSI[14] ///////LONG POITION c1=close crosses over ma1 c2=close>ma1 lh1=lowest[6](low) lh2=lowest[40](low) //hh1=highest[12](high) //hh2=highest[40](high) c3=lh1[1]>lh2[1] c4=stochk>stochk[1] //c5=hh1[1]>=hh2 up=c1 and c2 and c3 and c4 //////SHORT POSITION d1=close crosses under ma1 d2=close<ma1 hl1=highest[6](high) hl2=highest[40](high) d3=hl1[1]<hl2[1] d4=stochk<stochk[1] down=d1 and d2 and d3 and d4 if up then res=1 elsif down then res=-1 endif return res as "x"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38

  res = 0 ma1=ExponentialAverage[20](close) //stochd = Average[3](Stochastic[8,3](close)) stochk=Stochastic[8,3](close) //rs=RSI[14]   ///////LONG POITION c1=close crosses over ma1 c2=close>ma1 lh1=lowest[6](low) lh2=lowest[40](low) //hh1=highest[12](high) //hh2=highest[40](high) c3=lh1[1]>lh2[1] c4=stochk>stochk[1] //c5=hh1[1]>=hh2 up=c1 and c2 and c3 and c4     //////SHORT POSITION d1=close crosses under ma1 d2=close<ma1 hl1=highest[6](high) hl2=highest[40](high) d3=hl1[1]<hl2[1] d4=stochk<stochk[1] down=d1 and d2 and d3 and d4         if up then res=1 elsif down then res=-1 endif   return res as "x"

   

  

  ck1066

  Participant

  Topics: 22

  Replies: 34

  Been thanked: 0 times
  06/23/2016 at 9:11 AM #9725
  Nicolas

  Hmm that’s working for me if you use my previous solution …. ->

  res = 0 ma1=ExponentialAverage[20](close) //stochd = Average[3](Stochastic[8,3](close)) stochk=Stochastic[8,3](close) //rs=RSI[14] ///////LONG POITION c1=close crosses over ma1 c2=close>ma1 lh1=lowest[6](low) lh2=lowest[40](low) c3=lh1[1]>lh2[10] c4=stochk>stochk[1] up=c1 and c2 and c3 and c4 //////SHORT POSITION d1=close crosses under ma1 d2=close<ma1 hl1=highest[6](high) hl2=highest[40](high) d3=hl1[1]<hl2[10] d4=stochk<stochk[1] down=d1 and d2 and d3 and d4 if up then res=1 elsif down then res=-1 endif return res as "x"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34

  res = 0 ma1=ExponentialAverage[20](close) //stochd = Average[3](Stochastic[8,3](close)) stochk=Stochastic[8,3](close) //rs=RSI[14]   ///////LONG POITION c1=close crosses over ma1 c2=close>ma1 lh1=lowest[6](low) lh2=lowest[40](low) c3=lh1[1]>lh2[10] c4=stochk>stochk[1]   up=c1 and c2 and c3 and c4     //////SHORT POSITION d1=close crosses under ma1 d2=close<ma1 hl1=highest[6](high) hl2=highest[40](high) d3=hl1[1]<hl2[10] d4=stochk<stochk[1]   down=d1 and d2 and d3 and d4   if up then res=1 elsif down then res=-1 endif   return res as "x"

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  06/23/2016 at 10:20 AM #9733
  ck1066

  Oops I pasted the wrong version of the code.

  Below is the code, which at the moment was testing the long position section. The offending lines have been rem’d out (lines 12,13 and 16). Also condition c5 is not currently tested as it doesn’t work as expected.

   

  res = 0 ma1=ExponentialAverage[20](close) //stochd = Average[3](Stochastic[8,3](close)) stochk=Stochastic[8,3](close) //rs=RSI[14] ///////LONG POITION c1=close crosses over ma1 c2=close>ma1 lh1=lowest[6](low) lh2=lowest[40](low) //hh1=highest[12](high) //hh2=highest[40](high) c3=lh1[1]>lh2[1] c4=stochk>stochk[1] //c5=hh1[1]>=hh2 up=c1 and c2 and c3 and c4 //////SHORT POSITION d1=close crosses under ma1 d2=close<ma1 hl1=highest[6](high) hl2=highest[40](high) d3=hl1[1]<hl2[1] d4=stochk<stochk[1] down=d1 and d2 and d3 and d4 if up then res=1 elsif down then res=-1 endif return res as "x"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40

  res = 0 ma1=ExponentialAverage[20](close) //stochd = Average[3](Stochastic[8,3](close)) stochk=Stochastic[8,3](close) //rs=RSI[14]   ///////LONG POITION c1=close crosses over ma1 c2=close>ma1 lh1=lowest[6](low) lh2=lowest[40](low) //hh1=highest[12](high) //hh2=highest[40](high) c3=lh1[1]>lh2[1] c4=stochk>stochk[1] //c5=hh1[1]>=hh2 up=c1 and c2 and c3 and c4         //////SHORT POSITION d1=close crosses under ma1 d2=close<ma1 hl1=highest[6](high) hl2=highest[40](high) d3=hl1[1]<hl2[1] d4=stochk<stochk[1] down=d1 and d2 and d3 and d4         if up then res=1 elsif down then res=-1 endif   return res as "x"

   

  

  ck1066

  Participant

  Topics: 22

  Replies: 34

  Been thanked: 0 times
  06/23/2016 at 12:10 PM #9738
  Nicolas

  Did you test my code?

  http://www.prorealcode.com/topic/compare-highest-high-between-two-points/#post-9725

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  06/23/2016 at 2:24 PM #9751
  ck1066

  Yes I tested your code but the result is still the same.

  both indicators tests the last two lowest low but not the last two highest highs in and uptrend successfully, vice versa in a downtrend.

  I have attached a screen capture showing your indicator  as (prt) at the bottom and my indicator (7) just above. Both missed the corresponding alert highlighted on the chart.

  I think it might be the way HH2 is being selected within the code. I guess ideally I need to somehow pick the highest high between 7 and 40. Is this possible?

  

  ck1066

  Participant

  Topics: 22

  Replies: 34

  Been thanked: 0 times
  06/23/2016 at 4:44 PM #9758
  Nicolas

  Ok, but did you put 2 Donchian channels of 6 and 40 periods to verify if your setup is valid? One of the condition is not true, you have to test them individually, sorry it’s debugging time … 🙂

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  06/23/2016 at 5:10 PM #9762
  ck1066

  I’m not familiar with Donchian channels, as I have never used them. I’ll add them and see what results I get. This may take some time to debug 🙂

  

  ck1066

  Participant

  Topics: 22

  Replies: 34

  Been thanked: 0 times
  06/23/2016 at 7:17 PM #9774
  Nicolas

  Donchian channels is exactly what you use in your code, it is a channel made of the highest high and lowest low over n periods :

  //Donchian channel - 6 periods lookback hh=highest[6](high) ll=lowest[6](low) RETURN hh,ll

  1 2 3 4 5 6

  //Donchian channel - 6 periods lookback   hh=highest[6](high) ll=lowest[6](low)   RETURN hh,ll

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  06/24/2016 at 10:39 AM #9787
  ck1066

  Following some debugging it appears the problem lies in how highest[40](high) and lowest[40](low) are evaluated.

  What I really need to express somehow is to excluding the first 6 bars i.e.

  highest[7 to 40](high)

  and also

  lowest[7 to 40](low)

  Any ideas how this can be achieved using the correct syntax?

   

  

  ck1066

  Participant

  Topics: 22

  Replies: 34

  Been thanked: 0 times
• Author
  Posts