Cumulating positions ARE NOT WORKING

• 08/27/2021 at 4:04 AM #176322
  efahmy

  Gents,
  Could you check this code why the Cumulating positions are not working??

  CumulateOrders NOT WORKING

  // Definition of code parameters DEFPARAM CumulateOrders = True // Cumulating positions activated timeframe(DEFAULT) MaxPositionsAllowed = 5 // Conditions to enter long positions indicator1 = MACDline[5,35,5](close) indicator2 = MACDSignal[5,35,5](close) c1 = (indicator1 CROSSES OVER indicator2) PP = (DHigh(1) + DLow(1) + DClose(1))/3 C2 = (close < indicator1) S3 = DLow(1)-2*(DHigh(1)-(DHigh(1) + DLow(1) + DClose(1))/3) C3 = (close > indicator2) IF c1 AND c2 AND c3 THEN BUY 50 CONTRACT AT MARKET ENDIF // Stops and targets SET TARGET pPROFIT 2.0

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17

  // Definition of code parameters DEFPARAM CumulateOrders = True // Cumulating positions activated timeframe(DEFAULT) MaxPositionsAllowed = 5 // Conditions to enter long positions indicator1 = MACDline[5,35,5](close) indicator2 = MACDSignal[5,35,5](close) c1 = (indicator1 CROSSES OVER indicator2) PP = (DHigh(1) + DLow(1) + DClose(1))/3 C2 = (close < indicator1) S3 = DLow(1)-2*(DHigh(1)-(DHigh(1) + DLow(1) + DClose(1))/3) C3 = (close > indicator2) IF c1 AND c2 AND c3 THEN BUY 50 CONTRACT AT MARKET ENDIF // Stops and targets SET TARGET pPROFIT 2.0

   

  

  efahmy

  Participant

  Topics: 21

  Replies: 45

  Been thanked: 2 times
  08/27/2021 at 6:58 AM #176326
  Swingueur

  Hello,
  What is the issue that you have and make you say it’s not working?
  For sure, the variable MaxPositionsAllowed is defined but not used in the code, which is not good, the system will rebuy more than 5 times
  Assuming that the conditions are met, I would try something like this, and verifying the number of positions in the graph once the results are generated.

  Modification proposal

  ounce n=0 .... IF NOT LongOnMarket THEN n=0 ENDIF IF c1 AND c2 AND c3 AND n<MaxPositionsAllowed THEN BUY 50 CONTRACT AT MARKET n=n+1 ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12

  ounce n=0   ....   IF NOT LongOnMarket THEN n=0 ENDIF   IF c1 AND c2 AND c3 AND n<MaxPositionsAllowed THEN BUY 50 CONTRACT AT MARKET n=n+1 ENDIF

  

  Swingueur

  Participant

  Topics: 4

  Replies: 91

  Been thanked: 29 times
  08/27/2021 at 7:45 AM #176330
  robertogozzi

  Conditions in lines 13 and 15 seem to be impossible to be both true at the same time.

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17138

  Been thanked: 4032 times
  08/27/2021 at 7:46 AM #176331
  efahmy

  The issue is that the code buy only once and never buy again when the conditions are met??!!

  

  efahmy

  Participant

  Topics: 21

  Replies: 45

  Been thanked: 2 times
  08/27/2021 at 7:54 AM #176333
  Nicolas

  Condition C2 & C3, you are checking the price with an MACD line?! They do not share the same scale.

  When do you see an order opening? At beginning of the data history or later?

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  08/27/2021 at 8:01 AM #176337
  efahmy

  Its not buying again regardless of C2 and C3

  // Definition of code parameters DEFPARAM CumulateOrders = True // Cumulating positions activated timeframe(DEFAULT) MaxPositionsAllowed = 5 // Conditions to enter long positions indicator1 = MACDline[5,35,5](close) indicator2 = MACDSignal[5,35,5](close) c1 = (indicator1 CROSSES OVER indicator2) PP = (DHigh(1) + DLow(1) + DClose(1))/3 C2 = (close < PP) S3 = DLow(1)-2*(DHigh(1)-(DHigh(1) + DLow(1) + DClose(1))/3) C3 = (close > S3) IF c1 AND c2 AND c3 THEN BUY 50 CONTRACT AT MARKET ENDIF // Stops and targets SET TARGET pPROFIT 2.0

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17

  // Definition of code parameters DEFPARAM CumulateOrders = True // Cumulating positions activated timeframe(DEFAULT) MaxPositionsAllowed = 5 // Conditions to enter long positions indicator1 = MACDline[5,35,5](close) indicator2 = MACDSignal[5,35,5](close) c1 = (indicator1 CROSSES OVER indicator2) PP = (DHigh(1) + DLow(1) + DClose(1))/3 C2 = (close < PP) S3 = DLow(1)-2*(DHigh(1)-(DHigh(1) + DLow(1) + DClose(1))/3) C3 = (close > S3) IF c1 AND c2 AND c3 THEN BUY 50 CONTRACT AT MARKET ENDIF // Stops and targets SET TARGET pPROFIT 2.0

   

  

  efahmy

  Participant

  Topics: 21

  Replies: 45

  Been thanked: 2 times
  08/27/2021 at 8:52 AM #176344
  nonetheless

  this is the entry code for a cumulating algo I have up and running and I know works. In this case the limit is 3 entries instead of 5, but you can adapt it.

  The logic of MaxPositionsAllowed is to control the total number of contracts, not the number of entries. The code below will make 3 entries of 50 contracts each.

  Another stipulation I use, that you might want to consider, is adding “and positionperf <0” to your additional entries, so that your total position is always averaging down.

   

  positionsize = 50 MaxPositionsAllowed = 3*positionsize if not onmarket then flag = 1 flag1 = 1 ENDIF // Conditions to enter long positions IF not longonmarket and (conditions) THEN BUY positionsize CONTRACT AT MARKET elsif longonmarket and (conditions) and flag and COUNTOFLONGSHARES < MaxPositionsAllowed then BUY positionsize CONTRACT AT MARKET flag = 0 elsif longonmarket and (conditions) and flag1 and COUNTOFLONGSHARES < MaxPositionsAllowed then BUY positionsize CONTRACT AT MARKET flag1 = 0 ENDIF If LongOnMarket THEN SET STOP %LOSS sl SET TARGET %PROFIT tp ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24

  positionsize = 50   MaxPositionsAllowed = 3*positionsize   if not onmarket then flag = 1 flag1 = 1 ENDIF   // Conditions to enter long positions IF not longonmarket and (conditions) THEN BUY positionsize CONTRACT AT MARKET elsif longonmarket and (conditions) and flag and COUNTOFLONGSHARES < MaxPositionsAllowed then BUY positionsize CONTRACT AT MARKET flag = 0 elsif longonmarket and (conditions) and flag1 and COUNTOFLONGSHARES < MaxPositionsAllowed then BUY positionsize CONTRACT AT MARKET flag1 = 0 ENDIF   If LongOnMarket THEN SET STOP %LOSS sl SET TARGET %PROFIT tp ENDIF

   

  2 users thanked author for this post.

  Midlanddave, efahmy

  

  nonetheless

  Participant

  Topics: 83

  Replies: 1237

  Been thanked: 978 times
  08/27/2021 at 9:31 AM #176351
  deletedaccount051022

  I really like the addition of the  “and positionperf <0” , neat snippet – thank you for sharing.

  1 user thanked author for this post.

  nonetheless

  

  deletedaccount051022

  Participant

  Topics: 26

  Replies: 139

  Been thanked: 99 times
• Author
  Posts