Display Line Name of Fibonacci Lines

• 05/28/2020 at 6:47 AM #133541
  parthapersonal

  Hello,

  I have written the code for previous day Fibonacci levels however can you please let me know how to put the “name tag” (as PRT does for Pivot lines) on top of the lines, e.g. it should write “1.618” on top of the line left justified.

  Many thanks.

  

  parthapersonal

  Participant

  Topics: 10

  Replies: 71

  Been thanked: 3 times
  05/28/2020 at 7:08 AM #133544
  parthapersonal

  Sorry for double post since in the first instance I got WordPress Error.

  When I am adding the below code then 1.618 is coming across the entire line repeatedly as enclosed.

  voff=5*pipsize DRAWTEXT("1.618", barindex,r11+voff, Dialog , Bold, 10) COLOURED(255,255,0)

  1 2	voff=5*pipsize DRAWTEXT("1.618", barindex,r11+voff, Dialog , Bold, 10) COLOURED(255,255,0)

   

   

  

  parthapersonal

  Participant

  Topics: 10

  Replies: 71

  Been thanked: 3 times
  05/28/2020 at 7:56 AM #133549
  Vonasi

  If you ask it to draw at the close of every bar then that is what it will do!

  Try enclosing the DRAWTEXT in an IF THEN so that it only draws when the value changes:

  if r11 <> r11[1] then voff=5*pipsize DRAWTEXT(“1.618”, barindex,r11+voff, Dialog , Bold, 10) COLOURED(255,255,0) endif

  1 2 3 4

  if r11 <> r11[1] then voff=5*pipsize DRAWTEXT(“1.618”, barindex,r11+voff, Dialog , Bold, 10) COLOURED(255,255,0) endif

  Note: Always use the ‘Insert PRT Code’ button when putting code in your posts – even if it is only a couple of lines of code as it makes it far easier for others to read. We like a tidy forum. I have edited your post.

   

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  05/29/2020 at 3:47 AM #133694
  parthapersonal

  Thank you Vonasi, however for some strange reason, the enclosed code is not printing the text.

  Can you throw some light to it please?

  Regards

  Fibonacci Support/ Resistance

  D=DayOfWeek if (D=2 or D=3 or D=4 or D=5) then H1=DHigh(1) elsif (D=1) then H1=DHigh(1) endif if (D=2 or D=3 or D=4 or D=5) then L1=DLow(1) elsif (D=1) then L1=DLow(1) endif if (D=2 or D=3 or D=4 or D=5) then C1=DClose(1) elsif D=1 then C1=DClose(2) endif if (D=2 or D=3 or D=4 or D=5) then O=DOpen(0) elsif D=1 then O=DOpen(1) endif r=h1-l1 R236=L1+R*0.236 R382=L1+R*0.382 R50=L1+R*0.5 r6=l1+r*0.618 r7=l1+r*.786 r1=l1+r*1.272 r11=l1+r*1.618 R22=L1+R*2 R2618=L1+R*2.618 R33=L1+R*3.33 DH=H1-r*1 DL=H1-r*0 Lr1=H1-r*1.272 L11=H1-r*1.618 L22=H1-R*2 L2618=H1-R*2.618 L33=H1-R*3.33 WPH=(H1+L1+C1)*2/3-H1 WPL=(H1+L1+C1)*2/3-L1 P=H1+L1+C1 if O>C1 then X=(P+H1)/2 elsif O<C1 then X=(P+L1)/2 elsif O=C1 then X=(P+C1)/2 endif DPH=X-L1 DPL=X-H1 IF R11<>R11[1] THEN voff=5*pipsize DRAWTEXT("1.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R236<>R236[1] THEN voff=5*pipsize DRAWTEXT("0.236", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R382<>R382[1] THEN voff=5*pipsize DRAWTEXT("0.382", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R50<>R50[1] THEN voff=5*pipsize DRAWTEXT("0.5", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R6<>R6[1] THEN voff=5*pipsize DRAWTEXT("0.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R7<>R7[1] THEN voff=5*pipsize DRAWTEXT("0.786", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R1<>R1[1] THEN voff=5*pipsize DRAWTEXT("1.272", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R22<>R22[1] THEN voff=5*pipsize DRAWTEXT("2.0", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R2618<>R2618[1] THEN voff=5*pipsize DRAWTEXT("2.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R33<>R33[1] THEN voff=5*pipsize DRAWTEXT("3.33", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF DH<>DH[1] THEN voff=5*pipsize DRAWTEXT("DH", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF DL<>DL[1] THEN voff=5*pipsize DRAWTEXT("DL", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF LR1<>LR1[1] THEN voff=5*pipsize DRAWTEXT(" - 1.272", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L11<>L11[1] THEN voff=5*pipsize DRAWTEXT(" - 1.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L22<>L22[1] THEN voff=5*pipsize DRAWTEXT(" - 2.0", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L2618<>L2618[1] THEN voff=5*pipsize DRAWTEXT(" - 2.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L33<>L33[1] THEN voff=5*pipsize DRAWTEXT(" - 3.33", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF DPH<>DPH[1] THEN voff=5*pipsize DRAWTEXT("DPRH", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF DPL<>DPL[1] THEN voff=5*pipsize DRAWTEXT("DPRL", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF WPH<>WPH[1] THEN voff=5*pipsize DRAWTEXT("WPRH", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF WPL<>WPL[1] THEN voff=5*pipsize DRAWTEXT("WPRL", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF RETURN WPH AS "WPRH", DPH AS "DPRH", WPL AS "WPRL", DPL AS "DPRL", R236 AS "0.236", R382 AS "0.382", R50 AS "0.5", r6 as "0.618", r7 as "0.786", r1 as "1.272", r11 as "1.618", R22 AS "2", R2618 AS "2.618", R33 AS "3.33", LR1 AS "-1.272", L11 AS "-1.618", L22 AS "-2", L2618 AS "-2.618", L33 AS "-3.33", DH AS "DL", DL AS "DH"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125

  D=DayOfWeek if (D=2 or D=3 or D=4 or D=5) then H1=DHigh(1) elsif (D=1) then H1=DHigh(1) endif if (D=2 or D=3 or D=4 or D=5) then L1=DLow(1) elsif (D=1) then L1=DLow(1) endif if (D=2 or D=3 or D=4 or D=5) then C1=DClose(1) elsif D=1 then C1=DClose(2) endif if (D=2 or D=3 or D=4 or D=5) then O=DOpen(0) elsif D=1 then O=DOpen(1) endif r=h1-l1 R236=L1+R*0.236 R382=L1+R*0.382 R50=L1+R*0.5 r6=l1+r*0.618 r7=l1+r*.786 r1=l1+r*1.272 r11=l1+r*1.618 R22=L1+R*2 R2618=L1+R*2.618 R33=L1+R*3.33 DH=H1-r*1 DL=H1-r*0 Lr1=H1-r*1.272 L11=H1-r*1.618 L22=H1-R*2 L2618=H1-R*2.618 L33=H1-R*3.33 WPH=(H1+L1+C1)*2/3-H1 WPL=(H1+L1+C1)*2/3-L1 P=H1+L1+C1 if O>C1 then X=(P+H1)/2 elsif O<C1 then X=(P+L1)/2 elsif O=C1 then X=(P+C1)/2 endif DPH=X-L1 DPL=X-H1 IF R11<>R11[1] THEN voff=5*pipsize DRAWTEXT("1.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R236<>R236[1] THEN voff=5*pipsize DRAWTEXT("0.236", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R382<>R382[1] THEN voff=5*pipsize DRAWTEXT("0.382", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R50<>R50[1] THEN voff=5*pipsize DRAWTEXT("0.5", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R6<>R6[1] THEN voff=5*pipsize DRAWTEXT("0.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R7<>R7[1] THEN voff=5*pipsize DRAWTEXT("0.786", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R1<>R1[1] THEN voff=5*pipsize DRAWTEXT("1.272", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R22<>R22[1] THEN voff=5*pipsize DRAWTEXT("2.0", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R2618<>R2618[1] THEN voff=5*pipsize DRAWTEXT("2.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF R33<>R33[1] THEN voff=5*pipsize DRAWTEXT("3.33", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF DH<>DH[1] THEN voff=5*pipsize DRAWTEXT("DH", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ELSIF DL<>DL[1] THEN voff=5*pipsize DRAWTEXT("DL", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF LR1<>LR1[1] THEN voff=5*pipsize DRAWTEXT(" - 1.272", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L11<>L11[1] THEN voff=5*pipsize DRAWTEXT(" - 1.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L22<>L22[1] THEN voff=5*pipsize DRAWTEXT(" - 2.0", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L2618<>L2618[1] THEN voff=5*pipsize DRAWTEXT(" - 2.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L33<>L33[1] THEN voff=5*pipsize DRAWTEXT(" - 3.33", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF DPH<>DPH[1] THEN voff=5*pipsize DRAWTEXT("DPRH", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF DPL<>DPL[1] THEN voff=5*pipsize DRAWTEXT("DPRL", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF WPH<>WPH[1] THEN voff=5*pipsize DRAWTEXT("WPRH", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF WPL<>WPL[1] THEN voff=5*pipsize DRAWTEXT("WPRL", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF RETURN WPH AS "WPRH", DPH AS "DPRH", WPL AS "WPRL", DPL AS "DPRL", R236 AS "0.236", R382 AS "0.382", R50 AS "0.5", r6 as "0.618", r7 as "0.786", r1 as "1.272", r11 as "1.618", R22 AS "2", R2618 AS "2.618", R33 AS "3.33", LR1 AS "-1.272", L11 AS "-1.618", L22 AS "-2", L2618 AS "-2.618", L33 AS "-3.33", DH AS "DL", DL AS "DH"

   

  

  parthapersonal

  Participant

  Topics: 10

  Replies: 71

  Been thanked: 3 times
  05/29/2020 at 5:50 AM #133698
  Razz

  Good Morning

  You forgot to change the target according to the bar index has always been r11 for you.

  

  Razz

  Participant

  Topics: 30

  Replies: 158

  Been thanked: 23 times
  05/29/2020 at 5:54 AM #133700
  Razz

  Display Line Code

  D=DayOfWeek if (D=2 or D=3 or D=4 or D=5) then H1=DHigh(1) elsif (D=1) then H1=DHigh(1) endif if (D=2 or D=3 or D=4 or D=5) then L1=DLow(1) elsif (D=1) then L1=DLow(1) endif if (D=2 or D=3 or D=4 or D=5) then C1=DClose(1) elsif D=1 then C1=DClose(2) endif if (D=2 or D=3 or D=4 or D=5) then O=DOpen(0) elsif D=1 then O=DOpen(1) endif r=h1-l1 R236=L1+R*0.236 R382=L1+R*0.382 R50=L1+R*0.5 r6=l1+r*0.618 r7=l1+r*.786 r1=l1+r*1.272 r11=l1+r*1.618 R22=L1+R*2 R2618=L1+R*2.618 R33=L1+R*3.33 DH=H1-r*1 DL=H1-r*0 Lr1=H1-r*1.272 L11=H1-r*1.618 L22=H1-R*2 L2618=H1-R*2.618 L33=H1-R*3.33 WPH=(H1+L1+C1)*2/3-H1 WPL=(H1+L1+C1)*2/3-L1 P=H1+L1+C1 if O>C1 then X=(P+H1)/2 elsif O<C1 then X=(P+L1)/2 elsif O=C1 then X=(P+C1)/2 endif DPH=X-L1 DPL=X-H1 IF R11<>R11[1] THEN voff=5*pipsize DRAWTEXT("1.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R236<>R236[1] THEN voff=5*pipsize DRAWTEXT("0.236", barindex,r236+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R382<>R382[1] THEN voff=5*pipsize DRAWTEXT("0.382", barindex,r382+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R50<>R50[1] THEN voff=5*pipsize DRAWTEXT("0.5", barindex,r50+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R6<>R6[1] THEN voff=5*pipsize DRAWTEXT("0.618", barindex,r6+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif IF R7<>R7[1] THEN voff=5*pipsize DRAWTEXT("0.786", barindex,r7+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R1<>R1[1] THEN voff=5*pipsize DRAWTEXT("1.272", barindex,r1+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R22<>R22[1] THEN voff=5*pipsize DRAWTEXT("2.0", barindex,r22+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R2618<>R2618[1] THEN voff=5*pipsize DRAWTEXT("2.618", barindex,r2618+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R33<>R33[1] THEN voff=5*pipsize DRAWTEXT("3.33", barindex,r33+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If DH<>DH[1] THEN voff=5*pipsize DRAWTEXT("DH", barindex,DH+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If DL<>DL[1] THEN voff=5*pipsize DRAWTEXT("DL", barindex,DL+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF LR1<>LR1[1] THEN voff=5*pipsize DRAWTEXT(" - 1.272", barindex,LR1+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L11<>L11[1] THEN voff=5*pipsize DRAWTEXT(" - 1.618", barindex,L11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L22<>L22[1] THEN voff=5*pipsize DRAWTEXT(" - 2.0", barindex,L22+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L2618<>L2618[1] THEN voff=5*pipsize DRAWTEXT(" - 2.618", barindex,L2618+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L33<>L33[1] THEN voff=5*pipsize DRAWTEXT(" - 3.33", barindex,L33+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF DPH<>DPH[1] THEN voff=5*pipsize DRAWTEXT("DPRH", barindex,DPH+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF DPL<>DPL[1] THEN voff=5*pipsize DRAWTEXT("DPRL", barindex,DPL+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF WPH<>WPH[1] THEN voff=5*pipsize DRAWTEXT("WPRH", barindex,WPH+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF WPL<>WPL[1] THEN voff=5*pipsize DRAWTEXT("WPRL", barindex,WPL+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF RETURN WPH AS "WPRH", DPH AS "DPRH", WPL AS "WPRL", DPL AS "DPRL", R236 AS "0.236", R382 AS "0.382", R50 AS "0.5", r6 as "0.618", r7 as "0.786", r1 as "1.272", r11 as "1.618", R22 AS "2", R2618 AS "2.618", R33 AS "3.33", LR1 AS "-1.272", L11 AS "-1.618", L22 AS "-2", L2618 AS "-2.618", L33 AS "-3.33", DH AS "DL", DL AS "DH"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136

  D=DayOfWeek if (D=2 or D=3 or D=4 or D=5) then H1=DHigh(1) elsif (D=1) then H1=DHigh(1) endif if (D=2 or D=3 or D=4 or D=5) then L1=DLow(1) elsif (D=1) then L1=DLow(1) endif if (D=2 or D=3 or D=4 or D=5) then C1=DClose(1) elsif D=1 then C1=DClose(2) endif if (D=2 or D=3 or D=4 or D=5) then O=DOpen(0) elsif D=1 then O=DOpen(1) endif r=h1-l1 R236=L1+R*0.236 R382=L1+R*0.382 R50=L1+R*0.5 r6=l1+r*0.618 r7=l1+r*.786 r1=l1+r*1.272 r11=l1+r*1.618 R22=L1+R*2 R2618=L1+R*2.618 R33=L1+R*3.33 DH=H1-r*1 DL=H1-r*0 Lr1=H1-r*1.272 L11=H1-r*1.618 L22=H1-R*2 L2618=H1-R*2.618 L33=H1-R*3.33 WPH=(H1+L1+C1)*2/3-H1 WPL=(H1+L1+C1)*2/3-L1 P=H1+L1+C1 if O>C1 then X=(P+H1)/2 elsif O<C1 then X=(P+L1)/2 elsif O=C1 then X=(P+C1)/2 endif DPH=X-L1 DPL=X-H1 IF R11<>R11[1] THEN voff=5*pipsize DRAWTEXT("1.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R236<>R236[1] THEN voff=5*pipsize DRAWTEXT("0.236", barindex,r236+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R382<>R382[1] THEN voff=5*pipsize DRAWTEXT("0.382", barindex,r382+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R50<>R50[1] THEN voff=5*pipsize DRAWTEXT("0.5", barindex,r50+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R6<>R6[1] THEN voff=5*pipsize DRAWTEXT("0.618", barindex,r6+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif IF R7<>R7[1] THEN voff=5*pipsize DRAWTEXT("0.786", barindex,r7+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R1<>R1[1] THEN voff=5*pipsize DRAWTEXT("1.272", barindex,r1+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R22<>R22[1] THEN voff=5*pipsize DRAWTEXT("2.0", barindex,r22+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R2618<>R2618[1] THEN voff=5*pipsize DRAWTEXT("2.618", barindex,r2618+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If R33<>R33[1] THEN voff=5*pipsize DRAWTEXT("3.33", barindex,r33+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If DH<>DH[1] THEN voff=5*pipsize DRAWTEXT("DH", barindex,DH+voff, Dialog , Bold, 18) COLOURED(255,255,0) endif If DL<>DL[1] THEN voff=5*pipsize DRAWTEXT("DL", barindex,DL+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF LR1<>LR1[1] THEN voff=5*pipsize DRAWTEXT(" - 1.272", barindex,LR1+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L11<>L11[1] THEN voff=5*pipsize DRAWTEXT(" - 1.618", barindex,L11+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L22<>L22[1] THEN voff=5*pipsize DRAWTEXT(" - 2.0", barindex,L22+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L2618<>L2618[1] THEN voff=5*pipsize DRAWTEXT(" - 2.618", barindex,L2618+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF L33<>L33[1] THEN voff=5*pipsize DRAWTEXT(" - 3.33", barindex,L33+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF DPH<>DPH[1] THEN voff=5*pipsize DRAWTEXT("DPRH", barindex,DPH+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF DPL<>DPL[1] THEN voff=5*pipsize DRAWTEXT("DPRL", barindex,DPL+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF WPH<>WPH[1] THEN voff=5*pipsize DRAWTEXT("WPRH", barindex,WPH+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF IF WPL<>WPL[1] THEN voff=5*pipsize DRAWTEXT("WPRL", barindex,WPL+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF RETURN WPH AS "WPRH", DPH AS "DPRH", WPL AS "WPRL", DPL AS "DPRL", R236 AS "0.236", R382 AS "0.382", R50 AS "0.5", r6 as "0.618", r7 as "0.786", r1 as "1.272", r11 as "1.618", R22 AS "2", R2618 AS "2.618", R33 AS "3.33", LR1 AS "-1.272", L11 AS "-1.618", L22 AS "-2", L2618 AS "-2.618", L33 AS "-3.33", DH AS "DL", DL AS "DH"

   

  

  Razz

  Participant

  Topics: 30

  Replies: 158

  Been thanked: 23 times
  05/29/2020 at 7:12 AM #133708
  Vonasi

  Apart from the text drawing y value that Razz corrected and the ELSIFs that should have been ENDIFs there is an awful lot of code that is not needs that really slows down the calculation time. Plus you only need to do the calculations once when the day changes.

  Here is the code tidied up:

  D=openDayOfWeek if d <> d[1] then if (D=2 or D=3 or D=4 or D=5) then H1=DHigh(1) L1=DLow(1) C1=DClose(1) O=DOpen(0) elsif (D=1) then H1=DHigh(1) L1=DLow(1) C1=DClose(2) O=DOpen(1) endif r=h1-l1 R236=L1+R*0.236 R382=L1+R*0.382 R50=L1+R*0.5 r6=l1+r*0.618 r7=l1+r*.786 r1=l1+r*1.272 r11=l1+r*1.618 R22=L1+R*2 R2618=L1+R*2.618 R33=L1+R*3.33 DH=H1-r*1 DL=H1-r*0 Lr1=H1-r*1.272 L11=H1-r*1.618 L22=H1-R*2 L2618=H1-R*2.618 L33=H1-R*3.33 WPH=(H1+L1+C1)*2/3-H1 WPL=(H1+L1+C1)*2/3-L1 P=H1+L1+C1 if O>C1 then X=(P+H1)/2 elsif O<C1 then X=(P+L1)/2 elsif O=C1 then X=(P+C1)/2 endif DPH=X-L1 DPL=X-H1 voff=5*pipsize DRAWTEXT("1.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.236", barindex,r236+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.382", barindex,r382+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.5", barindex,r50+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.618", barindex,r6+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.786", barindex,r7+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("1.272", barindex,r1+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("2.0", barindex,r22+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("2.618", barindex,r2618+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("3.33", barindex,r33+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DH", barindex,DH+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DL", barindex,DL+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 1.272", barindex,LR1+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 1.618", barindex,L11+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 2.0", barindex,L22+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 2.618", barindex,L2618+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 3.33", barindex,L33+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DPRH", barindex,DPH+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DPRL", barindex,DPL+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("WPRH", barindex,WPH+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("WPRL", barindex,WPL+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF RETURN WPH AS "WPRH", DPH AS "DPRH", WPL AS "WPRL", DPL AS "DPRL", R236 AS "0.236", R382 AS "0.382", R50 AS "0.5", r6 as "0.618", r7 as "0.786", r1 as "1.272", r11 as "1.618", R22 AS "2", R2618 AS "2.618", R33 AS "3.33", LR1 AS "-1.272", L11 AS "-1.618", L22 AS "-2", L2618 AS "-2.618", L33 AS "-3.33", DH AS "DL", DL AS "DH"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72

  D=openDayOfWeek   if d <> d[1] then if (D=2 or D=3 or D=4 or D=5) then H1=DHigh(1) L1=DLow(1) C1=DClose(1) O=DOpen(0) elsif (D=1) then H1=DHigh(1) L1=DLow(1) C1=DClose(2) O=DOpen(1) endif   r=h1-l1 R236=L1+R*0.236 R382=L1+R*0.382 R50=L1+R*0.5 r6=l1+r*0.618 r7=l1+r*.786 r1=l1+r*1.272 r11=l1+r*1.618 R22=L1+R*2 R2618=L1+R*2.618 R33=L1+R*3.33 DH=H1-r*1 DL=H1-r*0 Lr1=H1-r*1.272 L11=H1-r*1.618 L22=H1-R*2 L2618=H1-R*2.618 L33=H1-R*3.33 WPH=(H1+L1+C1)*2/3-H1 WPL=(H1+L1+C1)*2/3-L1 P=H1+L1+C1   if O>C1 then X=(P+H1)/2 elsif O<C1 then X=(P+L1)/2 elsif O=C1 then X=(P+C1)/2 endif DPH=X-L1 DPL=X-H1   voff=5*pipsize DRAWTEXT("1.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.236", barindex,r236+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.382", barindex,r382+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.5", barindex,r50+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.618", barindex,r6+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.786", barindex,r7+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("1.272", barindex,r1+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("2.0", barindex,r22+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("2.618", barindex,r2618+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("3.33", barindex,r33+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DH", barindex,DH+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DL", barindex,DL+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 1.272", barindex,LR1+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 1.618", barindex,L11+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 2.0", barindex,L22+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 2.618", barindex,L2618+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 3.33", barindex,L33+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DPRH", barindex,DPH+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DPRL", barindex,DPL+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("WPRH", barindex,WPH+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("WPRL", barindex,WPL+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF   RETURN WPH AS "WPRH", DPH AS "DPRH", WPL AS "WPRL", DPL AS "DPRL", R236 AS "0.236", R382 AS "0.382", R50 AS "0.5", r6 as "0.618", r7 as "0.786", r1 as "1.272", r11 as "1.618", R22 AS "2", R2618 AS "2.618", R33 AS "3.33", LR1 AS "-1.272", L11 AS "-1.618", L22 AS "-2", L2618 AS "-2.618", L33 AS "-3.33", DH AS "DL", DL AS "DH"

   

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  05/29/2020 at 7:26 AM #133711
  Vonasi

  Also I’m not sure what you are trying to achieve with the first bit of code that sets the O H L C values. If it is to include Sunday data in with Monday data then you need to do it like this:

  D=openDayOfWeek if d <> d[1] then if (D=2 or D=3 or D=4 or D=5) then H1=DHigh(1) L1=DLow(1) C1=DClose(1) O=DOpen(1) elsif (D=1) then H1=max(DHigh(1),dHigh(2)) L1=min(DLow(1),dLow(2)) C1=DClose(1) O=DOpen(2) endif r=h1-l1 R236=L1+R*0.236 R382=L1+R*0.382 R50=L1+R*0.5 r6=l1+r*0.618 r7=l1+r*.786 r1=l1+r*1.272 r11=l1+r*1.618 R22=L1+R*2 R2618=L1+R*2.618 R33=L1+R*3.33 DH=H1-r*1 DL=H1-r*0 Lr1=H1-r*1.272 L11=H1-r*1.618 L22=H1-R*2 L2618=H1-R*2.618 L33=H1-R*3.33 WPH=(H1+L1+C1)*2/3-H1 WPL=(H1+L1+C1)*2/3-L1 P=H1+L1+C1 if O>C1 then X=(P+H1)/2 elsif O<C1 then X=(P+L1)/2 elsif O=C1 then X=(P+C1)/2 endif DPH=X-L1 DPL=X-H1 voff=5*pipsize DRAWTEXT("1.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.236", barindex,r236+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.382", barindex,r382+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.5", barindex,r50+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.618", barindex,r6+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.786", barindex,r7+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("1.272", barindex,r1+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("2.0", barindex,r22+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("2.618", barindex,r2618+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("3.33", barindex,r33+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DH", barindex,DH+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DL", barindex,DL+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 1.272", barindex,LR1+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 1.618", barindex,L11+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 2.0", barindex,L22+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 2.618", barindex,L2618+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 3.33", barindex,L33+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DPRH", barindex,DPH+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DPRL", barindex,DPL+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("WPRH", barindex,WPH+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("WPRL", barindex,WPL+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF RETURN WPH AS "WPRH", DPH AS "DPRH", WPL AS "WPRL", DPL AS "DPRL", R236 AS "0.236", R382 AS "0.382", R50 AS "0.5", r6 as "0.618", r7 as "0.786", r1 as "1.272", r11 as "1.618", R22 AS "2", R2618 AS "2.618", R33 AS "3.33", LR1 AS "-1.272", L11 AS "-1.618", L22 AS "-2", L2618 AS "-2.618", L33 AS "-3.33", DH AS "DL", DL AS "DH"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72

  D=openDayOfWeek   if d <> d[1] then if (D=2 or D=3 or D=4 or D=5) then H1=DHigh(1) L1=DLow(1) C1=DClose(1) O=DOpen(1) elsif (D=1) then H1=max(DHigh(1),dHigh(2)) L1=min(DLow(1),dLow(2)) C1=DClose(1) O=DOpen(2) endif   r=h1-l1 R236=L1+R*0.236 R382=L1+R*0.382 R50=L1+R*0.5 r6=l1+r*0.618 r7=l1+r*.786 r1=l1+r*1.272 r11=l1+r*1.618 R22=L1+R*2 R2618=L1+R*2.618 R33=L1+R*3.33 DH=H1-r*1 DL=H1-r*0 Lr1=H1-r*1.272 L11=H1-r*1.618 L22=H1-R*2 L2618=H1-R*2.618 L33=H1-R*3.33 WPH=(H1+L1+C1)*2/3-H1 WPL=(H1+L1+C1)*2/3-L1 P=H1+L1+C1   if O>C1 then X=(P+H1)/2 elsif O<C1 then X=(P+L1)/2 elsif O=C1 then X=(P+C1)/2 endif DPH=X-L1 DPL=X-H1   voff=5*pipsize DRAWTEXT("1.618", barindex,r11+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.236", barindex,r236+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.382", barindex,r382+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.5", barindex,r50+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.618", barindex,r6+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("0.786", barindex,r7+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("1.272", barindex,r1+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("2.0", barindex,r22+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("2.618", barindex,r2618+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("3.33", barindex,r33+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DH", barindex,DH+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DL", barindex,DL+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 1.272", barindex,LR1+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 1.618", barindex,L11+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 2.0", barindex,L22+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 2.618", barindex,L2618+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT(" - 3.33", barindex,L33+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DPRH", barindex,DPH+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("DPRL", barindex,DPL+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("WPRH", barindex,WPH+voff, Dialog , Bold, 18) COLOURED(255,255,0) DRAWTEXT("WPRL", barindex,WPL+voff, Dialog , Bold, 18) COLOURED(255,255,0) ENDIF   RETURN WPH AS "WPRH", DPH AS "DPRH", WPL AS "WPRL", DPL AS "DPRL", R236 AS "0.236", R382 AS "0.382", R50 AS "0.5", r6 as "0.618", r7 as "0.786", r1 as "1.272", r11 as "1.618", R22 AS "2", R2618 AS "2.618", R33 AS "3.33", LR1 AS "-1.272", L11 AS "-1.618", L22 AS "-2", L2618 AS "-2.618", L33 AS "-3.33", DH AS "DL", DL AS "DH"

   

  1 user thanked author for this post.

  Razz

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  05/29/2020 at 7:28 AM #133712
  parthapersonal

  Many thanks to both of you dear.

  Vonasi you are a Legend. Special thanks to you.

  1 user thanked author for this post.

  Razz

  

  parthapersonal

  Participant

  Topics: 10

  Replies: 71

  Been thanked: 3 times
  05/29/2020 at 8:52 AM #133734
  Razz

  @ Vonasi

  what should the code OHLC  be if you want to work with the values from Friday on Mondays?

  thank you

  

  Razz

  Participant

  Topics: 30

  Replies: 158

  Been thanked: 23 times
  05/29/2020 at 9:27 AM #133743
  Vonasi

  Yes – looking at it after another coffee even my code is not quite right!

  Change the OHLC code to the following and on Sundays and Mondays it bases the calculations on Fridays data and on Tuesdays it bases the calculations on Sunday and Monday’s data:

  if d <> d[1] then if (D=0 or D=3 or D=4 or D=5) then H1=DHigh(1) L1=DLow(1) C1=DClose(1) O=DOpen(1) elsif (D=2) then H1=max(DHigh(1),dHigh(2)) L1=min(DLow(1),dLow(2)) C1=DClose(1) O=DOpen(2) endif

  1 2 3 4 5 6 7 8 9 10 11 12

  if d <> d[1] then if (D=0 or D=3 or D=4 or D=5) then H1=DHigh(1) L1=DLow(1) C1=DClose(1) O=DOpen(1) elsif (D=2) then H1=max(DHigh(1),dHigh(2)) L1=min(DLow(1),dLow(2)) C1=DClose(1) O=DOpen(2) endif

   

  1 user thanked author for this post.

  Razz

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  05/29/2020 at 9:39 AM #133744
  Razz

  Thanks for the quick implementation I am curious to see if it works on Monday.

  

  Razz

  Participant

  Topics: 30

  Replies: 158

  Been thanked: 23 times
  06/01/2020 at 7:48 AM #134010
  parthapersonal

  Many thanks again to the legends!!

  It seems the previous code is returning better results and new code is returning wrong levels as captured in the enclosed doc.

  What say?

   

  

  parthapersonal

  Participant

  Topics: 10

  Replies: 71

  Been thanked: 3 times
  06/01/2020 at 8:46 AM #134017
  robertogozzi

  @parthapersonal

  please use image file formats (jpg, png) when attaching pics and PDF or TXT file formats when attaching text.

  Thank you 🙂

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17275

  Been thanked: 4124 times
  06/02/2020 at 8:12 AM #134147
  parthapersonal

  What should be the format if it is a combination of text and image? I presume it would be pdf, correct?

  

  parthapersonal

  Participant

  Topics: 10

  Replies: 71

  Been thanked: 3 times
• Author
  Posts