Help with coding average price based on pivots and moving averages

• 08/09/2018 at 9:51 PM #77903
  skfomx

  Hi there!

  I am a newbie trying to create an indicator that produces an average daily price by combining daily, weekly, and monthly pivots and simple moving average 5, 20,50,100,200. I want to give more weight to the pivot points compared to the moving averages so I duplicate the pivot point numbers before dividing all of them.

  Pro realtime does not like the indicator. It works on some instruments but not on others. For example it works on aud/cad but not on eur/usd.

  Calculation error: “A positive integer field is expected with highest”

  Can anyone help? It would be much appreciated!

  

  skfomx

  Participant

  Topics: 3

  Replies: 10

  Been thanked: 0 times
  08/09/2018 at 9:52 PM #77904
  skfomx

  This is the code:

  //Pivot calculation method Once mode = 1 Once dailyPivot = 1 Once lastWeekBarIndex = 1 Once weeklyHigh = undefined Once weeklyLow = undefined Once weeklyPivot = undefined Once lastMonthBarIndex = 0 Once monthlyHigh = undefined Once monthlyLow = undefined Once monthlyPivot = undefined If Day>Day[1] then If mode = 1 then dailyPivot = (DHigh(1) + DLow(1) + Close[1]) / 3 Elsif mode = 1 then dailyPivot = (Open + DHigh(1) + DLow(1) + Close[1]) / 4 Elsif mode = 2 then dailyPivot = (DHigh(1) + DLow(1) + Close[1]*2) / 4 Else dailyPivot = (Open*2 + DHigh(1) + DLow(1)) / 4 Endif Endif If DayOfWeek<DayOfWeek[1] then weeklyHigh = Highest[BarIndex – lastWeekBarIndex](High)[1] weeklyLow = Lowest[BarIndex – lastWeekBarIndex](Low)[1] lastWeekBarIndex = BarIndex If mode = 1 then weeklyPivot = (weeklyHigh + weeklyLow + Close[1]) / 3 Elsif mode = 1 then weeklyPivot = (Open + weeklyHigh + weeklyLow + Close[1]) / 4 Elsif mode = 2 then weeklyPivot = (weeklyHigh + weeklyLow + Close[1]*2) / 4 Else weeklyPivot = (Open*2 + weeklyHigh + weeklyLow) / 4 Endif Endif If Month<>Month[1] then monthlyHigh = Highest[BarIndex – lastMonthBarIndex](High)[1] monthlyLow = Lowest[BarIndex – lastMonthBarIndex](Low)[1] lastMonthBarIndex = BarIndex If mode = 1 then monthlyPivot = (monthlyHigh + monthlyLow + Close[1]) / 3 Elsif mode = 1 then monthlyPivot = (Open + monthlyHigh + monthlyLow + Close[1]) / 4 Elsif mode = 2 then monthlyPivot = (monthlyHigh + monthlyLow + Close[1]*2) / 4 Else monthlyPivot = (Open*2 + monthlyHigh + monthlyLow) / 4 Endif Endif c1= (DailyPivot *2 + weeklyPivot *2 + monthlyPivot *2 + average [5] + average [20] + average [50] + average [100] + average [200]) / 11 Return c1

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65

  //Pivot calculation method Once mode = 1   Once dailyPivot = 1   Once lastWeekBarIndex = 1 Once weeklyHigh = undefined Once weeklyLow = undefined Once weeklyPivot = undefined   Once lastMonthBarIndex = 0 Once monthlyHigh = undefined Once monthlyLow = undefined Once monthlyPivot = undefined   If Day>Day[1] then If mode = 1 then dailyPivot = (DHigh(1) + DLow(1) + Close[1]) / 3 Elsif mode = 1 then dailyPivot = (Open + DHigh(1) + DLow(1) + Close[1]) / 4 Elsif mode = 2 then dailyPivot = (DHigh(1) + DLow(1) + Close[1]*2) / 4 Else dailyPivot = (Open*2 + DHigh(1) + DLow(1)) / 4 Endif   Endif   If DayOfWeek<DayOfWeek[1] then weeklyHigh = Highest[BarIndex – lastWeekBarIndex](High)[1] weeklyLow = Lowest[BarIndex – lastWeekBarIndex](Low)[1] lastWeekBarIndex = BarIndex   If mode = 1 then weeklyPivot = (weeklyHigh + weeklyLow + Close[1]) / 3 Elsif mode = 1 then weeklyPivot = (Open + weeklyHigh + weeklyLow + Close[1]) / 4 Elsif mode = 2 then weeklyPivot = (weeklyHigh + weeklyLow + Close[1]*2) / 4 Else weeklyPivot = (Open*2 + weeklyHigh + weeklyLow) / 4 Endif   Endif   If Month<>Month[1] then monthlyHigh = Highest[BarIndex – lastMonthBarIndex](High)[1] monthlyLow = Lowest[BarIndex – lastMonthBarIndex](Low)[1] lastMonthBarIndex = BarIndex   If mode = 1 then monthlyPivot = (monthlyHigh + monthlyLow + Close[1]) / 3 Elsif mode = 1 then monthlyPivot = (Open + monthlyHigh + monthlyLow + Close[1]) / 4 Elsif mode = 2 then monthlyPivot = (monthlyHigh + monthlyLow + Close[1]*2) / 4 Else monthlyPivot = (Open*2 + monthlyHigh + monthlyLow) / 4 Endif   Endif   c1= (DailyPivot *2 + weeklyPivot *2 + monthlyPivot *2 + average [5] + average [20] + average [50] + average [100] + average [200]) / 11   Return c1

   

   

  

  skfomx

  Participant

  Topics: 3

  Replies: 10

  Been thanked: 0 times
  08/09/2018 at 9:58 PM #77905
  robertogozzi

  To write code, please use the <> “insert PRT code” button, to make code easier to read and understand. Thank you.

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17151

  Been thanked: 4040 times
  08/09/2018 at 10:09 PM #77906
  robertogozzi

  It’s because in line 6 you set

  Once lastWeekBarIndex = 1

  1	Once lastWeekBarIndex = 1

  so in line 30 the expression

  Highest[BarIndex – lastWeekBarIndex]

  1	Highest[BarIndex – lastWeekBarIndex]

  the first time will evaluate to

  Highest[0]

  1	Highest[0]

  which is not allowed.

   

   

   

   

  1 user thanked author for this post.

  skfomx

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17151

  Been thanked: 4040 times
  08/10/2018 at 8:30 AM #77930
  Nicolas

  Roberto is right, because the first barindex is 1 and obviously 1 minus 1 = 0.

  You can modify your line 30 with: 

  Highest[max(1,BarIndex – lastWeekBarIndex)]

  1	Highest[max(1,BarIndex – lastWeekBarIndex)]

  Do the same for lines 31, 47 and 48.

  2 users thanked author for this post.

  skfomx, robertogozzi

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  08/10/2018 at 10:35 PM #77991
  skfomx

  Thanks a lot for taking the time to help out!

  

  skfomx

  Participant

  Topics: 3

  Replies: 10

  Been thanked: 0 times
  09/01/2018 at 5:12 PM #79527
  skfomx

  This is what the code looks like now

  //Pivot calculation method Once mode = 1 Once dailyPivot = 1 Once lastWeekBarIndex = 1 Once weeklyHigh = undefined Once weeklyLow = undefined Once weeklyPivot = undefined Once lastMonthBarIndex = 1 Once monthlyHigh = undefined Once monthlyLow = undefined Once monthlyPivot = undefined If Day>Day[1] then If mode = 1 then dailyPivot = (DHigh(1) + DLow(1) + Close[1]) / 3 Elsif mode = 1 then dailyPivot = (Open + DHigh(1) + DLow(1) + Close[1]) / 4 Elsif mode = 2 then dailyPivot = (DHigh(1) + DLow(1) + Close[1]*2) / 4 Else dailyPivot = (Open*2 + DHigh(1) + DLow(1)) / 4 Endif Endif If DayOfWeek<DayOfWeek[1] then weeklyHigh = Highest[max(1,BarIndex - lastWeekBarIndex)](High)[1] weeklyLow = Lowest[max(1,BarIndex - lastWeekBarIndex)](Low)[1] lastWeekBarIndex = BarIndex If mode = 1 then weeklyPivot = (weeklyHigh + weeklyLow + Close[1]) / 3 Elsif mode = 1 then weeklyPivot = (Open + weeklyHigh + weeklyLow + Close[1]) / 4 Elsif mode = 2 then weeklyPivot = (weeklyHigh + weeklyLow + Close[1]*2) / 4 Else weeklyPivot = (Open*2 + weeklyHigh + weeklyLow) / 4 Endif Endif If Month<>Month[1] then monthlyHigh = Highest[max(1,BarIndex - lastMonthBarIndex)](High)[1] monthlyLow = Lowest[max(1,BarIndex - lastMonthBarIndex)](Low)[1] lastMonthBarIndex = BarIndex If mode = 1 then monthlyPivot = (monthlyHigh + monthlyLow + Close[1]) / 3 Elsif mode = 1 then monthlyPivot = (Open + monthlyHigh + monthlyLow + Close[1]) / 4 Elsif mode = 2 then monthlyPivot = (monthlyHigh + monthlyLow + Close[1]*2) / 4 Else monthlyPivot = (Open*2 + monthlyHigh + monthlyLow) / 4 Endif Endif c1= (DailyPivot *2 + weeklyPivot *2 + monthlyPivot *2 + average [5] + average [20] + average [50] + average [100] + average [200]) / 11 return c1

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73

  //Pivot calculation method Once mode = 1   Once dailyPivot = 1     Once lastWeekBarIndex = 1 Once weeklyHigh = undefined Once weeklyLow = undefined Once weeklyPivot = undefined       Once lastMonthBarIndex = 1 Once monthlyHigh = undefined Once monthlyLow = undefined Once monthlyPivot = undefined       If Day>Day[1] then If mode = 1 then dailyPivot = (DHigh(1) + DLow(1) + Close[1]) / 3 Elsif mode = 1 then dailyPivot = (Open + DHigh(1) + DLow(1) + Close[1]) / 4 Elsif mode = 2 then dailyPivot = (DHigh(1) + DLow(1) + Close[1]*2) / 4 Else dailyPivot = (Open*2 + DHigh(1) + DLow(1)) / 4 Endif     Endif   If DayOfWeek<DayOfWeek[1] then weeklyHigh = Highest[max(1,BarIndex - lastWeekBarIndex)](High)[1] weeklyLow = Lowest[max(1,BarIndex - lastWeekBarIndex)](Low)[1] lastWeekBarIndex = BarIndex   If mode = 1 then weeklyPivot = (weeklyHigh + weeklyLow + Close[1]) / 3 Elsif mode = 1 then weeklyPivot = (Open + weeklyHigh + weeklyLow + Close[1]) / 4 Elsif mode = 2 then weeklyPivot = (weeklyHigh + weeklyLow + Close[1]*2) / 4 Else weeklyPivot = (Open*2 + weeklyHigh + weeklyLow) / 4 Endif     Endif   If Month<>Month[1] then monthlyHigh = Highest[max(1,BarIndex - lastMonthBarIndex)](High)[1] monthlyLow = Lowest[max(1,BarIndex - lastMonthBarIndex)](Low)[1] lastMonthBarIndex = BarIndex   If mode = 1 then monthlyPivot = (monthlyHigh + monthlyLow + Close[1]) / 3 Elsif mode = 1 then monthlyPivot = (Open + monthlyHigh + monthlyLow + Close[1]) / 4 Elsif mode = 2 then monthlyPivot = (monthlyHigh + monthlyLow + Close[1]*2) / 4 Else monthlyPivot = (Open*2 + monthlyHigh + monthlyLow) / 4 Endif   Endif   c1= (DailyPivot *2 + weeklyPivot *2 + monthlyPivot *2 + average [5] + average [20] + average [50] + average [100] + average [200]) / 11     return c1

   

  

  skfomx

  Participant

  Topics: 3

  Replies: 10

  Been thanked: 0 times
  09/01/2018 at 5:25 PM #79528
  skfomx

  I would like to create another version of this indicator for intraday timeframes. I would like to use a 10 minute chart and create the average price by combining moving average 5, 20, 50, 100, 200 and then combine that with hourly pivot, 4 hour pivot and daily pivot points.

  Can anyone guide me in how to achieve this? Thanks again to Roberto Gozzi and Nicolas for helping out with the first version!

  

  skfomx

  Participant

  Topics: 3

  Replies: 10

  Been thanked: 0 times
• Author
  Posts