Help with Higher High, lower low price swing Indicator and Segment drawings

• 08/27/2018 at 10:29 PM #79204
  Moritz Müller

  hi there,

   

  first, i want to thank you all for your inputs and help. Even if i wasn’t a register member yet, you helped me out quite some time. Unfortunately I had to register now, since I can’t figure out a solution to this (easy) issue – might be the time by now or not enough coffee lately.

  I try to come up with an indicator / segment drawing as you can see in the attachment (took the image from ninja trader) with all the segments and captions. Even after checking the forums and the library and even trying to adjust existing things, i just don’t come up with a solution (as i said, might be the time as well).

  Would be amazing if you could help me with links existing solutions i can adjust or with better search terms (yes, i used the search function 🙂 ) or with some parts of the coding. As I said, currently i am dump struck, so I don’t even find the correct entry points to this thing…

  thanks for all your support and have a great week

  best

  Moritz

  

  Moritz Müller

  Participant

  Topics: 3

  Replies: 9

  Been thanked: 1 time
  08/28/2018 at 9:20 AM #79228
  Nicolas

  So, for my perfect understanding, you want the indicator to draw those segments from highest high and lowest low? How are they found? With Fractals? (best and easier solution IMO).

  HL and HH must be consecutive points?

  Fractals ZigZag could be the major part of the solution, looking for consecutive points as patterns could then be done with a loop.

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4774 times
  08/28/2018 at 12:21 PM #79244
  Moritz Müller

  Salut Nicolas,

  thanks for your quick reply.

  Sorry for being not 100% precise. After having some more time to think and some coffee, here is more detail what i wanted to do (and the reason/difference why)

  • yes, should be zig zag
  • starting point in the past to today (number of bars as variable)
  • first bar to identify if high or low compared to the following (simple high high, low low comparison). if not identifiable, take next bar (just for the most unlikely event, that the first bar is engulfed by the second)
  • first bar with single identification (high or low) defines the starting of the zigzag (high > high [1] then high = 1 else high = 0 ; low < low [1] then low = 1)
  • then i was considering a loop to go from the past to the present bars, each identify if it is a High or Low compared to the previous (high > high [1] then high = 1 else high = 0 ; low < low [1] then low = 1)
  • the identifier for a switch from zig to zag would be the change from a Bar with  Low=1 and High = 0 to a High=1 and Low=0 and Vize Verza; in case of engulfing the previous turning point makes the final call
  • as last step, drawing the segments and the trendiness and the captures with higher high, higher low, lower high and lower low; always compared to the previous high or low

  difference to fractals (if i am not completely missing something)

  • line would be drawn real time always on latest bar
  • not pre-defined timeframe for double check

  i hope this makes it clear

   

  thanks

  Moritz

   

  PS: but, yes, fractals are easier even if not with the same accuracy; others would say over engineered

   

   

  

  Moritz Müller

  Participant

  Topics: 3

  Replies: 9

  Been thanked: 1 time
  09/16/2018 at 11:14 PM #80649
  Moritz Müller

  hi there,

  any support on my idea? i got the zig zag but thats it….

  mainly I am currently stuck with an idea how to compare the lows/ highs to previous lows/highs in order to identify higher highs/lower highs and the higher and lower lows – i guess that is a more general question on how to compare results to previous results…

  thanks

  Moritz

  

  Moritz Müller

  Participant

  Topics: 3

  Replies: 9

  Been thanked: 1 time
  09/17/2018 at 10:20 AM #80673
  Nicolas

  This rough code identify HL HH LH LL from zigzag.

  Since the internal instruction of the platform uses only one price value to calculate the zigzag, I used 2 instructions at a time, one to identify the peaks (High) and another one for the troughs (Low). Then, to draw the segments, and as we do it by advancing in the history, to draw a new low, the previous point must be a peak, except that sometimes it is not the case if the price did not go high enough for example to form a peak, so that is why we can see several successive low points (same goes for high points). In this case only the first point is identified.

  To check if a trend is reversed we can start from this first test by checking the last identifications.

  percent = 0.5 zzh = ZigZag[percent](high) zzl = zigzag[percent](low) itop = zzh<zzh[1] and zzh[1]>zzh[2] bot = zzl>zzl[1] and zzl[1]<zzl[2] once lastzz=1 atr = averagetruerange[10] //peaks if itop then //segment if lastzz<0 then drawsegment(barindex[1],zzh[1],prevlbar,prevl) //LH if zzh[1]<prevh then drawtext("LH",barindex[1],zzh[1]+atr/2,dialog,bold,16) else //HH drawtext("HH",barindex[1],zzh[1]+atr/2,dialog,bold,16) endif else drawsegment(barindex[1],zzh[1],prevhbar,prevh) endif lastzz=1 prevhbar=barindex[1] prevh=zzh[1] endif //troughs if bot then //segment if lastzz>0 then drawsegment(barindex[1],zzl[1],prevhbar,prevh) //HL if zzl[1]>prevl then drawtext("HL",barindex[1],zzl[1]-atr/2,dialog,bold,16) else //LL drawtext("LL",barindex[1],zzl[1]-atr/2,dialog,bold,16) endif else drawsegment(barindex[1],zzl[1],prevlbar,prevl) endif lastzz=-1 prevlbar=barindex[1] prevl=zzl[1] endif return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58

  percent = 0.5   zzh = ZigZag[percent](high) zzl = zigzag[percent](low)   itop = zzh<zzh[1] and zzh[1]>zzh[2] bot = zzl>zzl[1] and zzl[1]<zzl[2]   once lastzz=1 atr = averagetruerange[10]   //peaks if itop then     //segment if lastzz<0 then drawsegment(barindex[1],zzh[1],prevlbar,prevl)   //LH if zzh[1]<prevh then drawtext("LH",barindex[1],zzh[1]+atr/2,dialog,bold,16) else //HH drawtext("HH",barindex[1],zzh[1]+atr/2,dialog,bold,16) endif else drawsegment(barindex[1],zzh[1],prevhbar,prevh) endif lastzz=1 prevhbar=barindex[1] prevh=zzh[1] endif   //troughs if bot then     //segment if lastzz>0 then drawsegment(barindex[1],zzl[1],prevhbar,prevh)   //HL if zzl[1]>prevl then drawtext("HL",barindex[1],zzl[1]-atr/2,dialog,bold,16) else //LL drawtext("LL",barindex[1],zzl[1]-atr/2,dialog,bold,16) endif else drawsegment(barindex[1],zzl[1],prevlbar,prevl) endif lastzz=-1 prevlbar=barindex[1] prevl=zzl[1] endif   return

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4774 times
  09/17/2018 at 10:52 AM #80678
  Moritz Müller

  Salut Nicolas,

  you are a super star. thanks.

  great support – as always – from your side.

  thanks again

  Moritz

  

  Moritz Müller

  Participant

  Topics: 3

  Replies: 9

  Been thanked: 1 time
  09/17/2018 at 4:35 PM #80714
  Lighthouse

  At line 22 it should be written LH (since it is a Lower High)

  2 users thanked author for this post.

  Nicolas, swapping

  

  Lighthouse

  Participant

  Topics: 15

  Replies: 32

  Been thanked: 14 times
  09/18/2018 at 8:06 AM #80737
  Nicolas

  @Ciccio
  Thanks! 🙂
  I modified the code.

  1 user thanked author for this post.

  Lighthouse

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4774 times
  09/03/2019 at 1:15 AM #106300
  Kevin

  Hi Nicolas

  this is the exact indicator that I’m looking for. I’m using trading view pine script to plot in your code and it failed and says not working. I’m really new to this thing. Can you help me how to put in this code to trading view ?

  thanks

  kevin

  

  Kevin

  Participant

  Topics: 0

  Replies: 1

  Been thanked: 0 times
  09/03/2019 at 10:19 AM #106343
  Nicolas

  Sorry Kevin but our website is not providing help for tradingview platform. All codes here are usable in the ProRealTime trading plaform: https://trading.prorealtime.com/en/

  Enjoy our free help and hundred of codes by using PRT 😉

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4774 times
  10/08/2019 at 1:55 PM #109623
  RICHI71

  Hi Nicolas, what about to outline a ProOrder Strategy based on this indicator? Thank you

  

  RICHI71

  Participant

  Topics: 1

  Replies: 4

  Been thanked: 3 times
  10/08/2019 at 3:10 PM #109627
  Nicolas

  Please describe it into a fresh new topic in ProOrder section, to see how I could help coding it. Thank you.

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4774 times
  02/21/2021 at 3:34 PM #162225
  clemencejesse

  I  found this while looking for a code to mark HH, HL, LL, HL on charts. The code above works well on a daily chart. How can I adjust it to work on any timeframe? Thanks

  

  clemencejesse

  Participant

  Topics: 4

  Replies: 10

  Been thanked: 0 times
  02/22/2021 at 9:42 AM #162311
  Nicolas

  adapt the percent settings, it is set to 0.5% by default in the first line of the code.

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4774 times
  10/05/2021 at 2:04 PM #179074
  sakkers

  Hi Nicolas,

  Great indicator however when I plot it on an intraday chart, I use 20sec and 1min, initially the indicator plots the swings correctly however as the realtime feed continues the indicator starts to plot the very small swings.  I have no idea why this is occuring.  I’ll post two charts as an example of what is happening.  Unless this code is not capable to run with streaming prices?  If there is a solution to this I have a request for a mod to the indicator however I’ll let you review this first problem/quesion.

  

  sakkers

  Participant

  Topics: 2

  Replies: 5

  Been thanked: 0 times
• Author
  Posts