Help with this Code (cant get an MA to display correctly)

• 02/13/2019 at 9:06 PM #91331
  VPT PRT

  Hi all,

   

  I’m hoping to get some help with a small problem.

   

  In the attached .itf file I have been trying to code in Upper and Lower boundaries (like dynamic reference points).  I would like to apply a EMA to the upper and lower boundary plots, but when I try to do this it always ends up changing the original boundary, and all I want is a new EMA plot of the boundary.

   

  Can anyone please tell me where I’m going wrong?

   

   

  

  VPT PRT

  Participant

  Topics: 9

  Replies: 14

  Been thanked: 0 times
  02/13/2019 at 9:14 PM #91334
  VPT PRT

  All I want to do is use the EMA to smooth out the boundaries.

   

  So in the picture attached are two EMA’s that I have applied to the two boundaries.  I just used the ‘add indicator’ button on the indicator settings tap.  I just want to hardwire the EMA’s into the .itf attached…….

   

  Hoping you can help

   

  Thanks

   

  Ross

  

  VPT PRT

  Participant

  Topics: 9

  Replies: 14

  Been thanked: 0 times
  02/14/2019 at 9:10 AM #91349
  Nicolas

  Please post your code into your next message, better for people to answer directly into your code than to import file and then get back here.. Thank you.

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  02/14/2019 at 11:39 AM #91355
  VPT PRT

  Thanks for that Nicolas, good point.

   

  Here is the code:

   

  if PeriodsBefore>0 then a = (ExponentialAverage[iFirstMaPeriod](ExponentialAverage[iSecondMaPeriod](ROC[1](close[PeriodsBefore])))) b = (ExponentialAverage[iFirstMaPeriod](ExponentialAverage[iSecondMaPeriod](ABS(ROC[1](close[PeriodsBefore]))))) MyMacd = 100 * (a/b) else a = (ExponentialAverage[iFirstMaPeriod](ExponentialAverage[iSecondMaPeriod](ROC[1](close)))) b = (ExponentialAverage[iFirstMaPeriod](ExponentialAverage[iSecondMaPeriod](ABS(ROC[1](close))))) MyMacd = 100 * (a/b) endif //NormMidpointValue = 0//(NormUpperboundary+NormLowerBoundary)/2 //MidpointValue =0 if NormUpperboundary < MyMacd+ShieldValue then NormUpperboundary = MyMacd+ShieldValue else if (NormUpperboundary-ABS(NormUpperboundary-NormLowerBoundary)* Percentage/100)>= MyMacd then NormUpperboundary = NormUpperboundary-(ABS(NormUpperboundary-NormLowerBoundary)* Percentage/100) endif endif if NormLowerBoundary > MyMacd-ShieldValue Then NormLowerBoundary = MyMacd-ShieldValue else if (NormLowerBoundary + ABS(NormUpperboundary-NormLowerBoundary)* Percentage/100) <= MyMaCD then NormLowerBoundary = (NormLowerBoundary + (ABS((NormUpperboundary-NormLowerBoundary))* Percentage/100)) endif endif Indicator = 0 Indicator = ((MyMacd - NormLowerBoundary) *200/(NormUpperboundary-NormLowerBoundary) -100) //NormMidpointValue = ((NormMidpointValue - NormLowerBoundary) *200/(NormUpperboundary-NormLowerBoundary) -100)> 100 If TypeOfRange >0 then if UpperBoundary <= TypeOfRange then UpperBoundary = TypeOfRange endif endif if Upperboundary < Indicator+RangeShieldValue then UpperBoundary = Indicator+RangeShieldValue else if (UpperBoundary-ABS(UpperBoundary-LowerBoundary)* RangePercentage/100)>= Indicator then UpperBoundary = UpperBoundary-(ABS(UpperBoundary-LowerBoundary)* RangePercentage/100) endif endif UpperBoundary = Average[1](UpperBoundary) If TypeOfRange >0 then if LowerBoundary >= 0-TypeOfRange then LowerBoundary = 0-TypeOfRange endif endif if LowerBoundary > Indicator-RangeShieldValue Then LowerBoundary = Indicator-RangeShieldValue else if (LowerBoundary + ABS(UpperBoundary-LowerBoundary)* RangePercentage/100) <= Indicator then LowerBoundary = (LowerBoundary + (ABS((UpperBoundary-LowerBoundary))* RangePercentage/100)) endif endif LowerBoundary = Average[1](LowerBoundary) return Indicator*Multiplier COLOURED(100, 100, 100) as "MACD", UpperBoundary COLOURED(0,0, 255) as "Upper Boundary", 0 COLOURED(255, 0, 0) as "midline", LowerBoundary COLOURED( 0,255, 0) as "Lower Boundary", (UpperBoundary+LowerBoundary)/2 as "range midline"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65

  if PeriodsBefore>0 then a = (ExponentialAverage[iFirstMaPeriod](ExponentialAverage[iSecondMaPeriod](ROC[1](close[PeriodsBefore])))) b = (ExponentialAverage[iFirstMaPeriod](ExponentialAverage[iSecondMaPeriod](ABS(ROC[1](close[PeriodsBefore])))))   MyMacd = 100 * (a/b) else a = (ExponentialAverage[iFirstMaPeriod](ExponentialAverage[iSecondMaPeriod](ROC[1](close)))) b = (ExponentialAverage[iFirstMaPeriod](ExponentialAverage[iSecondMaPeriod](ABS(ROC[1](close)))))   MyMacd = 100 * (a/b) endif //NormMidpointValue = 0//(NormUpperboundary+NormLowerBoundary)/2 //MidpointValue =0   if NormUpperboundary < MyMacd+ShieldValue then NormUpperboundary = MyMacd+ShieldValue else if (NormUpperboundary-ABS(NormUpperboundary-NormLowerBoundary)* Percentage/100)>= MyMacd then NormUpperboundary = NormUpperboundary-(ABS(NormUpperboundary-NormLowerBoundary)* Percentage/100) endif endif   if NormLowerBoundary > MyMacd-ShieldValue Then NormLowerBoundary = MyMacd-ShieldValue else   if (NormLowerBoundary + ABS(NormUpperboundary-NormLowerBoundary)* Percentage/100) <= MyMaCD then NormLowerBoundary = (NormLowerBoundary + (ABS((NormUpperboundary-NormLowerBoundary))* Percentage/100)) endif endif   Indicator = 0   Indicator = ((MyMacd - NormLowerBoundary) *200/(NormUpperboundary-NormLowerBoundary) -100) //NormMidpointValue = ((NormMidpointValue - NormLowerBoundary) *200/(NormUpperboundary-NormLowerBoundary) -100)> 100   If TypeOfRange >0 then if UpperBoundary <= TypeOfRange then UpperBoundary = TypeOfRange endif endif   if Upperboundary < Indicator+RangeShieldValue then UpperBoundary = Indicator+RangeShieldValue else if (UpperBoundary-ABS(UpperBoundary-LowerBoundary)* RangePercentage/100)>= Indicator then UpperBoundary = UpperBoundary-(ABS(UpperBoundary-LowerBoundary)* RangePercentage/100) endif endif UpperBoundary = Average[1](UpperBoundary) If TypeOfRange >0 then if LowerBoundary >= 0-TypeOfRange then LowerBoundary = 0-TypeOfRange endif endif if LowerBoundary > Indicator-RangeShieldValue Then LowerBoundary = Indicator-RangeShieldValue else if (LowerBoundary + ABS(UpperBoundary-LowerBoundary)* RangePercentage/100) <= Indicator then LowerBoundary = (LowerBoundary + (ABS((UpperBoundary-LowerBoundary))* RangePercentage/100)) endif endif LowerBoundary = Average[1](LowerBoundary)   return Indicator*Multiplier COLOURED(100, 100, 100) as "MACD", UpperBoundary COLOURED(0,0, 255) as "Upper Boundary", 0 COLOURED(255, 0, 0) as "midline", LowerBoundary COLOURED( 0,255, 0) as "Lower Boundary", (UpperBoundary+LowerBoundary)/2 as "range midline"

   

  

  VPT PRT

  Participant

  Topics: 9

  Replies: 14

  Been thanked: 0 times
  02/14/2019 at 11:55 AM #91356
  Vonasi

  VPT PRT – please use the ‘Insert PRT Code’ button when posting code. It makes it far easier for others to read. I have tidied up your post for you 🙂

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  02/14/2019 at 12:01 PM #91357
  Vonasi

  Create a new variable to be used as your displayed value this way you don’t mess up your calculations.

  UB = ExponentialAverage[10](UpperBoundary) LB = ExponentialAverage[10](LowerBoundary) return Indicator*Multiplier COLOURED(100, 100, 100) as "MACD", UB COLOURED(0,0, 255) as "Upper Boundary", 0 COLOURED(255, 0, 0) as "midline", LB COLOURED( 0,255, 0) as "Lower Boundary", (UB+LB)/2 as "range midline"

  1 2 3 4

  UB = ExponentialAverage[10](UpperBoundary) LB = ExponentialAverage[10](LowerBoundary)   return Indicator*Multiplier COLOURED(100, 100, 100) as "MACD", UB COLOURED(0,0, 255) as "Upper Boundary", 0 COLOURED(255, 0, 0) as "midline", LB COLOURED( 0,255, 0) as "Lower Boundary", (UB+LB)/2 as "range midline"

   

  1 user thanked author for this post.

  Nicolas

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  02/14/2019 at 9:49 PM #91425
  VPT PRT

  Thank you very much for that Vonasi, thats sorted my problem.

  Cheers

  Ross

  

  VPT PRT

  Participant

  Topics: 9

  Replies: 14

  Been thanked: 0 times
• Author
  Posts