Highest and Second highest point in last X bars if current close is lower

• 03/19/2021 at 12:58 PM #164651
  JanC20

  Good day, This is my first time trying….

  I want to create an indicator that could identify:

  1. The highert point in the last X bars then
  2. From that point of the highest bar, to the current bar, I would like to calculate the second highest bar.

  But I constantly get an error message: “un parametre de type entier positif est attendu avec highest”

  Here is the code, and I do not understand the reason, as the defenition is a full number??? Could anyone help?

  bars = 70 Y1 = highest[bars] (high[1]) if high <Y1 or high [1]<Y1 then for i = bars downto 1 do if high [i] = Y1 then X1 = i-1 DRAWTEXT("#X1#", barindex [X1], high [x1]) break endif next Y2 = highest[X1] (high[1]) for n = X1 downto 0 do if high [n] = Y2 then X2 = n DRAWTEXT("#X2#", barindex [n], high [n]) break endif next endif return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26

  bars = 70 Y1 = highest[bars] (high[1])   if high <Y1 or high [1]<Y1 then   for i = bars downto 1 do if high [i] = Y1 then X1 = i-1 DRAWTEXT("#X1#", barindex [X1], high [x1]) break endif next   Y2 = highest[X1] (high[1])   for n = X1 downto 0 do if high [n] = Y2 then X2 = n DRAWTEXT("#X2#", barindex [n], high [n]) break endif next   endif   return

   

   

  

  JanC20

  Participant

  Topics: 1

  Replies: 1

  Been thanked: 0 times
  03/19/2021 at 1:19 PM #164658
  JC_Bywan

  Hello, moderation messages :

  • you posted in English in french forum, please see rules in yellow box below about choosing the right forum. No need to repost we’ll move this topic now
  • you posted code without formatting it, please see image attached to locate the “insert PRT code” button as this is your first time. Again no need to repost, we’ll reformat your code in above message now

  

  JC_Bywan

  Moderator

  Topics: 20

  Replies: 2674

  Been thanked: 941 times
  03/19/2021 at 1:37 PM #164668
  JC_Bywan

  Your first “for to next” loop ending with i=1, x1=i-1 will be =0 when i=1, and the error message “entier positif” (positive integer) for X1 in highest[x1](…) means X1 has to be at least 1, not 0… so either make sure X1 can’t be zero, or use something bigger than X1 with highest

  

  JC_Bywan

  Moderator

  Topics: 20

  Replies: 2674

  Been thanked: 941 times
  03/19/2021 at 3:45 PM #164686
  JanC20

  Thanks you for pointing this out!  It was a great help

  

  JanC20

  Participant

  Topics: 1

  Replies: 1

  Been thanked: 0 times
• Author
  Posts