Improve calculating time of own indicator

• 07/07/2017 at 6:06 PM #40044
  Fabian

  Hi,

  i have a own indicator. Its based on the Donchian Channel.

  In programming a own indicator i cant choose the Donchian Channel indicator. Therefore i create my own DC indicator:

  PointHigh = HIGHEST[n] (HIGH) PointLow = LOWEST[n](LOW) Return PointHigh AS "HIGH", PointLow AS "LOW"

  1 2 3 4

  PointHigh = HIGHEST[n] (HIGH) PointLow = LOWEST[n](LOW)   Return PointHigh AS "HIGH", PointLow AS "LOW"

  Here is my own indicator, but the calculating time is very bad…i wrote a java program to calculate my indicator its much more faster. Therefore i think i make a mistake in prorealtime?

  myHIGH, myLOW = CALL "DC Own"[perioden] result = 0 resultIndikator = 0 FOR i = 0 TO perioden DO IF myHigh[i] > myHigh[i+1] THEN result = result + 1 ENDIF IF myLow[i] < myLow[i+1] THEN result = result + 1 ENDIF NEXT IF result > mindestWert THEN resultIndikator = 1 ELSE resultIndikator = -1 ENDIF return resultIndikator

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21

  myHIGH, myLOW = CALL "DC Own"[perioden]   result = 0 resultIndikator = 0   FOR i = 0 TO perioden DO IF myHigh[i] > myHigh[i+1] THEN result = result + 1 ENDIF IF myLow[i] < myLow[i+1] THEN result = result + 1 ENDIF NEXT   IF result > mindestWert THEN resultIndikator = 1 ELSE resultIndikator = -1 ENDIF   return resultIndikator

  Has anyone a idea to improve the calculating time?

  Thanks!

   

  

  Fabian

  Participant

  Topics: 3

  Replies: 4

  Been thanked: 0 times
  07/08/2017 at 3:29 PM #40093
  JC_Bywan

  Hi,

  We are all expecting fairly soon a new engine allowing “call” to be much faster than its current snail pace. In the meantime whenever possible avoiding “call”, by copying and pasting the called code in the calling code, will go a long way to improve speed (worth having a look at pages 23-24-25, especially p25, of following manual with some examples)  https://www.prorealtime.com/en/pdf/probacktest_c1491462069c.pdf

  1 user thanked author for this post.

  Nicolas

  

  JC_Bywan

  Moderator

  Topics: 20

  Replies: 2651

  Been thanked: 915 times
  07/08/2017 at 7:54 PM #40121
  Nicolas

  You can also increase speed of your program replacing this kind of FOR/NEXT loop by using SUMMATION of boolean variables results.

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
• Author
  Posts