Is barindex an integer? lowest sees it differently

• 02/10/2023 at 11:00 AM #209476
  Wim

  I am having some problems with Lowest and Highest functions in my indicator. Every now and then the indicator crashes with the error message that Lowest (or Highest) requires a positive integer as parameter. So i wrote some lines to test this further and find the culprit. And . . . the culprit seems to be “barindex”. The code passes the variable numberBars, being the difference between actual bar and a historic bar, to the function Lowest. When I supply the bar numbers of these 2 bars myself to Lowest, no problem. When I ask the indicator to calculate the numberBars as the difference of “barindex – historicbarindex”, pang, error message, indicator wiped of the chart. I tried to rescue the situation by adding Floor(substraction,0) to the code. But Lowest stubbornly interprets this numberBars also as a non-integer. What am I missing here?

  My test was on the DAX 1 minute chart this morning, at barindex 1503. With the line currentIndex=barindex as comment, it returns 1503 and 103 as barindex and 103 as numberBars (screenshot 1). When I uncomment the line, the indicator crashes (screenshot 2).

  Thanks for helping me out here.

  First set currentIndex to value of actual bar

  // WM-LowestHighest // startIndex = 1400 currentIndex = 1503 //currentIndex = barindex // un-comment for testing with barindex instead of fixed value numberBars = floor(currentIndex - startIndex,0) lowestValue = lowest[numberBars] highestValue = highest[numberBars] lowestValue = 15499 highestValue = 15799 return barindex as "barindex",numberBars as "numberBars", lowestValue as "lowestValue", highestValue as "highestValue"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15

  // WM-LowestHighest // startIndex   = 1400 currentIndex = 1503 //currentIndex = barindex   // un-comment for testing with barindex instead of fixed value   numberBars = floor(currentIndex - startIndex,0)   lowestValue = lowest[numberBars] highestValue = highest[numberBars]   lowestValue = 15499 highestValue = 15799   return barindex as "barindex",numberBars as "numberBars", lowestValue as "lowestValue", highestValue as "highestValue"

  

  Wim

  Participant

  Topics: 9

  Replies: 95

  Been thanked: 48 times
  02/10/2023 at 12:17 PM #209500
  robertogozzi

  Try replacing line 7 with:

  numberBars = currentIndex - startIndex

  1	numberBars = currentIndex - startIndex

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17143

  Been thanked: 4032 times
  02/10/2023 at 2:32 PM #209510
  Wim

  Thanks Roberto. But that was how I started. I added the Floor-trick hoping that would definitely make numberBars an integer. To me it’s an integer, but not to Lowest and Highest. Next tip?

  

  Wim

  Participant

  Topics: 9

  Replies: 95

  Been thanked: 48 times
  02/10/2023 at 3:07 PM #209513
  JC_Bywan

  When you use currentIndex = barindex, for any bar in history lower than or equal to your startindex=1400, then your numberbars= currentIndex – startIndex is negative, or at best, zero (with or without floor, doesn’t matter it’s not about the decimals), and it is prevented by the error message because it makes no sense to use a negative parameter for lowest or highest, even if its absolute value is an integer, it has to be a positive number of candles. You can fix it by not calculating lowest/highest as long as numberBars is negative or 0 with:

  startIndex = 1400 //currentIndex = 1503 currentIndex = barindex numberBars = currentIndex - startIndex if numberbars>0 then lowestValue = lowest[numberBars] highestValue = highest[numberBars] endif

  1 2 3 4 5 6 7 8 9 10

  startIndex = 1400 //currentIndex = 1503 currentIndex = barindex   numberBars = currentIndex - startIndex   if numberbars>0 then lowestValue = lowest[numberBars] highestValue = highest[numberBars] endif

   

   

  2 users thanked author for this post.

  robertogozzi, Wim

  

  JC_Bywan

  Moderator

  Topics: 20

  Replies: 2651

  Been thanked: 915 times
  02/10/2023 at 7:06 PM #209523
  Wim

  Thank you for pointing out what I wasn’t seeing. It is so basic, but still missed it completely this time.

   

  

  Wim

  Participant

  Topics: 9

  Replies: 95

  Been thanked: 48 times
• Author
  Posts