Monthly High Low Close Indicator

• 04/05/2019 at 12:50 PM #95537
  vetrader

  Sorry, I’m new to Proraltime and couldn’t imagine that this so dificult in the software.

  

  vetrader

  Participant

  Topics: 11

  Replies: 19

  Been thanked: 2 times
  04/05/2019 at 2:28 PM #95543
  pableitor

  With arrays it would be no problem to get monthly , weekly , daily OHLC  but without arrays its not so easy.

  1 user thanked author for this post.

  Nicolas

  

  pableitor

  Participant

  Topics: 20

  Replies: 127

  Been thanked: 47 times
  04/05/2019 at 4:32 PM #95560
  Vonasi

  This might help:

  if (opendayofweek = 1) or (opendayofweek < opendayofweek[1] and opendayofweek <> 0) then lastweekhigh = weekhigh lastweeklow = weeklow lastweekopen = weekopen lastweekclose = weekclose weekhigh = 0 weeklow = close weekopen = open weekclose = close endif weekhigh = max(weekhigh,high) weeklow = min(weeklow,low) weekclose = close if openmonth <> openmonth[1] then lastmonthhigh = monthhigh lastmonthlow = monthlow lastmonthopen = monthopen lastmonthclose = monthclose monthhigh = 0 monthlow = close monthopen = open monthclose = close endif monthhigh = max(monthhigh,high) monthlow = min(monthlow,low) monthclose = close return lastweekhigh as "Last Weeks High",lastweeklow as "Last Weeks Low",lastweekclose as "Last Weeks Close",lastweekopen as "Last Weeks Open", lastmonthhigh as "Last Months High",lastmonthlow as "Last Months Low",lastmonthclose as "Last Months Close",lastmonthopen as "Last Months Open"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32

  if (opendayofweek = 1) or (opendayofweek < opendayofweek[1] and opendayofweek <> 0) then lastweekhigh = weekhigh lastweeklow = weeklow lastweekopen = weekopen lastweekclose = weekclose weekhigh = 0 weeklow = close weekopen = open weekclose = close endif   weekhigh = max(weekhigh,high) weeklow = min(weeklow,low) weekclose = close   if openmonth <> openmonth[1] then lastmonthhigh = monthhigh lastmonthlow = monthlow lastmonthopen = monthopen lastmonthclose = monthclose monthhigh = 0 monthlow = close monthopen = open monthclose = close endif   monthhigh = max(monthhigh,high) monthlow = min(monthlow,low) monthclose = close     return lastweekhigh as "Last Weeks High",lastweeklow as "Last Weeks Low",lastweekclose as "Last Weeks Close",lastweekopen as "Last Weeks Open", lastmonthhigh as "Last Months High",lastmonthlow as "Last Months Low",lastmonthclose as "Last Months Close",lastmonthopen as "Last Months Open"

  It recognises the start of a new week (even if it is not a Monday) and the start of a new month and starts recording highs, lows, open and close. At the start of every new week and new month it records the previous weeks/months values.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  04/05/2019 at 7:42 PM #95582
  Vonasi

  I just realised that my code in the last post starts the week at the open of the first weekly candle from Monday onwards when it should really be the Sunday candle onwards as this is when a week actually starts trading.  Just change line 1 to:

  if opendayofweek < opendayofweek[1] then

  1	if opendayofweek < opendayofweek[1] then

   

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  04/06/2019 at 10:57 AM #95601
  pableitor

  thanks @vonasi, now the big problem  is this: lets say I am on a lower TF chart , how to get the weekly / monthly OHLC from N  weeks /months ago ?

  

  pableitor

  Participant

  Topics: 20

  Replies: 127

  Been thanked: 47 times
  04/06/2019 at 11:29 AM #95604
  Vonasi

  pableitor wrote:

  how to get the weekly / monthly OHLC from N  weeks /months ago ?

  By creating our own index that updates whenever a new month or new week start is detected and then searching back using a FOR NEXT or WHILE WEND loop this should be possible. I will try to code something – lunch first though!

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  04/06/2019 at 12:19 PM #95609
  Vonasi

  Easier to separate it into two indicators – a weekly one and a monthly one.

  weeklookback is the variable for how many weeks you want to look back (1 = last week, 2 = two weeks ago). monthlookback in the monthly version.

  Weekly

  weeklookback = 2 if opendayofweek < opendayofweek[1] then weekindex = weekindex + 1 weekhigh = 0 weeklow = close weekopen = open weekclose = close endif weekhigh = max(weekhigh,high) weeklow = min(weeklow,low) weekclose = close if weekindex > weeklookback then for j = 1 to barindex if weekindex[j] = weekindex - weeklookback then myweekhigh = weekhigh[j] myweeklow = weeklow[j] myweekopen = weekopen[j] myweekclose = weekclose[j] break endif next endif return myweekhigh as "Week High", myweeklow as "Week Low", myweekclose as "Week Close", myweekopen as "Week Open"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27

  weeklookback = 2   if opendayofweek < opendayofweek[1] then weekindex = weekindex + 1 weekhigh = 0 weeklow = close weekopen = open weekclose = close endif   weekhigh = max(weekhigh,high) weeklow = min(weeklow,low) weekclose = close   if weekindex > weeklookback then for j = 1 to barindex if weekindex[j] = weekindex - weeklookback then myweekhigh = weekhigh[j] myweeklow = weeklow[j] myweekopen = weekopen[j] myweekclose = weekclose[j] break endif next endif   return myweekhigh as "Week High", myweeklow as "Week Low", myweekclose as "Week Close", myweekopen as "Week Open"

  Monthly

  monthlookback = 2 if openmonth <> openmonth[1] then monthindex = monthindex + 1 monthhigh = 0 monthlow = close monthopen = open monthclose = close endif monthhigh = max(monthhigh,high) monthlow = min(monthlow,low) monthclose = close if monthindex > monthlookback then for j = 1 to barindex if monthindex[j] = monthindex - monthlookback then mymonthhigh = monthhigh[j] mymonthlow = monthlow[j] mymonthopen = monthopen[j] mymonthclose = monthclose[j] break endif next endif return mymonthhigh as "Month High", mymonthlow as "Month Low", mymonthclose as "Month Close", mymonthopen as "Month Open"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27

  monthlookback = 2   if openmonth <> openmonth[1] then monthindex = monthindex + 1 monthhigh = 0 monthlow = close monthopen = open monthclose = close endif   monthhigh = max(monthhigh,high) monthlow = min(monthlow,low) monthclose = close   if monthindex > monthlookback then for j = 1 to barindex if monthindex[j] = monthindex - monthlookback then mymonthhigh = monthhigh[j] mymonthlow = monthlow[j] mymonthopen = monthopen[j] mymonthclose = monthclose[j] break endif next endif   return mymonthhigh as "Month High", mymonthlow as "Month Low", mymonthclose as "Month Close", mymonthopen as "Month Open"

   

  1 user thanked author for this post.

  pableitor

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  04/06/2019 at 3:36 PM #95614
  pableitor

  Wow, amazing code @vonasi !

  I just moved the second IF  inside the first IF block and it seems to run faster. In fact we only need to check past OHLC data when month or week changes, not on every bar.

   

  monthly

  monthlookback = 2 if openmonth <> openmonth[1] then monthindex = monthindex + 1 monthhigh = 0 monthlow = close monthopen = open monthclose = close if monthindex > monthlookback then for j = 1 to barindex if monthindex[j] = monthindex - monthlookback then mymonthhigh = monthhigh[j] mymonthlow = monthlow[j] mymonthopen = monthopen[j] mymonthclose = monthclose[j] break endif next endif endif monthhigh = max(monthhigh,high) monthlow = min(monthlow,low) monthclose = close return mymonthopen as "Month Open", mymonthhigh as "Month High", mymonthlow as "Month Low", mymonthclose as "Month Close"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29

  monthlookback = 2 if openmonth <> openmonth[1] then monthindex = monthindex + 1 monthhigh = 0 monthlow = close monthopen = open monthclose = close   if monthindex > monthlookback then for j = 1 to barindex if monthindex[j] = monthindex - monthlookback then mymonthhigh = monthhigh[j] mymonthlow = monthlow[j] mymonthopen = monthopen[j] mymonthclose = monthclose[j] break endif next endif     endif monthhigh = max(monthhigh,high) monthlow = min(monthlow,low) monthclose = close   return mymonthopen as "Month Open", mymonthhigh as "Month High", mymonthlow as "Month Low", mymonthclose as "Month Close"

  Weekly

  weeklookback = 2 if opendayofweek < opendayofweek[1] then weekindex = weekindex + 1 weekhigh = 0 weeklow = close weekopen = open weekclose = close if weekindex > weeklookback then for j = 1 to barindex if weekindex[j] = weekindex - weeklookback then myweekhigh = weekhigh[j] myweeklow = weeklow[j] myweekopen = weekopen[j] myweekclose = weekclose[j] break endif next endif endif weekhigh = max(weekhigh,high) weeklow = min(weeklow,low) weekclose = close return myweekopen as "Week Open", myweekhigh as "Week High", myweeklow as "Week Low", myweekclose as "Week Close"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28

  weeklookback = 2 if opendayofweek < opendayofweek[1] then weekindex = weekindex + 1 weekhigh = 0 weeklow = close weekopen = open weekclose = close   if weekindex > weeklookback then for j = 1 to barindex if weekindex[j] = weekindex - weeklookback then myweekhigh = weekhigh[j] myweeklow = weeklow[j] myweekopen = weekopen[j] myweekclose = weekclose[j] break endif next endif   endif weekhigh = max(weekhigh,high) weeklow = min(weeklow,low) weekclose = close return myweekopen as "Week Open", myweekhigh as "Week High", myweeklow as "Week Low", myweekclose as "Week Close"

   

  

  pableitor

  Participant

  Topics: 20

  Replies: 127

  Been thanked: 47 times
  04/06/2019 at 4:08 PM #95617
  Vonasi

  Well spotted pableitor. In my defence I did code it while eating lunch as I was too impatient to get started on it!

  Glad you like it – although I’m not sure what use there is in knowing what the OHLC was several months ago? Personally I’ve never found previous OHLC levels to offer any support or resistance of any worth but I’m willing to be proved wrong.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  04/06/2019 at 7:28 PM #95626
  Vonasi

  Here is a minor improvement that gets rid of the problem of values being zero until the first new week or month has been recognised. They are now all equal to close and not drawn on the chart. I’ve added some colour too.

  Weekly

  weeklookback = 2 if opendayofweek < opendayofweek[1] then weekindex = weekindex + 1 weekhigh = 0 weeklow = close weekopen = open weekclose = close if weekindex > weeklookback then for j = 1 to barindex if weekindex[j] = weekindex - weeklookback then myweekhigh = weekhigh[j] myweeklow = weeklow[j] myweekopen = weekopen[j] myweekclose = weekclose[j] break endif next endif endif weekhigh = max(weekhigh,high) weeklow = min(weeklow,low) weekclose = close c = 255 if myweekopen = 0 then myweekopen = close myweekclose = close myweekhigh = close myweeklow = close c = 0 endif return myweekopen coloured(0,0,0,c)as "Week Open", myweekhigh coloured(0,128,0,c) as "Week High", myweeklow coloured(128,0,0,c) as "Week Low", myweekclose coloured(0,0,255,c) as "Week Close"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36

  weeklookback = 2   if opendayofweek < opendayofweek[1] then weekindex = weekindex + 1 weekhigh = 0 weeklow = close weekopen = open weekclose = close if weekindex > weeklookback then for j = 1 to barindex if weekindex[j] = weekindex - weeklookback then myweekhigh = weekhigh[j] myweeklow = weeklow[j] myweekopen = weekopen[j] myweekclose = weekclose[j] break endif next endif endif weekhigh = max(weekhigh,high) weeklow = min(weeklow,low) weekclose = close   c = 255 if myweekopen = 0 then myweekopen = close myweekclose = close myweekhigh = close myweeklow = close c = 0 endif return myweekopen coloured(0,0,0,c)as "Week Open", myweekhigh coloured(0,128,0,c) as "Week High", myweeklow coloured(128,0,0,c) as "Week Low", myweekclose coloured(0,0,255,c) as "Week Close"

   

  Monthly

  monthlookback = 2 if openmonth <> openmonth[1] then monthindex = monthindex + 1 monthhigh = 0 monthlow = close monthopen = open monthclose = close if monthindex > monthlookback then for j = 1 to barindex if monthindex[j] = monthindex - monthlookback then mymonthhigh = monthhigh[j] mymonthlow = monthlow[j] mymonthopen = monthopen[j] mymonthclose = monthclose[j] break endif next endif endif monthhigh = max(monthhigh,high) monthlow = min(monthlow,low) monthclose = close c = 255 if mymonthopen = 0 then mymonthopen = close mymonthclose = close mymonthhigh = close mymonthlow = close c = 0 endif return mymonthopen coloured(0,0,0,c)as "Month Open", mymonthhigh coloured (0,128,0,c) as "Month High", mymonthlow coloured (128,0,0,c) as "Month Low", mymonthclose coloured (0,0,255,c) as "Month Close"

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36

  monthlookback = 2   if openmonth <> openmonth[1] then monthindex = monthindex + 1 monthhigh = 0 monthlow = close monthopen = open monthclose = close if monthindex > monthlookback then for j = 1 to barindex if monthindex[j] = monthindex - monthlookback then mymonthhigh = monthhigh[j] mymonthlow = monthlow[j] mymonthopen = monthopen[j] mymonthclose = monthclose[j] break endif next endif endif monthhigh = max(monthhigh,high) monthlow = min(monthlow,low) monthclose = close   c = 255 if mymonthopen = 0 then mymonthopen = close mymonthclose = close mymonthhigh = close mymonthlow = close c = 0 endif   return mymonthopen coloured(0,0,0,c)as "Month Open", mymonthhigh coloured (0,128,0,c) as "Month High", mymonthlow coloured (128,0,0,c) as "Month Low", mymonthclose coloured (0,0,255,c) as "Month Close"

   

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  04/08/2019 at 7:17 AM #95658
  vetrader

  Thanks a lot – I will also try this!

  

  vetrader

  Participant

  Topics: 11

  Replies: 19

  Been thanked: 2 times
  01/08/2021 at 10:28 AM #156871
  MacroT

  One of the codes posted in this thread works fine on prt v 10.3 but not on v11.1.

  I am displayed with the error ‘A positive integer field is expected with highest’ message

  Thanks

  If Month<>Month[1] then monthlyH = Highest[BarIndex – lastMonthBarIndex](High)[1] monthlyL = Lowest[BarIndex – lastMonthBarIndex](Low)[1] lastMonthBarIndex = BarIndex if trimH=0 then trimH=monthlyH endif trimH=max(trimH,monthlyH) if trimL=0 then trimL=monthlyL endif trimL=min(trimL,monthlyL) if openmonth=4 or openmonth=7 or openmonth=10 or openmonth=1 then trimestrialH=trimH trimestrialL=trimL endif Endif return trimestrialH,trimestrialL

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19

  If Month<>Month[1] then monthlyH = Highest[BarIndex – lastMonthBarIndex](High)[1] monthlyL = Lowest[BarIndex – lastMonthBarIndex](Low)[1] lastMonthBarIndex = BarIndex if trimH=0 then trimH=monthlyH endif trimH=max(trimH,monthlyH) if trimL=0 then trimL=monthlyL endif trimL=min(trimL,monthlyL) if openmonth=4 or openmonth=7 or openmonth=10 or openmonth=1 then trimestrialH=trimH trimestrialL=trimL endif Endif   return trimestrialH,trimestrialL

   

  

  MacroT

  Participant

  Topics: 21

  Replies: 17

  Been thanked: 0 times
  01/08/2021 at 10:42 AM #156875
  robertogozzi

  Always use the ‘Insert PRT Code’ button when putting code in your posts to make it easier for others to read.

  Thank you 🙂

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17130

  Been thanked: 4026 times
  01/08/2021 at 11:13 AM #156882
  Vonasi

  MacroT – Try this:

  if barindex >= 1 then If Month<>Month[1] then monthlyH = Highest[BarIndex - lastMonthBarIndex](High)[1] monthlyL = Lowest[BarIndex - lastMonthBarIndex](Low)[1] lastMonthBarIndex = BarIndex if trimH=0 then trimH=monthlyH endif trimH=max(trimH,monthlyH) if trimL=0 then trimL=monthlyL endif trimL=min(trimL,monthlyL) if openmonth=4 or openmonth=7 or openmonth=10 or openmonth=1 then trimestrialH=trimH trimestrialL=trimL endif Endif endif return trimestrialH,trimestrialL

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21

  if barindex >= 1 then If Month<>Month[1] then monthlyH = Highest[BarIndex - lastMonthBarIndex](High)[1] monthlyL = Lowest[BarIndex - lastMonthBarIndex](Low)[1] lastMonthBarIndex = BarIndex if trimH=0 then trimH=monthlyH endif trimH=max(trimH,monthlyH) if trimL=0 then trimL=monthlyL endif trimL=min(trimL,monthlyL) if openmonth=4 or openmonth=7 or openmonth=10 or openmonth=1 then trimestrialH=trimH trimestrialL=trimL endif Endif endif   return trimestrialH,trimestrialL

   

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  01/08/2021 at 12:11 PM #156892
  MacroT

  Thank you – that worked

  

  MacroT

  Participant

  Topics: 21

  Replies: 17

  Been thanked: 0 times
• Author
  Posts