New to programming, need to know what’s wrong with my code
- This topic has 6 replies, 4 voices, and was last updated 4 hours ago by
.
-
Hi.
I see you’re using incorrect expressions when defining the stop loss. If you want to set the stop at X points, you should use the expression
SET STOP pLOSS X.Here are some examples:
https://www.prorealcode.com/documentation/ploss-2/
In principle, yes. Perhaps I would change the last expression to this one:
123IF LongOnMarket AND openTime >= 215700 THENSELL AT MARKETENDIFOr you could place this at the beginning of the code:
1defparam flatafter = 2157001 user thanked author for this post.
Hello,
as you mention you’re new to this, it’s probably worth mentionning what might seem obvious for those familiar with the platform:
1) the instructions “time” and “opentime” are respectively the closing time and the opening time of a candle
2) a proorder code is only read at candle close, and if orders are sent they are executed immediatly after, namely at the open of the following candle
These 2 points together in mind, when you say in the code:
12IF Time = 083000 OR Time = 153000 THENBUY 0.5 CONTRACTS AT MARKETif you run your code say on a one hour timeframe rather than a smaller timeframe, you wouldn’t have any candle closing at 8:30 or 15:30 so the orders would never be sent..Similarly, when you say :12IF LongOnMarket AND Time = 215700 THENSELL AT MARKETif you are on a 5mn timeframe, or even just a 2mn timeframe, there is no candle closing at 21:57, so you would need to run such code on a 1mn timeframe or x seconds providing it divides 1mn (30s,15s,…)
.Maybe you were already doing that, but I don’t see it in your post, so that’s why I specify it, just in case… because, if you’re running on a timeframe not compatible with those times and you see no orders sent, you might be looking for an error in the code when in fact, it’s an error in timeframe choice (or you might choose to keep a certain timeframe but then need to amend time values in the code to make them compatible with chosen timeframe).I want to delve deeper into setting a TARGET and a STOP LOSS.
SET STOP LOSS and SET TARGET PROFIT both require a value, be it a constant or a variable or an expression, expressed as a price, thus that value must be converted from a number into a price by multiplying it by PIPSIZE (or its equivalent POINTSIZE). Should you use a difference between prices, such as the expression highest[10](high) – lowest[10](low), then NO conversion should be performed as they ARE prices, so this is correct:
12SET STOP LOSS highest[10](high) - lowest[10](low)SET TARGET PROFIT highest[10](high) - lowest[10](low)pSTOP and pPROFIT both require a value that is the number of PIPS, be it a constant or a variable or an expression, thus that value must be a number which doesn’t require any conversion. A conversion would be needed if you would like to use a value expressed as a price, such as the expression highest[10](high) – lowest[10](low). These statements are both correct:
12SET STOP pLOSS 100 //Pips are assumed by defaultSET STOP pLOSS (highest[10](high) - lowest[10](low) / PipSize //any price expression must be converted into Pipsany price, be it a constant or a variable or a price expression, must be converted into Pips by DIVIDING that price by PIPSIZE (or its equivalent POINTSIZE).
What has been said about LOSS/TARGET and pLOSS/pTARGET is also true for TRAILING/pTRAILING.
A different case are SET STOP price and SET TARGET price, as they only require a price, so the statements:
12SET STOP PRICE TradePriceSET STOP PRICE TradePrice + 50*PipSizeare both correct and only the latter one requires the numeric constant to be converted into a price, while TRADEPRICE is a price by itself.
1 user thanked author for this post.
Find exclusive trading pro-tools on 
