Newbie coding Request – BB S&R

• 05/15/2017 at 1:36 PM #35588
  denmar

  Just my attempt to emulate Volatility-Based Technical analysis as developed by Kirk Northington – see http://www.tradingtheinvisible.com/htm/resources.html

  

  denmar

  Participant

  Topics: 14

  Replies: 59

  Been thanked: 4 times
  05/15/2017 at 4:42 PM #35615
  Nicolas

  ok, so the code you have posted is incomplete, it only has the upper bollinger bands lines. That’s why I did not understand it very well at the first glance. My attempt is still buggy, I let you know if I can get it through .. soon  .. or not 😉

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4775 times
  05/15/2017 at 4:55 PM #35616
  Nicolas

  This is a rough code, I don’t think it is completely accurate, because I can’t get to know if a Peak() must be consecutive to a Trough() or not (like zigzag..)

  //PRC_BBands S/R inflection (WIP) //https://www.prorealcode.com/topic/newbie-coding-request-bb-sr/ percent = 0.3 peakData=BollingerUp[20](close) troughData=BollingerUp[20](close) if barindex>20 then //Metastock Peak() function if lastdottedline<=0 then higher=max(higher,peakData) endif peakpercent=(higher-peakData)/higher newpeak=peakpercent>percent/100 if newpeak and lastdottedline<=0 then lower=peakData lastdottedline=1 lastpeak=peakData endif //Metastock Trough() function once lower=troughData if lastdottedline>=0 then lower=min(lower,troughData) endif troughpercent=(troughData-lower)/lower newtrough=troughpercent>percent/100 if newtrough and lastdottedline>=0 then higher=troughData lastdottedline=-1 lasttrough=troughData endif atr40=averagetruerange[40] if lastpeak<>lastpeak[1] then peak1=lastpeak peak2=lastpeak-ATR40 endif if lasttrough<>lasttrough[1] then trough1=lasttrough trough2=lasttrough+ATR40 endif endif return peak1 coloured(0,0,255) style(point,2),peak2 coloured(255,100,0) style(point,2),trough1 coloured(0,0,255) style(point,2),trough2 coloured(255,100,0) style(point,2)

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45

  //PRC_BBands S/R inflection (WIP) //https://www.prorealcode.com/topic/newbie-coding-request-bb-sr/   percent = 0.3 peakData=BollingerUp[20](close) troughData=BollingerUp[20](close)   if barindex>20 then //Metastock Peak() function if lastdottedline<=0 then higher=max(higher,peakData) endif peakpercent=(higher-peakData)/higher newpeak=peakpercent>percent/100 if newpeak and lastdottedline<=0 then lower=peakData lastdottedline=1 lastpeak=peakData endif   //Metastock Trough() function once lower=troughData if lastdottedline>=0 then lower=min(lower,troughData) endif troughpercent=(troughData-lower)/lower newtrough=troughpercent>percent/100 if newtrough and lastdottedline>=0 then higher=troughData lastdottedline=-1 lasttrough=troughData endif   atr40=averagetruerange[40] if lastpeak<>lastpeak[1] then peak1=lastpeak peak2=lastpeak-ATR40 endif if lasttrough<>lasttrough[1] then trough1=lasttrough trough2=lasttrough+ATR40 endif endif   return peak1 coloured(0,0,255) style(point,2),peak2 coloured(255,100,0) style(point,2),trough1 coloured(0,0,255) style(point,2),trough2 coloured(255,100,0) style(point,2)

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4775 times
  05/15/2017 at 5:48 PM #35621
  denmar

  Hey Nicolas -fantastic. I’m sorry- I should have been more explicit in the beginning.   I was willing to hack the other half of the code (and still am) once the one half was complete.  I’m going to study this and will let you know soon.  Once again – great,awesome – now just to see if it is doing the right thing.  Merci.

   

  

  denmar

  Participant

  Topics: 14

  Replies: 59

  Been thanked: 4 times
  05/15/2017 at 8:58 PM #35638
  denmar

  Hi Nicolas

  I have had a look a the indicator and it seems to be plotting about four bars “to late” and a little to high. (Although for some strange reason it seem to be a little to low on the chart you posted) For the purposes of comparison I have done the following:

  1. Plotted the upper BB in white (the lower is in blue – ignore)
  2. Drawn the peak lines in white – main as solid and 1ATR in dotted
  3. Drawn the trough lines in yellow – main solid and 1ATr dotted

  By comparing the METASTOCK chart with the PRT one you will notice the discrepancy. I have drawn arrows to indicate more or less where the lines should be if they were correctly plotted.

  Hope this helps.  Thanks once again for your effort to date.  Much appreciated.

  

  denmar

  Participant

  Topics: 14

  Replies: 59

  Been thanked: 4 times
  05/15/2017 at 9:48 PM #35646
  Nicolas

  I think the problem is that the values are correct and found at the right time but not plot in the past like it seems to be in MetaStock. I’ll have a deeper look ASAP.

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4775 times
  05/16/2017 at 7:18 AM #35659
  denmar

  Thanks Nicolas. Much appreciated.

   

  

  denmar

  Participant

  Topics: 14

  Replies: 59

  Been thanked: 4 times
  10/22/2019 at 3:12 PM #110844
  Vincenzo Tavernise

  Nicolas wrote:

  I think the problem is that the values are correct and found at the right time but not plot in the past like it seems to be in MetaStock. I’ll have a deeper look ASAP.

  hello did you get updates on this beautiful indicator?

  

  Vincenzo Tavernise

  Participant

  Topics: 2

  Replies: 6

  Been thanked: 0 times
  10/22/2019 at 3:50 PM #110855
  robertogozzi

  @vincenzo Tavernise

  Please do not double post! Thank you.

  I replied to the other post of yours.

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17286

  Been thanked: 4129 times
  11/27/2019 at 2:43 PM #113735
  denmar

  Hi

  I a revisiting this indicator but wish to replace the bollinger bands with code incorporating linear regression.  However it just plots a value of zero.  I substituted linear regression with the close and it plots just fine. Any help in resolving the code will be greatly appreciated.

  The code posted is with the close  (working). The first three lines need to be modified to substitute linear regression for the close.

  The attached figure depicts:

  TOP: Original code with Bollinger Bands (by Nicolas)

  MIDDLE: LinearRegression (my modification, not working)

  BOTTOM: Close (my modification, working)

  LinearRegression not working

  //LR= LinearRegression[14](Close) a = ExponentialAverage[20](Close) //(LR) StdDeviation = STD[20](Close) //(LR) Bsup = a + 2 * StdDeviation percent = 0.3 peakData=Bsup troughData=Bsup if barindex>20 then //Metastock Peak() function if lastdottedline<=0 then higher=max(higher,peakData) endif peakpercent=(higher-peakData)/higher newpeak=peakpercent>percent/100 if newpeak and lastdottedline<=0 then lower=peakData lastdottedline=1 lastpeak=peakData endif //Metastock Trough() function once lower=troughData if lastdottedline>=0 then lower=min(lower,troughData) endif troughpercent=(troughData-lower)/lower newtrough=troughpercent>percent/100 if newtrough and lastdottedline>=0 then higher=troughData lastdottedline=-1 lasttrough=troughData endif atr40=averagetruerange[40] if lastpeak<>lastpeak[1] then peak1=lastpeak peak2=lastpeak-ATR40 endif if lasttrough<>lasttrough[1] then trough1=lasttrough trough2=lasttrough+ATR40 endif endif return peak1, peak2, trough1, trough2

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47

  //LR= LinearRegression[14](Close) a = ExponentialAverage[20](Close) //(LR) StdDeviation = STD[20](Close)  //(LR) Bsup = a  + 2 * StdDeviation   percent = 0.3 peakData=Bsup troughData=Bsup if barindex>20 then //Metastock Peak() function if lastdottedline<=0 then higher=max(higher,peakData) endif peakpercent=(higher-peakData)/higher newpeak=peakpercent>percent/100 if newpeak and lastdottedline<=0 then lower=peakData lastdottedline=1 lastpeak=peakData endif //Metastock Trough() function once lower=troughData if lastdottedline>=0 then lower=min(lower,troughData) endif troughpercent=(troughData-lower)/lower newtrough=troughpercent>percent/100 if newtrough and lastdottedline>=0 then higher=troughData lastdottedline=-1 lasttrough=troughData endif atr40=averagetruerange[40] if lastpeak<>lastpeak[1] then peak1=lastpeak peak2=lastpeak-ATR40 endif if lasttrough<>lasttrough[1] then trough1=lasttrough trough2=lasttrough+ATR40 endif endif return peak1, peak2, trough1, trough2

   

   

  

  denmar

  Participant

  Topics: 14

  Replies: 59

  Been thanked: 4 times
• Author
  Posts