PRC williams' high and low indicator

• 05/19/2018 at 8:27 AM #70827
  Gianluca

  Hi everyone, i found this indicator on the PRC forum, i see that it have too many false signal, except one, the arrow with the radius one, so i would modify the indicator in order to show that only arrow. Unfortunally i don’t know how to do it. There is someone that could help me? @robertogozzi @nicolas ? like this

  indicator

  //computation of the radius to draw ellipses radius=average[200](range)/4 //if golong=1 then //golong=0 //endif //formula to compute short term swing points if (high>alto[1]) and not (high<high[1] and low>low[1]) then alto=high basso=low markup=barindex markhigh=high endif if (low<basso[1]) and not (high<high[1] and low>low[1]) then alto=high basso=low markdown=barindex marklow=low endif if alto<alto[1] and trend=1 then trend=0 drawarrowdown(markup,markhigh) mediummarkup=shortmarkup shortmarkup=markup longmarkhigh=mediummarkhigh mediummarkhigh=shortmarkhigh shortmarkhigh=markhigh //intermediate high swing points if longmarkhigh<mediummarkhigh and mediummarkhigh>shortmarkhigh then DRAWELLIPSE(mediummarkup-1, mediummarkhigh-radius, mediummarkup+1, mediummarkhigh+radius) endif endif if basso>basso[1] and trend=0 then trend=1 drawarrowup(markdown,marklow) mediummarkdown=shortmarkdown shortmarkdown=markdown longmarklow=mediummarklow mediummarklow=shortmarklow shortmarklow=marklow //intermediate low swing points if longmarklow>mediummarklow and mediummarklow<shortmarklow then DRAWELLIPSE(mediummarkdown-1, mediummarklow-radius, mediummarkdown+1, mediummarklow+radius) endif endif drawcandle(open,high,low,close) return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50

  //computation of the radius to draw ellipses radius=average[200](range)/4 //if golong=1 then //golong=0 //endif //formula to compute short term swing points if (high>alto[1]) and not (high<high[1] and low>low[1]) then alto=high basso=low markup=barindex markhigh=high endif if (low<basso[1]) and not (high<high[1] and low>low[1]) then alto=high basso=low markdown=barindex marklow=low endif   if alto<alto[1] and trend=1 then trend=0 drawarrowdown(markup,markhigh) mediummarkup=shortmarkup shortmarkup=markup longmarkhigh=mediummarkhigh mediummarkhigh=shortmarkhigh shortmarkhigh=markhigh //intermediate high swing points if longmarkhigh<mediummarkhigh and mediummarkhigh>shortmarkhigh then DRAWELLIPSE(mediummarkup-1, mediummarkhigh-radius, mediummarkup+1, mediummarkhigh+radius) endif endif   if basso>basso[1] and trend=0 then trend=1 drawarrowup(markdown,marklow) mediummarkdown=shortmarkdown shortmarkdown=markdown longmarklow=mediummarklow mediummarklow=shortmarklow shortmarklow=marklow //intermediate low swing points if longmarklow>mediummarklow and mediummarklow<shortmarklow then DRAWELLIPSE(mediummarkdown-1, mediummarklow-radius, mediummarkdown+1, mediummarklow+radius) endif endif     drawcandle(open,high,low,close) return

   

  

  Gianluca

  Participant

  Topics: 64

  Replies: 417

  Been thanked: 55 times
  05/19/2018 at 9:18 AM #70832
  robertogozzi

  It’s a bit easier to select the good ones AFTER they have been displayed. The hardest part is knowing BEFORE how to prevent false future arrows/signals from being shown.

  To know what to do you have to tell us:

  1. instrument used
  2. timeframe used
  3. what makes the black arrows you circled different from the other unmarked ones

  in order to test it and try to make it work as you like (well… don’t take it for granted!).

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17150

  Been thanked: 4040 times
  05/19/2018 at 12:20 PM #70866
  Gianluca

  robertogozzi wrote:

  It’s a bit easier to select the good ones AFTER they have been displayed. The hardest part is knowing BEFORE how to prevent false future arrows/signals from being shown.

  To know what to do you have to tell us:

  1. instrument used
  2. timeframe used
  3. what makes the black arrows you circled different from the other unmarked ones

  in order to test it and try to make it work as you like (well… don’t take it for granted!).

  That was my request, i don’t know how the Indicator made that circle difference from the other.

  

  Gianluca

  Participant

  Topics: 64

  Replies: 417

  Been thanked: 55 times
  05/19/2018 at 2:17 PM #70882
  robertogozzi

  Sorry for being so stupid…. I answered you post without even reading the code!!!

  I thought YOU had drawn those circles around some arrows, how silly!!!

  Sorry, again; if (NOW) I correctly understood what you mean that is the code:

  DEFPARAM CalculateOnLastBars = 1000 //computation of the radius to draw ellipses //radius=average[200](range)/4 //if golong=1 then //golong=0 //endif //formula to compute short term swing points if (high>alto[1]) and not (high<high[1] and low>low[1]) then alto=high basso=low markup=barindex markhigh=high endif if (low<basso[1]) and not (high<high[1] and low>low[1]) then alto=high basso=low markdown=barindex marklow=low endif if alto<alto[1] and trend=1 then trend=0 //drawarrowdown(markup,markhigh) mediummarkup=shortmarkup shortmarkup=markup longmarkhigh=mediummarkhigh mediummarkhigh=shortmarkhigh shortmarkhigh=markhigh //intermediate high swing points if longmarkhigh<mediummarkhigh and mediummarkhigh>shortmarkhigh then //DRAWELLIPSE(mediummarkup-1, mediummarkhigh-radius, mediummarkup+1, mediummarkhigh+radius) drawarrowdown(mediummarkup,markhigh+10) endif endif if basso>basso[1] and trend=0 then trend=1 //drawarrowup(markdown,marklow) mediummarkdown=shortmarkdown shortmarkdown=markdown longmarklow=mediummarklow mediummarklow=shortmarklow shortmarklow=marklow //intermediate low swing points if longmarklow>mediummarklow and mediummarklow<shortmarklow then //DRAWELLIPSE(mediummarkdown-1, mediummarklow-radius, mediummarkdown+1, mediummarklow+radius) drawarrowup(mediummarkdown,marklow-20) endif endif drawcandle(open,high,low,close) return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53

  DEFPARAM CalculateOnLastBars = 1000 //computation of the radius to draw ellipses //radius=average[200](range)/4 //if golong=1 then //golong=0 //endif //formula to compute short term swing points if (high>alto[1]) and not (high<high[1] and low>low[1]) then alto=high basso=low markup=barindex markhigh=high endif if (low<basso[1]) and not (high<high[1] and low>low[1]) then alto=high basso=low markdown=barindex marklow=low endif if alto<alto[1] and trend=1 then trend=0 //drawarrowdown(markup,markhigh) mediummarkup=shortmarkup shortmarkup=markup longmarkhigh=mediummarkhigh mediummarkhigh=shortmarkhigh shortmarkhigh=markhigh //intermediate high swing points if longmarkhigh<mediummarkhigh and mediummarkhigh>shortmarkhigh then //DRAWELLIPSE(mediummarkup-1, mediummarkhigh-radius, mediummarkup+1, mediummarkhigh+radius) drawarrowdown(mediummarkup,markhigh+10) endif endif if basso>basso[1] and trend=0 then trend=1 //drawarrowup(markdown,marklow) mediummarkdown=shortmarkdown shortmarkdown=markdown longmarklow=mediummarklow mediummarklow=shortmarklow shortmarklow=marklow //intermediate low swing points if longmarklow>mediummarklow and mediummarklow<shortmarklow then //DRAWELLIPSE(mediummarkdown-1, mediummarklow-radius, mediummarkdown+1, mediummarklow+radius) drawarrowup(mediummarkdown,marklow-20) endif endif drawcandle(open,high,low,close) return

  If you want to put it on the price, rather than below, you may (not mandatory) comment the second last line (DRAWCANDLE).

  The attached pic shows the difference between the two versions.

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17150

  Been thanked: 4040 times
  05/19/2018 at 10:12 PM #70910
  Gianluca

  robertogozzi wrote:

  Sorry for being so stupid…. I answered you post without even reading the code!!!

  I thought YOU had drawn those circles around some arrows, how silly!!!

  Sorry, again; if (NOW) I correctly understood what you mean that is the code:

  DEFPARAM CalculateOnLastBars = 1000<br /><br /> //computation of the radius to draw ellipses<br /><br /> //radius=average[200](range)/4<br /><br /> //if golong=1 then<br /><br /> //golong=0<br /><br /> //endif<br /><br /> //formula to compute short term swing points<br /><br /> if (high>alto[1]) and not (high<high[1] and low>low[1]) then<br /><br /> alto=high<br /><br /> basso=low<br /><br /> markup=barindex<br /><br /> markhigh=high<br /><br /> endif<br /><br /> if (low<basso[1]) and not (high<high[1] and low>low[1]) then<br /><br /> alto=high<br /><br /> basso=low<br /><br /> markdown=barindex<br /><br /> marklow=low<br /><br /> endif</p><br /> <p>if alto<alto[1] and trend=1 then<br /><br /> trend=0<br /><br /> //drawarrowdown(markup,markhigh)<br /><br /> mediummarkup=shortmarkup<br /><br /> shortmarkup=markup<br /><br /> longmarkhigh=mediummarkhigh<br /><br /> mediummarkhigh=shortmarkhigh<br /><br /> shortmarkhigh=markhigh<br /><br /> //intermediate high swing points<br /><br /> if longmarkhigh<mediummarkhigh and mediummarkhigh>shortmarkhigh then<br /><br /> //DRAWELLIPSE(mediummarkup-1, mediummarkhigh-radius, mediummarkup+1, mediummarkhigh+radius)<br /><br /> drawarrowdown(mediummarkup,markhigh+10)<br /><br /> endif<br /><br /> endif</p><br /> <p>if basso>basso[1] and trend=0 then<br /><br /> trend=1<br /><br /> //drawarrowup(markdown,marklow)<br /><br /> mediummarkdown=shortmarkdown<br /><br /> shortmarkdown=markdown<br /><br /> longmarklow=mediummarklow<br /><br /> mediummarklow=shortmarklow<br /><br /> shortmarklow=marklow<br /><br /> //intermediate low swing points<br /><br /> if longmarklow>mediummarklow and mediummarklow<shortmarklow then<br /><br /> //DRAWELLIPSE(mediummarkdown-1, mediummarklow-radius, mediummarkdown+1, mediummarklow+radius)<br /><br /> drawarrowup(mediummarkdown,marklow-20)<br /><br /> endif<br /><br /> endif</p><br /> <p>drawcandle(open,high,low,close)<br /><br /> return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53

  DEFPARAM CalculateOnLastBars = 1000 //computation of the radius to draw ellipses //radius=average[200](range)/4 //if golong=1 then //golong=0 //endif //formula to compute short term swing points if (high>alto[1]) and not (high<high[1] and low>low[1]) then alto=high basso=low markup=barindex markhigh=high endif if (low<basso[1]) and not (high<high[1] and low>low[1]) then alto=high basso=low markdown=barindex marklow=low endif if alto<alto[1] and trend=1 then trend=0 //drawarrowdown(markup,markhigh) mediummarkup=shortmarkup shortmarkup=markup longmarkhigh=mediummarkhigh mediummarkhigh=shortmarkhigh shortmarkhigh=markhigh //intermediate high swing points if longmarkhigh<mediummarkhigh and mediummarkhigh>shortmarkhigh then //DRAWELLIPSE(mediummarkup-1, mediummarkhigh-radius, mediummarkup+1, mediummarkhigh+radius) drawarrowdown(mediummarkup,markhigh+10) endif endif if basso>basso[1] and trend=0 then trend=1 //drawarrowup(markdown,marklow) mediummarkdown=shortmarkdown shortmarkdown=markdown longmarklow=mediummarklow mediummarklow=shortmarklow shortmarklow=marklow //intermediate low swing points if longmarklow>mediummarklow and mediummarklow<shortmarklow then //DRAWELLIPSE(mediummarkdown-1, mediummarklow-radius, mediummarkdown+1, mediummarklow+radius) drawarrowup(mediummarkdown,marklow–20) endif endif drawcandle(open,high,low,close) return

  If you want to put it on the price, rather than below, you may (not mandatory) comment the second last line (DRAWCANDLE).

  The attached pic shows the difference between the two versions.

  WONDERFULL!!!!!

   

  

  Gianluca

  Participant

  Topics: 64

  Replies: 417

  Been thanked: 55 times
  05/20/2018 at 5:57 PM #70959
  Gianluca

  robertogozzi wrote:

  It’s a bit easier to select the good ones AFTER they have been displayed. The hardest part is knowing BEFORE how to prevent false future arrows/signals from being shown.

  To know what to do you have to tell us:

  1. instrument used
  2. timeframe used
  3. what makes the black arrows you circled different from the other unmarked ones

  in order to test it and try to make it work as you like (well… don’t take it for granted!).

  And would be possible to change that indicator in an Histogram indicator +1 -1 ? like this?

  

  Gianluca

  Participant

  Topics: 64

  Replies: 417

  Been thanked: 55 times
  05/21/2018 at 12:18 AM #70979
  robertogozzi

  Sorry, but it is not possible, because Arrows are sometimes drawn in the past, while a histogram can only be drawn on the current bar.

  But you can put the indicator below the price, like RSI or MACD and comment out the second last line where you read DRAWCANDLE; it won’t display histograms, but arrows and you can also color them the way you like.

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17150

  Been thanked: 4040 times
  05/21/2018 at 12:38 AM #70981
  Ste

  Roberto sorry, so isn’t possible to make a simple but/sell strategy when you set arrows? I tried but I was not able..

  

  Ste

  Participant

  Topics: 1

  Replies: 13

  Been thanked: 1 time
  05/21/2018 at 8:45 AM #70989
  robertogozzi

  I am just trying to debug it, I’ll let you know.

  2 users thanked author for this post.

  Gianluca, Ste

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17150

  Been thanked: 4040 times
  05/21/2018 at 10:27 AM #70995
  Ste

  maybe this link can help

  https://www.prorealcode.com/topic/williams-indicator/

  

  Ste

  Participant

  Topics: 1

  Replies: 13

  Been thanked: 1 time
  05/21/2018 at 12:31 PM #71002
  robertogozzi

  The code should be extremely easy to convert to a HISTOGRAM, when it draws an Arrow + Ellipse I can se a value to be returned by the indicator, 1 for Bullish candles and -1 for Bearish candles and I attach te code for those who want to investigate more, but as from attached pic, histogram bars are NOT displayed when ane arrow+ellispe is on the price!

  And I cannot guess why.

  DEFPARAM CalculateOnLastBars = 300 x = 0 //computation of the radius to draw ellipses radius=average[200](range)/4 //if golong=1 then //golong=0 //endif //formula to compute short term swing points if (high>alto[1]) and not (high<high[1] and low>low[1]) then alto=high basso=low markup=barindex markhigh=high endif if (low<basso[1]) and not (high<high[1] and low>low[1]) then alto=high basso=low markdown=barindex marklow=low endif if alto<alto[1] and trend=1 then trend=0 drawarrowdown(markup,markhigh) mediummarkup=shortmarkup shortmarkup=markup longmarkhigh=mediummarkhigh mediummarkhigh=shortmarkhigh shortmarkhigh=markhigh //intermediate high swing points if longmarkhigh<mediummarkhigh and mediummarkhigh>shortmarkhigh then DRAWELLIPSE(mediummarkup-1, mediummarkhigh-radius, mediummarkup+1, mediummarkhigh+radius) //drawarrowdown(markup,markhigh) x = -1 endif endif if basso>basso[1] and trend=0 then trend=1 drawarrowup(markdown,marklow) mediummarkdown=shortmarkdown shortmarkdown=markdown longmarklow=mediummarklow mediummarklow=shortmarklow shortmarklow=marklow //intermediate low swing points if longmarklow>mediummarklow and mediummarklow<shortmarklow then DRAWELLIPSE(mediummarkdown-1, mediummarklow-radius, mediummarkdown+1, mediummarklow+radius) //drawarrowup(markdown,marklow) x = 1 endif endif //drawcandle(open,high,low,close) return x, 0

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56

  DEFPARAM CalculateOnLastBars = 300 x = 0 //computation of the radius to draw ellipses radius=average[200](range)/4 //if golong=1 then //golong=0 //endif //formula to compute short term swing points if (high>alto[1]) and not (high<high[1] and low>low[1]) then alto=high basso=low markup=barindex markhigh=high endif if (low<basso[1]) and not (high<high[1] and low>low[1]) then alto=high basso=low markdown=barindex marklow=low endif if alto<alto[1] and trend=1 then trend=0 drawarrowdown(markup,markhigh) mediummarkup=shortmarkup shortmarkup=markup longmarkhigh=mediummarkhigh mediummarkhigh=shortmarkhigh shortmarkhigh=markhigh //intermediate high swing points if longmarkhigh<mediummarkhigh and mediummarkhigh>shortmarkhigh then DRAWELLIPSE(mediummarkup-1, mediummarkhigh-radius, mediummarkup+1, mediummarkhigh+radius) //drawarrowdown(markup,markhigh) x = -1 endif endif if basso>basso[1] and trend=0 then trend=1 drawarrowup(markdown,marklow) mediummarkdown=shortmarkdown shortmarkdown=markdown longmarklow=mediummarklow mediummarklow=shortmarklow shortmarklow=marklow //intermediate low swing points if longmarklow>mediummarklow and mediummarklow<shortmarklow then DRAWELLIPSE(mediummarkdown-1, mediummarklow-radius, mediummarkdown+1, mediummarklow+radius) //drawarrowup(markdown,marklow) x = 1 endif endif //drawcandle(open,high,low,close) return x, 0

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17150

  Been thanked: 4040 times
  05/21/2018 at 12:47 PM #71008
  Gianluca

  robertogozzi wrote:

  The code should be extremely easy to convert to a HISTOGRAM, when it draws an Arrow + Ellipse I can se a value to be returned by the indicator, 1 for Bullish candles and -1 for Bearish candles and I attach te code for those who want to investigate more, but as from attached pic, histogram bars are NOT displayed when ane arrow+ellispe is on the price!

  And I cannot guess why.

  i know, i had the same problem too, and also there is a graphic bug with your firs modify to the indicator, like here :

  

  Gianluca

  Participant

  Topics: 64

  Replies: 417

  Been thanked: 55 times
  05/21/2018 at 12:54 PM #71011
  Ste

  The same for me, maybe @Nicolas could help us.

  Thanks a lot Roberto.

  

  Ste

  Participant

  Topics: 1

  Replies: 13

  Been thanked: 1 time
  05/21/2018 at 8:05 PM #71032
  Gianluca

  I think that we can take out something good from this.

  

  Gianluca

  Participant

  Topics: 64

  Replies: 417

  Been thanked: 55 times
  05/21/2018 at 11:00 PM #71037
  Gianluca

  robertogozzi wrote:

  Sorry for being so stupid…. I answered you post without even reading the code!!!

  I thought YOU had drawn those circles around some arrows, how silly!!!

  Sorry, again; if (NOW) I correctly understood what you mean that is the code:

  @roberto sorry for bother you again… do you think would be possible to make a scanner from this?

  

  Gianluca

  Participant

  Topics: 64

  Replies: 417

  Been thanked: 55 times
• Author
  Posts