Rewrite SwingTeller code from binck ProTrader to Prorealtime code

joerie1 · Fri, 24 Mar 2017 11:44:41 +0000

Dear Prorealtime members, Is there someone who can change this code of a different banksystem (protrader binq) to a prorealtime code. {- Filename: dynamische RSI -} var RSIPeriode: integer; // parameterwaarde StdDevUp, StdDevDown: real; BolBandPeriode: integer; i: integer; RSIValues, TARValues, UpperBand, LowerBand: TSeries; UpperCrossings, LowerCrossings: TLineCrossings; begin // Indicator parameter definities RSIPeriode := CreateParameterInteger('RSI periode', 1, 999, 7, true); BolBandPeriode := CreateParameterInteger('Boll. MA periode', 1, 999, 50, true); StdDevUp := CreateParameterReal('StdDevUp', 1, 9, 2, true); StdDevDown := CreateParameterReal('StdDevDown', 1, 9, 2, true); // Indicator definitie with Indicator do begin RequiredBars := 5*RSIPeriode + BolBandPeriode; end; // Indicatorberekening RSIValues := RSI(Close, RSIPeriode); UpperBand := BollingerBand(RSIValues, BolBandPeriode, maSimple, StdDevUp); LowerBand := BollingerBand(RSIValues, BolBandPeriode, maSimple, -StdDevDown); TARValues := CreateSeries(BarCount); // signalen berekenen UpperCrossings := Crossings(RSIValues, UpperBand); LowerCrossings := Crossings(RSIValues, LowerBand); for i:=1 to BarCount-1 do begin { RSI crosses over OB lijn = OB entry (signal) RSI > OB lijn = OB (condition) RSI crosses under OB = OB Exit (signal) RSI between OB en OS = Neutral (condition) RSI crosses under OS lijn = OS entry (signal) RSI < OS lijn = OS (condition) RSI crosses over OS = OS Exit (signal) RSI between OB en OS = Neutral (condition) } TARValues[i] := TARValues[i-1]; if UpperCrossings[i] = lc1Over2 then begin EnterShort(i); TARValues[i] := 1; end else if UpperCrossings[i] = lc2Over1 then begin ExitShort(i); TARValues[i] := 0; end else if LowerCrossings[i] = lc2Over1 then begin EnterLong(i); TARValues[i] := -1; end else if LowerCrossings[i] = lc1Over2 then begin ExitLong(i); TARValues[i] := 0; end; end; with CreateLine(RSIValues) do begin Color := clLime; Name := 'RSI'; end; with CreateLine(UpperBand) do begin Color := clSilver; Name := 'OB'; end; with CreateLine(LowerBand) do begin Color := clSilver; Name := 'OS'; end; with CreateLine(TARValues) do begin Color := clWhite; Name := 'TAR'; LineContent := lcTAR; Visible := false; end; end. I hope someone can help me with this

This topic has 66 replies, 6 voices, and was last updated 7 years ago by AVT.

Viewing 15 posts - 16 through 30 (of 67 total)

← 1 2 3 4 5 →

04/04/2017 at 3:34 PM #31009

JohnVS

hi Nicolas,

Okay cant wait for the new version 🙂

rgds

John

JohnVS
Participant

Topics: 3
Replies: 30
Been thanked: 0 times

04/04/2017 at 3:44 PM #31010

JohnVS

Okay,

Curious about the next version 🙂

rgds

Jogn

JohnVS
Participant

Topics: 3
Replies: 30
Been thanked: 0 times

04/04/2017 at 6:35 PM #31025

Nicolas

The code is already attached in my previous post as an ITF file, please import it into your platform and make some tests! 🙂

Nicolas
Keymaster

Topics: 81
Replies: 20863
Been thanked: 4773 times

04/04/2017 at 9:06 PM #31040

JohnVS

Hi Nicolas,

Again a little step closer 🙂

I have send you a file with some comments.

Hope it helps.

rgds

John

At the lowest arrow it doesnt start at the correct bar. The close of that bar is not higher then the 4th before that. It looks like normally a downswing should start.The correct place should be where now the 2.0 starts since there the closing price is higher then the closing price of 4th bar before that

The high arrow shows the start of the downswing which should have started at 3.0 cause thats the First time closing price was lower then the 4th bar before that.

Also after that downswing a new downswing should start after the resting dayafter 9.0

Hope it makes a little sense J

Rgds John

JohnVS
Participant

Topics: 3
Replies: 30
Been thanked: 0 times

04/04/2017 at 9:31 PM #31045

joerie1

Heyy,

You guys are awesome! Thanks a lot.

How do i get this indicator on the chart instead of below the chart?

joerie1
Participant

Topics: 2
Replies: 14
Been thanked: 0 times

04/04/2017 at 9:49 PM #31049

JohnVS

Hey Joeri,

Download the itf file Nicolas provided

Add a new indicator and import the itf file

Good luck 🙂

rgds

John

JohnVS
Participant

Topics: 3
Replies: 30
Been thanked: 0 times

04/04/2017 at 9:53 PM #31050

joerie1

Yess I did but it looks like this now.

I have a picture attached to this message!

joerie1
Participant

Topics: 2
Replies: 14
Been thanked: 0 times

04/04/2017 at 11:14 PM #31062

JohnVS

Joerie,

Once you imported it you must click on the tools icon in de “koers” graphic and add the indicator there

Its called the PRC_swingteller

Hope it works now

rgds

John

JohnVS
Participant

Topics: 3
Replies: 30
Been thanked: 0 times

04/05/2017 at 8:46 AM #31072

Nicolas

@JohnVS

Please upload pictures and comments in forums instead of attached file, you know it can save me some time! Thank you..

I think you didn’t read my last comment:

Nicolas wrote:

About the Close superior or inferior to the one 4 bars earlier, it is not how it is coded in the original code posted by joerie1, it is looking for the current Close to be superior to highest one of the last 3 bars (up swing) and vice versa for the down swing, but I modified as per your suggestion..

So now you want it to reverse it back to the original code?

Nicolas
Keymaster

Topics: 81
Replies: 20863
Been thanked: 4773 times

04/05/2017 at 10:11 AM #31088

JohnVS

Hi nicolas,

I have no idea how else to upload a file ? i cant copy it in here

It should not look at the higest of the last 3 bars, it should “compare” the closing prices of the current day and the 4 bars earlier.

If the price of the current bar is higher then the 4 bars earlier then it should start

For the downswing the same ofcource

Hope that helps

rgds

John

JohnVS
Participant

Topics: 3
Replies: 30
Been thanked: 0 times

04/05/2017 at 10:42 AM #31093

JohnVS

Hi Nicolas,

In the picture you see an arrow. The swing starts there but thas the wrong point.

It should start where now the 2.0 is. because that is the first one being higher then the bar 4 days ago.

The counting should continue if the next bar is again higher then the 4 bars before that 1, etc.

We will bust this i hope because we are very close 🙂

rgds

John

JohnVS
Participant

Topics: 3
Replies: 30
Been thanked: 0 times

04/05/2017 at 12:31 PM #31108

Nicolas

Upload pictures instead of Word document …. PLEASE!

Nicolas
Keymaster

Topics: 81
Replies: 20863
Been thanked: 4773 times

04/05/2017 at 12:42 PM #31110

Nicolas

PFA modified version. The counting was OK but my loop to draw the text was starting one bar previous the 9 count.

Nicolas
Keymaster

Topics: 81
Replies: 20863
Been thanked: 4773 times

04/05/2017 at 12:43 PM #31113

JohnVS

Okay,

hope this is better then 🙂

but did you see the pics and comments, ss it clear for you now what the intention is?

hope so

rgds

John

JohnVS
Participant

Topics: 3
Replies: 30
Been thanked: 0 times

04/05/2017 at 1:28 PM #31120

JohnVS

Hey Nicolas,

Yes ! Awesome its working !!

Question : it only plots the swing when its complete right? Think you said you was gonna work on that when the counting was correct?

Also the digit 1.0 2.0 .. etc showing is still in progess i assume

would also be awesome if you could put the number in a square like in the original picture was shown

It would make the swingstart stand out more. If not no problem i think its great already 🙂

You are brilliant thats for sure, and many thanks for your patience 🙂

rgds

John

JohnVS
Participant

Topics: 3
Replies: 30
Been thanked: 0 times
Author

Posts

Viewing 15 posts - 16 through 30 (of 67 total)

← 1 2 3 4 5 →

Find exclusive trading pro-tools on