Seasonality curve not working

• 06/28/2021 at 6:50 PM #172677
  snucke

  The seasonality curve built by Vonasi is not working anymore  https://www.prorealcode.com/prorealtime-indicators/seasonality-curve/

  on some instruments it only plots one or two months and on most of them notihing..

  it worked fine a couple of months ago and all of a sudden it stoped working.

  my only guess is that a command or something used in the code has changed from prorealtime in a update?

   

  is anyone able to spot the error?

   

  //Seasonality Curve //By Vonasi //Date: 20200326 defparam drawonlastbaronly = true //StartDate = 19950101 //Set to zero to analyse all of history //EndDate = 20200101 //Set to zero to analyse all of history //HighAndLow = 1 //switch on and off drawing of high and low points //Percentage = 1 //switch on or off calcualtion based on percentage of price if enddate <= 0 or enddate < startdate then enddate = 99999999 endif if barindex > 0 and opendate >= startdate and opendate <= enddate then if percentage then diff = (((close - close[1])/close[1])*100) else diff = close - close[1] endif mydate = date - (floor(date/10000)*10000) $total[mydate] = $total[mydate] + diff endif if islastbarupdate then if barindex > 365 then mymonth = 100 myday = 1 thisdate = mymonth + myday lastsegment = 0 drawtext("Jan",barindex - 365,0,SansSerif,Bold,12)coloured(0,0,255) a = 365 for b = 1 to 365 mybar = barindex - a if isset($total[thisdate]) then drawsegment(mybar,lastsegment,mybar+1,lastsegment + $total[thisdate]) lastsegment = lastsegment + $total[thisdate] a = a - 1 endif if myday = 31 then mymonth = mymonth + 100 myday = 0 if mymonth = 200 then drawtext("Feb",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 300 then drawtext("Mar",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 400 then drawtext("Apr",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 500 then drawtext("May",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 600 then drawtext("Jun",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 700 then drawtext("Jul",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 800 then drawtext("Aug",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 900 then drawtext("Sep",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 1000 then drawtext("Oct",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 1100 then drawtext("Nov",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 1200 then drawtext("Dec",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif endif myday = myday + 1 thisdate = mymonth + myday mymax = max(lastsegment,mymax) once mymin = lastsegment once mymax = lastsegment mymin = min(lastsegment,mymin) if mymax = lastsegment then maxval = lastsegment maxbar = mybar endif if mymin = lastsegment then minval = lastsegment minbar = mybar endif next if HighAndLow then drawpoint(maxbar+1,maxval,3)coloured(128,0,0) drawpoint(minbar+1,minval,3)coloured(0,128,0) endif endif endif return mymax coloured(0,0,0,0), mymin coloured(0,0,0,0)

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108

  //Seasonality Curve //By Vonasi //Date: 20200326 defparam drawonlastbaronly = true //StartDate = 19950101 //Set to zero to analyse all of history //EndDate = 20200101 //Set to zero to analyse all of history //HighAndLow = 1 //switch on and off drawing of high and low points //Percentage = 1 //switch on or off calcualtion based on percentage of price if enddate <= 0 or enddate < startdate then enddate = 99999999 endif if barindex > 0 and opendate >= startdate and opendate <= enddate then if percentage then diff = (((close - close[1])/close[1])*100) else diff = close - close[1] endif mydate = date - (floor(date/10000)*10000) $total[mydate] = $total[mydate] + diff endif if islastbarupdate then if barindex > 365 then mymonth = 100 myday = 1 thisdate = mymonth + myday lastsegment = 0 drawtext("Jan",barindex - 365,0,SansSerif,Bold,12)coloured(0,0,255) a = 365 for b =  1 to 365 mybar = barindex - a if isset($total[thisdate]) then drawsegment(mybar,lastsegment,mybar+1,lastsegment + $total[thisdate]) lastsegment = lastsegment + $total[thisdate] a = a - 1 endif if myday = 31 then mymonth = mymonth + 100 myday = 0 if mymonth = 200 then drawtext("Feb",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 300 then drawtext("Mar",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 400 then drawtext("Apr",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 500 then drawtext("May",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 600 then drawtext("Jun",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 700 then drawtext("Jul",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 800 then drawtext("Aug",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 900 then drawtext("Sep",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 1000 then drawtext("Oct",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 1100 then drawtext("Nov",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif if mymonth = 1200 then drawtext("Dec",mybar,lastsegment - $total[thisdate],SansSerif,Bold,12)coloured(0,0,255) endif endif myday = myday + 1 thisdate = mymonth + myday mymax = max(lastsegment,mymax) once mymin = lastsegment once mymax = lastsegment mymin = min(lastsegment,mymin) if mymax = lastsegment then maxval = lastsegment maxbar = mybar endif if mymin = lastsegment then minval = lastsegment minbar = mybar endif next if HighAndLow then drawpoint(maxbar+1,maxval,3)coloured(128,0,0) drawpoint(minbar+1,minval,3)coloured(0,128,0) endif endif endif return mymax coloured(0,0,0,0), mymin coloured(0,0,0,0)

   

   

  

  snucke

  Participant

  Topics: 9

  Replies: 143

  Been thanked: 21 times
  08/13/2021 at 11:02 AM #175229
  snucke

  robertogozzi or Nicolas have any idea how to solve this?

  since Vonasi did not have the time to take a look at this maybe you guys have an idea? 🙂

  

  snucke

  Participant

  Topics: 9

  Replies: 143

  Been thanked: 21 times
  08/14/2021 at 10:19 AM #175298
  robertogozzi

  I added the indicator to my chart and it actually works differently and does not plot data for NOV and DEC.
  It’s more difficult for me to modify an exixting code, so I will try to make a new one as soon as I have some time.

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17151

  Been thanked: 4040 times
  08/14/2021 at 1:26 PM #175332
  snucke

  Thank you! this indicator has given me alot, and im very sad it stopped working, so if you could fix it i would be very happy 🙂

  yes it is very weird indeed, on some instruments it only plots the text JAN and nothing else.

  

  snucke

  Participant

  Topics: 9

  Replies: 143

  Been thanked: 21 times
  08/14/2021 at 1:48 PM #175337
  JC_Bywan

  To prevent undefined values messing up calculations, you can replace line 25:

  $total[mydate] = $total[mydate] + diff

  1	$total[mydate] = $total[mydate] + diff

  with:

  if mydate>LastSet($total) then $total[mydate] = diff else $total[mydate] = $total[mydate] + diff endif

  1 2 3 4 5

  if mydate>LastSet($total) then   $total[mydate] = diff else   $total[mydate] = $total[mydate] + diff endif

   

  

  JC_Bywan

  Moderator

  Topics: 20

  Replies: 2652

  Been thanked: 919 times
  08/15/2021 at 2:53 PM #175390
  snucke

  ok, unfortunately it did not solve the problem JC_bywan

  

  snucke

  Participant

  Topics: 9

  Replies: 143

  Been thanked: 21 times
  08/15/2021 at 3:08 PM #175392
  JC_Bywan

  Hi, ok, it did when I tried it, so I guess there’s more there’s another problem too not always appearing. Could you please give the details of the case still not working for you (asset, timeframe daily? dates used, values for each of the 4 settings, screen capture) so that we try to replicate the same case and find the next issue from there? Thanks

  

  JC_Bywan

  Moderator

  Topics: 20

  Replies: 2652

  Been thanked: 919 times
  08/16/2021 at 8:52 PM #175493
  snucke

  okay, it seems to work now JC_bywan

  i had it set to 0 and 0 to show max time on the instrument as it worked before.

  but now when i set exact dates it seems to work!

  thank you!

  

  snucke

  Participant

  Topics: 9

  Replies: 143

  Been thanked: 21 times
• Author
  Posts