Silly Q exit x points after entry not working

• 05/26/2016 at 9:00 AM #8077
  Nicolas

  Hi Cosmic,

  Please change the line 37 to 45 with this code instead:

  if longonmarket then set stop ploss 40 set target pprofit 25 endif if shortonmarket then set stop ploss 30 set target pprofit 25 endif

  1 2 3 4 5 6 7 8 9

  if longonmarket then set stop ploss 40 set target pprofit 25 endif   if shortonmarket then set stop ploss 30 set target pprofit 25 endif

  To test if it’s ok. In your broker orders list, do you see the takeprofit and stoploss values?

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4774 times
  05/26/2016 at 9:02 AM #8078
  Adolfo

  Sorry Cosmic1, were too late and didn’t test it, my fault… above code is wrong, here you have it, tested:

  DEFPARAM CUMULATEORDERS = FALSE DEFPARAM FLATAFTER = 205500 // One Trade Per Day Once nbTrades = 0 Once tradesPerDay = 1 If Day<>Day[1] then nbTrades = 0 Else If (Not OnMarket[1] and OnMarket) xor (ShortOnMarket[1] and LongOnMarket) xor (LongOnMarket[1] and ShortOnMarket) then nbTrades = nbTrades + 1 Endif Endif If nbTrades < tradesPerDay then //End One Trade Per Day Code cashhigh = highest[180](high) cashlow = lowest[180](low) ENDIF IF NOT LONGONMARKET AND Time > 173000 AND Time <= 193000 THEN //Enter Longs BUY 1 PERPOINT AT cashhigh-5 STOP set stop ploss 40 set target pprofit 25 ENDIF //Enter Shorts IF NOT SHORTONMARKET AND Time > 173000 AND Time <= 193000 THEN SELLSHORT 1 PERPOINT at cashlow+5 STOP set stop ploss 30 set target profit 25 ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38

  DEFPARAM CUMULATEORDERS = FALSE DEFPARAM FLATAFTER = 205500     // One Trade Per Day Once nbTrades = 0 Once tradesPerDay = 1   If Day<>Day[1] then nbTrades = 0 Else If (Not OnMarket[1] and OnMarket) xor (ShortOnMarket[1] and LongOnMarket) xor (LongOnMarket[1] and ShortOnMarket) then nbTrades = nbTrades + 1 Endif Endif   If nbTrades < tradesPerDay then   //End One Trade Per Day Code   cashhigh = highest[180](high) cashlow = lowest[180](low)   ENDIF   IF NOT LONGONMARKET AND Time > 173000 AND Time <= 193000 THEN //Enter Longs BUY 1 PERPOINT AT cashhigh-5 STOP set stop ploss 40 set target pprofit 25 ENDIF   //Enter Shorts IF NOT SHORTONMARKET AND Time > 173000 AND Time <= 193000 THEN SELLSHORT 1 PERPOINT at cashlow+5 STOP set stop ploss 30 set target profit 25 ENDIF

  Cheers

  

  Adolfo

  Participant

  Topics: 15

  Replies: 169

  Been thanked: 24 times
  05/26/2016 at 12:22 PM #8119
  Cosmic1

  Thank you, I think we are nearly there but this latest version now breaks the one trade per day code 🙁

  Separate stops and limits work though 🙂

  

  Cosmic1

  Participant

  Topics: 9

  Replies: 112

  Been thanked: 39 times
  05/26/2016 at 2:22 PM #8133
  Cosmic1

  Actually I can’t see if the separate stops and limits are working as trades are being taken too often…

  

  Cosmic1

  Participant

  Topics: 9

  Replies: 112

  Been thanked: 39 times
  05/26/2016 at 2:52 PM #8150
  Nicolas

  This should fix the one trade per day issue:

  DEFPARAM CUMULATEORDERS = FALSE DEFPARAM FLATAFTER = 205500 // One Trade Per Day Once nbTrades = 0 Once tradesPerDay = 1 If Day<>Day[1] then nbTrades = 0 Else If (Not OnMarket[1] and OnMarket) xor (ShortOnMarket[1] and LongOnMarket) xor (LongOnMarket[1] and ShortOnMarket) then nbTrades = nbTrades + 1 Endif Endif If nbTrades < tradesPerDay then //End One Trade Per Day Code cashhigh = highest[180](high) cashlow = lowest[180](low) IF NOT LONGONMARKET AND Time > 173000 AND Time <= 193000 THEN //Enter Longs BUY 1 PERPOINT AT cashhigh-5 STOP set stop ploss 40 set target pprofit 25 ENDIF //Enter Shorts IF NOT SHORTONMARKET AND Time > 173000 AND Time <= 193000 THEN SELLSHORT 1 PERPOINT at cashlow+5 STOP set stop ploss 30 set target profit 25 ENDIF ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37

  DEFPARAM CUMULATEORDERS = FALSE DEFPARAM FLATAFTER = 205500     // One Trade Per Day Once nbTrades = 0 Once tradesPerDay = 1   If Day<>Day[1] then nbTrades = 0 Else If (Not OnMarket[1] and OnMarket) xor (ShortOnMarket[1] and LongOnMarket) xor (LongOnMarket[1] and ShortOnMarket) then nbTrades = nbTrades + 1 Endif Endif   If nbTrades < tradesPerDay then   //End One Trade Per Day Code   cashhigh = highest[180](high) cashlow = lowest[180](low)   IF NOT LONGONMARKET AND Time > 173000 AND Time <= 193000 THEN //Enter Longs BUY 1 PERPOINT AT cashhigh-5 STOP set stop ploss 40 set target pprofit 25 ENDIF   //Enter Shorts IF NOT SHORTONMARKET AND Time > 173000 AND Time <= 193000 THEN SELLSHORT 1 PERPOINT at cashlow+5 STOP set stop ploss 30 set target profit 25 ENDIF ENDIF

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4774 times
  05/26/2016 at 2:59 PM #8151
  Cosmic1

  Hi, It does and I tried moving the IF’s as you did above but it now doesn’t follow the separate stops and limits. Longs and shorts both get stopped at 20points when using this code.

  DEFPARAM CUMULATEORDERS = FALSE DEFPARAM FLATAFTER = 205500 // One Trade Per Day Once nbTrades = 0 Once tradesPerDay = 1 If Day<>Day[1] then nbTrades = 0 Else If (Not OnMarket[1] and OnMarket) xor (ShortOnMarket[1] and LongOnMarket) xor (LongOnMarket[1] and ShortOnMarket) then nbTrades = nbTrades + 1 Endif Endif If nbTrades < tradesPerDay then //End One Trade Per Day Code cashhigh = highest[180](high) cashlow = lowest[180](low) IF NOT LONGONMARKET AND Time > 173000 AND Time <= 193000 THEN //Enter Longs BUY 1 PERPOINT AT cashhigh-5 STOP set stop ploss 40 set target pprofit 40 ENDIF //Enter Shorts IF NOT SHORTONMARKET AND Time > 173000 AND Time <= 193000 THEN SELLSHORT 1 PERPOINT at cashlow+5 STOP set stop ploss 20 set target pprofit 20 ENDIF ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37

  DEFPARAM CUMULATEORDERS = FALSE DEFPARAM FLATAFTER = 205500     // One Trade Per Day Once nbTrades = 0 Once tradesPerDay = 1   If Day<>Day[1] then nbTrades = 0 Else If (Not OnMarket[1] and OnMarket) xor (ShortOnMarket[1] and LongOnMarket) xor (LongOnMarket[1] and ShortOnMarket) then nbTrades = nbTrades + 1 Endif Endif   If nbTrades < tradesPerDay then   //End One Trade Per Day Code   cashhigh = highest[180](high) cashlow = lowest[180](low)   IF NOT LONGONMARKET AND Time > 173000 AND Time <= 193000 THEN //Enter Longs BUY 1 PERPOINT AT cashhigh-5 STOP set stop ploss 40 set target pprofit 40 ENDIF   //Enter Shorts IF NOT SHORTONMARKET AND Time > 173000 AND Time <= 193000 THEN SELLSHORT 1 PERPOINT at cashlow+5 STOP set stop ploss 20 set target pprofit 20 ENDIF ENDIF

   

  

  Cosmic1

  Participant

  Topics: 9

  Replies: 112

  Been thanked: 39 times
  05/26/2016 at 3:09 PM #8152
  Cosmic1

  I should correct the above to say Longs and shorts both have their stops and limits at 20points when using this code. Thanks for all your help 🙂

  

  Cosmic1

  Participant

  Topics: 9

  Replies: 112

  Been thanked: 39 times
  05/26/2016 at 3:22 PM #8154
  Adolfo

  Could be this ?

  IF Time > 173000 AND Time <= 193000 THEN //Enter Longs IF NOT LONGONMARKET THEN BUY 1 PERPOINT AT cashhigh-5 STOP set stop ploss 40 set target pprofit 40 ENDIF //Enter Shorts IF NOT SHORTONMARKET SELLSHORT 1 PERPOINT at cashlow+5 STOP set stop ploss 20 set target pprofit 20 ENDIF ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16

  IF Time > 173000 AND Time <= 193000 THEN   //Enter Longs IF NOT LONGONMARKET THEN BUY 1 PERPOINT AT cashhigh-5 STOP set stop ploss 40 set target pprofit 40 ENDIF   //Enter Shorts IF NOT SHORTONMARKET SELLSHORT 1 PERPOINT at cashlow+5 STOP set stop ploss 20 set target pprofit 20 ENDIF ENDIF

   

  

  Adolfo

  Participant

  Topics: 15

  Replies: 169

  Been thanked: 24 times
  05/26/2016 at 3:26 PM #8155
  Cosmic1

  Nope still makes no difference 🙁

  

  Cosmic1

  Participant

  Topics: 9

  Replies: 112

  Been thanked: 39 times
  05/26/2016 at 3:37 PM #8158
  Adolfo

  Ok, how about this?

  IF Time > 173000 AND Time <= 193000 THEN //Enter Longs IF NOT LONGONMARKET THEN BUY 1 PERPOINT AT cashhigh-5 STOP stoplong = cashhigh-45*pipsize profitlong = cashhigh+55*pipsize ENDIF //Enter Shorts IF NOT SHORTONMARKET SELLSHORT 1 PERPOINT at cashlow+5 STOP stopshort = cashlow-15*pipsize profitshort = cashlow+25*pipsize ENDIF ENDIF IF NOT ONMARKET THEN stoplong = 0 stopshort = 0 profitlong = 0 profitshort = 0 ENDIF IF LONGONMARKET THEN sell at stoplong stop sell at profitlong limit ENDIF IF SHORTONMARKET THEN exitshort at stopshort stop exitshort at profitshort limit ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30

  IF Time > 173000 AND Time <= 193000 THEN //Enter Longs IF NOT LONGONMARKET THEN BUY 1 PERPOINT AT cashhigh-5 STOP stoplong = cashhigh-45*pipsize profitlong = cashhigh+55*pipsize ENDIF //Enter Shorts IF NOT SHORTONMARKET SELLSHORT 1 PERPOINT at cashlow+5 STOP stopshort = cashlow-15*pipsize profitshort = cashlow+25*pipsize ENDIF ENDIF   IF NOT ONMARKET THEN stoplong = 0 stopshort = 0 profitlong = 0 profitshort = 0 ENDIF IF LONGONMARKET THEN sell at stoplong stop sell at profitlong limit ENDIF   IF SHORTONMARKET THEN exitshort at stopshort stop exitshort at profitshort limit ENDIF

   

  

  Adolfo

  Participant

  Topics: 15

  Replies: 169

  Been thanked: 24 times
  05/26/2016 at 3:57 PM #8161
  Cosmic1

  Thanks again but not working, no stops or limits work at all… All other code works. All trades close at the FLATAFTER time…

  DEFPARAM CUMULATEORDERS = FALSE DEFPARAM FLATAFTER = 205500 //One Trade Per Day Once nbTrades = 0 Once tradesPerDay = 1 If Day<>Day[1] then nbTrades = 0 Else If (Not OnMarket[1] and OnMarket) xor (ShortOnMarket[1] and LongOnMarket) xor (LongOnMarket[1] and ShortOnMarket) then nbTrades = nbTrades + 1 Endif Endif If nbTrades < tradesPerDay then //End One Trade Per Day Code IF Time = 173000 then cashhigh = highest[180](high) cashlow = lowest[180](low) ENDIF IF Time > 173000 AND Time <= 193000 THEN //Enter Longs IF NOT LONGONMARKET THEN BUY 1 PERPOINT AT cashhigh-5 STOP stoplong = cashhigh-40*pipsize profitlong = cashhigh+40*pipsize ENDIF //Enter Shorts IF NOT SHORTONMARKET THEN SELLSHORT 1 PERPOINT at cashlow+5 STOP stopshort = cashlow-20*pipsize profitshort = cashlow+20*pipsize ENDIF ENDIF IF LONGONMARKET THEN sell at stoplong stop sell at profitlong limit ENDIF IF SHORTONMARKET THEN sell at stopshort stop sell at profitshort limit ENDIF IF NOT ONMARKET THEN stoplong = 0 stopshort = 0 profitlong = 0 profitshort = 0 ENDIF ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61

  DEFPARAM CUMULATEORDERS = FALSE DEFPARAM FLATAFTER = 205500     //One Trade Per Day Once nbTrades = 0 Once tradesPerDay = 1   If Day<>Day[1] then nbTrades = 0 Else If (Not OnMarket[1] and OnMarket) xor (ShortOnMarket[1] and LongOnMarket) xor (LongOnMarket[1] and ShortOnMarket) then nbTrades = nbTrades + 1 Endif Endif   If nbTrades < tradesPerDay then   //End One Trade Per Day Code   IF Time = 173000 then   cashhigh = highest[180](high) cashlow = lowest[180](low)   ENDIF   IF Time > 173000 AND Time <= 193000 THEN   //Enter Longs IF NOT LONGONMARKET THEN BUY 1 PERPOINT AT cashhigh-5 STOP stoplong = cashhigh-40*pipsize profitlong = cashhigh+40*pipsize ENDIF   //Enter Shorts IF NOT SHORTONMARKET THEN SELLSHORT 1 PERPOINT at cashlow+5 STOP stopshort = cashlow-20*pipsize profitshort = cashlow+20*pipsize ENDIF ENDIF   IF LONGONMARKET THEN sell at stoplong stop sell at profitlong limit ENDIF   IF SHORTONMARKET THEN sell at stopshort stop sell at profitshort limit ENDIF   IF NOT ONMARKET THEN stoplong = 0 stopshort = 0 profitlong = 0 profitshort = 0 ENDIF ENDIF

   

  

  Cosmic1

  Participant

  Topics: 9

  Replies: 112

  Been thanked: 39 times
• Author
  Posts