SL not working, what am i missing?

• 03/07/2024 at 5:26 PM #229408
  Cellstep

  Hi, I have created this code, however what i see is that the stop loss moves 30 points into profit, but then stays there, it does not move any more until the price hits TP or SL. I want it to continue to move with 30 points intervalls, what am i doing wrong here?

  SL not working

  // Step trailing stop parameters trailingstart = 30 // Trailing will start when in profit by 30 points trailingstep = 30// Trailing step to move the stop loss initialStopLoss = 125 // Initial stop loss in points takeProfit = 250 // Take profit in points // Variable to store the new stop loss level for long and short positions newSLlong = 0 newSLshort = 0 // Trading strategy logic based on the indicator signals IF LongSignal AND Not OnMarket AND not daysForbiddenEntry THEN BUY PositionSize CONTRACT AT MARKET SET STOP pLOSS initialStopLoss SET TARGET pPROFIT takeProfit newSLlong = 0 // Reset the trailing stop level for long positions ENDIF IF ShortSignal AND Not OnMarket AND not daysForbiddenEntry THEN SELLSHORT PositionSize CONTRACT AT MARKET SET STOP pLOSS initialStopLoss SET TARGET pPROFIT takeProfit newSLshort = 0 // Reset the trailing stop level for short positions ENDIF // Manage step trailing stop for long positions IF LONGONMARKET THEN IF newSLlong = 0 AND close - tradeprice(1) >= trailingstart * pipsize THEN newSLlong = tradeprice(1) + trailingstep * pipsize ELSIF newSLlong > 0 AND close - newSLlong >= trailingstep * pipsize THEN newSLlong = newSLlong + trailingstep * pipsize ENDIF IF newSLlong > 0 THEN SELL AT newSLlong STOP ENDIF ENDIF // Manage step trailing stop for short positions IF SHORTONMARKET THEN IF newSLshort = 0 AND tradeprice(1) - close >= trailingstart * pipsize THEN newSLshort = tradeprice(1) - trailingstep * pipsize ELSIF newSLshort > 0 AND newSLshort - close >= trailingstep * pipsize THEN newSLshort = newSLshort - trailingstep * pipsize ENDIF IF newSLshort > 0 THEN EXITSHORT AT newSLshort STOP ENDIF ENDIF

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48

  // Step trailing stop parameters trailingstart = 30 // Trailing will start when in profit by 30 points trailingstep = 30// Trailing step to move the stop loss initialStopLoss = 125 // Initial stop loss in points takeProfit = 250 // Take profit in points   // Variable to store the new stop loss level for long and short positions newSLlong = 0 newSLshort = 0   // Trading strategy logic based on the indicator signals IF LongSignal AND Not OnMarket AND not daysForbiddenEntry THEN BUY PositionSize CONTRACT AT MARKET SET STOP pLOSS initialStopLoss SET TARGET pPROFIT takeProfit newSLlong = 0 // Reset the trailing stop level for long positions ENDIF   IF ShortSignal AND Not OnMarket AND not daysForbiddenEntry THEN SELLSHORT PositionSize CONTRACT AT MARKET SET STOP pLOSS initialStopLoss SET TARGET pPROFIT takeProfit newSLshort = 0 // Reset the trailing stop level for short positions ENDIF   // Manage step trailing stop for long positions IF LONGONMARKET THEN IF newSLlong = 0 AND close - tradeprice(1) >= trailingstart * pipsize THEN newSLlong = tradeprice(1) + trailingstep * pipsize ELSIF newSLlong > 0 AND close - newSLlong >= trailingstep * pipsize THEN newSLlong = newSLlong + trailingstep * pipsize ENDIF IF newSLlong > 0 THEN SELL AT newSLlong STOP ENDIF ENDIF   // Manage step trailing stop for short positions IF SHORTONMARKET THEN IF newSLshort = 0 AND tradeprice(1) - close >= trailingstart * pipsize THEN newSLshort = tradeprice(1) - trailingstep * pipsize ELSIF newSLshort > 0 AND newSLshort - close >= trailingstep * pipsize THEN newSLshort = newSLshort - trailingstep * pipsize ENDIF IF newSLshort > 0 THEN EXITSHORT AT newSLshort STOP ENDIF ENDIF

   

  

  Cellstep

  Participant

  Topics: 1

  Replies: 1

  Been thanked: 0 times
  03/07/2024 at 6:17 PM #229416
  robertogozzi

  Replace lines 8-9 with these ones:

  IF Not OnMarket THEN newSLlong = 0 newSLshort = 0 ENDIF

  1 2 3 4

  IF Not OnMarket THEN    newSLlong = 0    newSLshort = 0 ENDIF

  It’s because you always reset those variables to zero, thus they always restart from scratch every bar, i.e. from 30.

   

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17134

  Been thanked: 4031 times
  03/07/2024 at 6:51 PM #229421
  Cellstep

  Thank you so much for the fast reply! I will implement.

  

  Cellstep

  Participant

  Topics: 1

  Replies: 1

  Been thanked: 0 times
• Author
  Posts