Smaller Timeframe drawline/rectangle issues

• 07/10/2018 at 12:36 PM #75715
  kastin

  Hello, i have a piece of code that i have assembled/Frankensteined, it works well on hourly and above, but when i swap down to lower timeframes something odd happens,

  the problem is with the drawing the lines and rectangle, when i move to a smaller timeframe they either dont draw, or the vertical axis is way out?

  I apologize for the messy code, i am no professional

  A mess

  defparam drawonlastbaronly=true ATRperiod = 20 dTR = 0 for i = 0 to ATRperiod dTR=dTR+max(abs(Dhigh(i)-Dlow(i)),max(abs(Dhigh(i)-Dclose(i+1)),abs(Dlow(i)-Dclose(i+1)))) next avg = dTR/ATRperiod converted = round(avg/pointsize*10)/10 //TimeRange = ( Time < 130100 AND Time > 135959 ) IF time = 150000 THEN begin=BarIndex daysopen = close else //backwards = barindex-begin //daysopen = close[backwards] ENDIF //bindex = IntradayBarIndex bindex = BarIndex IF bindex-begin < 1 THEN Ddhigh = highest[1](high) Ddlow = lowest[1](low) daysopen = close[1] ELSE bsince = (bindex-(begin)) Ddhigh = highest[bsince](high) Ddlow = lowest[bsince](low) daysopen = close[bsince] ENDIF //Ddhigh = highest[bsince](high) htr = Ddlow+avg[1] ltr = Ddhigh-avg[1] bhtr = daysopen+(.3*avg[1]) bltr = daysopen-(.3*avg[1]) //just for calculation of text bounce = (.3*avg[1]) drawsegment(begin,htr,bindex,htr) coloured(200,100,0) drawtext("#htr# - (D1atr: #converted#)",bindex,htr+10*pointsize,Dialog,Bold,10) coloured(200,100,0) drawsegment(begin,ltr,bindex,ltr) coloured(200,100,0) drawtext("#ltr# - (D1atr: #converted#)",bindex,ltr-10*pointsize,Dialog,Bold,10) coloured(200,100,0) drawsegment(begin,bhtr,bindex,bhtr) coloured(255,255,0) drawtext("#bhtr# - (Short openers area: #bounce#)",bindex,bhtr+10*pointsize,Dialog,Bold,15) coloured(200,200,0) // DRAWRECTANGLE (x1, y1, x2, y2) COLOURED (R, V, B, a) DRAWRECTANGLE (begin, daysopen+bounce, bindex, daysopen) coloured(150,150,150) //just to see if BLTR had anumber on smaller tf drawtext("#bltr# - (Long openers area: -#bounce#)",bindex,ddhigh-10*pointsize,Dialog,Bold,15) coloured(200,200,0) drawsegment(begin,bltr,bindex,bltr) coloured(255,255,0) drawtext("#bltr# - (Long openers area: -#bounce#)",bindex,bltr-10*pointsize,Dialog,Bold,15) coloured(200,200,0) drawsegment(begin,daysopen,bindex,daysopen) coloured(0,0,255) drawsegment(begin,ddhigh,bindex,ddhigh) coloured(0,50,0) drawsegment(begin,ddlow,bindex,ddlow) coloured(0,50,0) return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74

  defparam drawonlastbaronly=true ATRperiod = 20   dTR = 0 for i = 0 to ATRperiod dTR=dTR+max(abs(Dhigh(i)-Dlow(i)),max(abs(Dhigh(i)-Dclose(i+1)),abs(Dlow(i)-Dclose(i+1)))) next avg = dTR/ATRperiod converted = round(avg/pointsize*10)/10   //TimeRange = ( Time < 130100 AND Time > 135959 ) IF time = 150000 THEN   begin=BarIndex daysopen = close   else //backwards = barindex-begin //daysopen = close[backwards] ENDIF   //bindex = IntradayBarIndex bindex = BarIndex IF bindex-begin < 1 THEN Ddhigh = highest[1](high) Ddlow = lowest[1](low) daysopen = close[1] ELSE bsince = (bindex-(begin)) Ddhigh = highest[bsince](high) Ddlow = lowest[bsince](low) daysopen = close[bsince] ENDIF   //Ddhigh = highest[bsince](high)   htr = Ddlow+avg[1] ltr = Ddhigh-avg[1]   bhtr = daysopen+(.3*avg[1]) bltr = daysopen-(.3*avg[1])     //just for calculation of text bounce = (.3*avg[1])     drawsegment(begin,htr,bindex,htr) coloured(200,100,0) drawtext("#htr# - (D1atr: #converted#)",bindex,htr+10*pointsize,Dialog,Bold,10) coloured(200,100,0) drawsegment(begin,ltr,bindex,ltr) coloured(200,100,0) drawtext("#ltr# - (D1atr: #converted#)",bindex,ltr-10*pointsize,Dialog,Bold,10) coloured(200,100,0)     drawsegment(begin,bhtr,bindex,bhtr) coloured(255,255,0) drawtext("#bhtr# - (Short openers area: #bounce#)",bindex,bhtr+10*pointsize,Dialog,Bold,15) coloured(200,200,0)     // DRAWRECTANGLE (x1, y1, x2, y2) COLOURED (R, V, B, a) DRAWRECTANGLE (begin, daysopen+bounce, bindex, daysopen) coloured(150,150,150) //just to see if BLTR had anumber on smaller tf drawtext("#bltr# - (Long openers area: -#bounce#)",bindex,ddhigh-10*pointsize,Dialog,Bold,15) coloured(200,200,0)   drawsegment(begin,bltr,bindex,bltr) coloured(255,255,0) drawtext("#bltr# - (Long openers area: -#bounce#)",bindex,bltr-10*pointsize,Dialog,Bold,15) coloured(200,200,0)   drawsegment(begin,daysopen,bindex,daysopen) coloured(0,0,255)   drawsegment(begin,ddhigh,bindex,ddhigh) coloured(0,50,0) drawsegment(begin,ddlow,bindex,ddlow) coloured(0,50,0)   return

   

  

  kastin

  Participant

  Topics: 1

  Replies: 4

  Been thanked: 0 times
  07/10/2018 at 12:48 PM #75721
  Nicolas

  Because Y coordinates are in price format, you have to adapt them (automatically?) in order to get them properly displayed right where you want them to be (close to these lines I guess).

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  07/10/2018 at 1:07 PM #75724
  kastin

  Hi,

  Thanks for your quick reply, can you elaborate a bit i thought they were in price? or know of any example code i can decipher?

  

  kastin

  Participant

  Topics: 1

  Replies: 4

  Been thanked: 0 times
  07/10/2018 at 1:38 PM #75728
  Nicolas

  In this line you are adding text 10 points away from the “bltr” line:

  drawtext("#bltr# - (Long openers area: -#bounce#)",bindex,bltr-10*pointsize,Dialog,Bold,15) coloured(200,200,0)

  1	drawtext("#bltr# - (Long openers area: -#bounce#)",bindex,bltr-10*pointsize,Dialog,Bold,15) coloured(200,200,0)

  While it is close to the line on a larger timeframe, it could be far away on a very small one (or if you zoom in on the chart).

  A rough solution could be to adapt this spread automatically with an indicator value in points, like the ATR for instance:

  atr=averagetruerange[14] drawtext("#bltr# - (Long openers area: -#bounce#)",bindex,bltr-atr/2,Dialog,Bold,15) coloured(200,200,0)

  1 2	atr=averagetruerange[14] drawtext("#bltr# - (Long openers area: -#bounce#)",bindex,bltr-atr/2,Dialog,Bold,15) coloured(200,200,0)

   

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  07/10/2018 at 2:02 PM #75732
  kastin

  Ok i see what you mean,

  but all that did was change the text position on the hourly, it had no effect on smaller timeframes,

  i think the problem lies with not calculating the “daysopen” (the open price at 1600 which is pretty close to close price at 1500) on smaller timeframes.

  How would you normally draw a rectangle that starts at a specific time, then +/- percentage of price?

  

  kastin

  Participant

  Topics: 1

  Replies: 4

  Been thanked: 0 times
  07/10/2018 at 4:23 PM #75741
  Nicolas

  Since you are calculating daily ATR of 20 periods, sufficient bars units are also necessary to compute it correctly. For example, in a 1 minute timeframe, at least 28.800 bars are needed.

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  07/10/2018 at 4:43 PM #75746
  kastin

  Ahhh now we are onto it, that seems to work thanks!,

  i don’t suppose there is an easy way to get past this? rather than loading 10000 bars in a smaller timeframe?

  it seems amibroker AFL is much easier to code with,

  

  kastin

  Participant

  Topics: 1

  Replies: 4

  Been thanked: 0 times
  07/10/2018 at 4:46 PM #75747
  Nicolas

  That’s how it goes since we don’t have any multi timeframe capabilities with ProBuilder. To get higher timeframes OHLC, we must load sufficient data in the current timeframe.

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  07/10/2018 at 5:03 PM #75749
  kastin

  Thankyou for your help 🙂

  

  kastin

  Participant

  Topics: 1

  Replies: 4

  Been thanked: 0 times
• Author
  Posts