Sounds wrong coding, anyone can help pls

• 02/20/2025 at 2:00 AM #244086
  efahmy

  Long Dema Xing ATR-ADX

  // Definition of code parameters DEFPARAM CumulateOrders = TRUE // Cumulating positions deactivated // Var indicator ATX = CALL "PRC_Adaptive-ATR-ADX-Trend-V2"[21, 3.5, 1.75, 14, 30, 0, 1](close) DEM = DEMA[14](close) // Logic if DEM CROSSES OVER ATX then BUY 5 CONTRACTS AT MARKET ENDIF

  1 2 3 4 5 6 7 8 9 10

  // Definition of code parameters DEFPARAM CumulateOrders = TRUE // Cumulating positions deactivated // Var indicator ATX = CALL "PRC_Adaptive-ATR-ADX-Trend-V2"[21, 3.5, 1.75, 14, 30, 0, 1](close) DEM = DEMA[14](close)   // Logic if DEM CROSSES OVER ATX then BUY 5 CONTRACTS AT MARKET ENDIF

   

  

  efahmy

  Participant

  Topics: 22

  Replies: 47

  Been thanked: 2 times
  02/20/2025 at 10:12 AM #244093
  Iván

  I don’t see errors. The system buys when the DEMA (orange) crosses over ATX (blue).

  // Definition of code parameters DEFPARAM CumulateOrders = TRUE // Cumulating positions deactivated // Var indicator ATX = CALL "PRC_Adaptive-ATR-ADX-Trend-V2"[21, 3.5, 1.75, 14, 30, 0, 1](close) DEM = DEMA[14](close) // Logic if DEM CROSSES OVER ATX then BUY 5 CONTRACTS AT MARKET ENDIF graphonprice ATX coloured("blue") graphonprice DEM coloured("orange")

  1 2 3 4 5 6 7 8 9 10 11 12 13

  // Definition of code parameters DEFPARAM CumulateOrders = TRUE // Cumulating positions deactivated // Var indicator ATX = CALL "PRC_Adaptive-ATR-ADX-Trend-V2"[21, 3.5, 1.75, 14, 30, 0, 1](close) DEM = DEMA[14](close)   // Logic if DEM CROSSES OVER ATX then BUY 5 CONTRACTS AT MARKET ENDIF   graphonprice ATX coloured("blue") graphonprice DEM coloured("orange")

  

  Iván

  Moderator

  Topics: 0

  Replies: 1229

  Been thanked: 440 times
  02/20/2025 at 12:34 PM #244095
  efahmy

  When I use the strategy this what I get, Pls see attached

  

  efahmy

  Participant

  Topics: 22

  Replies: 47

  Been thanked: 2 times
  02/20/2025 at 2:52 PM #244100
  GraHal

  Try putting / embedding the called Indicator in with the code of the rest of Strategy.

  Also, isn’t Line 35 (see below) of the ‘Adaptive Ind’ wrong / ‘suspect’ as STR is not defined anywhere, but STR is used in the rest of the  ‘Adaptive Ind’?   This might be causing ProOrder to Reject the overall code?

  sTR = (sTR[1] – sTR[1]) / adxLen + tr

  

  GraHal

  Participant

  Topics: 215

  Replies: 8914

  Been thanked: 2235 times
  02/20/2025 at 3:10 PM #244101
  GraHal

  Here is the Indicator if anybody has any ideas about fixing Line 35??

  //PRC_Adaptive-ATR-ADX-Trend-V2 | indicator //29.06.2017 //Nicolas @ www.prorealcode.com //Sharing ProRealTime knowledge //translated from tradingview code // --- settings atrLen = 21 m1 = 3.5 //"ATR Multiplier - ADX Rising" m2 = 1.75 //"ATR Multiplier - ADX Falling" adxLen = 14 adxThresh = 30 //"ADX Threshold" aboveThresh = 1 //true, title = "ADX Above Threshold uses ATR Falling Multiplier Even if Rising?") useHeiken = 1 //(false, title = "Use Heiken-Ashi Bars (Source will be ohlc4)") // --- end of settings source = MedianPrice // DI-Pos, DI-Neg, ADX hR = high-high[1] lR = -(low-low[1]) if hr>lr then dmPos=max(hr,0) else dmPos=0 endif if lr>hr then dmNeg=max(lr,0) else dmNeg=0 endif sTR = (sTR[1] - sTR[1]) / adxLen + tr sDMPos = (sDMPos[1] - sDMPos[1]) / adxLen + dmPos sDMNeg = (sDMNeg[1] - sDMNeg[1]) / adxLen + dmNeg DIP = sDMPos / sTR * 100 DIN = sDMNeg / sTR * 100 DX = abs(DIP - DIN) / (DIP + DIN) * 100 aadx = average[adxLen](DX) // Heiken-Ashi if barindex<2 then xClose = close xOpen = open else xClose = TotalPrice xOpen = (xOpen[1] + close[1]) / 2 endif xHigh = max(high, max(xOpen, xClose)) xLow = min(low, min(xOpen, xClose)) // Trailing ATR v1 = abs(xHigh - xClose[1]) v2 = abs(xLow - xClose[1]) v3 = xHigh - xLow trueRange = max(v1, max(v2, v3)) if useHeiken then atr = WilderAverage[atrLen](trueRange) else atr = AverageTrueRange[atrLen] endif if aadx>aadx[1] and (adx < adxThresh or not aboveThresh) then m=m1 elsif aadx<aadx[1] or (adx > adxThresh and aboveThresh) then m=m2 else m = m[1] endif if DIP >= DIN then mUp=m else mUp=m2 endif if DIN >= DIP then mDn=m else mDn=m2 endif if useHeiken then src=xClose c=Xclose t=(xHigh+xLow)/2 else src=source c=close t=MedianPrice endif up = t - mUp * atr dn = t + mDn * atr if max(src[1], c[1]) > TUp[1] then TUp = max(up,TUp[1]) else TUp = up endif if min(src[1], c[1]) < TDown[1] then TDown = min(dn, TDown[1]) else TDown = dn endif //trend if min(src,min(c,close))>TDown[1] then trend=1 elsif max(src,max(c,close))<TUp[1] then trend=-1 else trend=trend[1] endif if trend=1 then sstop=TUp r=0 g=255 else sstop=TDown r=255 g=0 endif if trend<>trend[1] then drawtext("•",barindex,sstop,Dialog,Standard,30) coloured(r,g,0) endif return sstop coloured(r,g,0) style(line,2)

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137

  //PRC_Adaptive-ATR-ADX-Trend-V2 | indicator //29.06.2017 //Nicolas @ www.prorealcode.com //Sharing ProRealTime knowledge //translated from tradingview code // --- settings atrLen = 21 m1 = 3.5 //"ATR Multiplier - ADX Rising" m2 = 1.75 //"ATR Multiplier - ADX Falling" adxLen = 14 adxThresh = 30 //"ADX Threshold" aboveThresh = 1 //true, title = "ADX Above Threshold uses ATR Falling Multiplier Even if Rising?") useHeiken = 1 //(false, title = "Use Heiken-Ashi Bars (Source will be ohlc4)") // --- end of settings source = MedianPrice      // DI-Pos, DI-Neg, ADX hR = high-high[1] lR = -(low-low[1]) if hr>lr then dmPos=max(hr,0) else dmPos=0 endif if lr>hr then dmNeg=max(lr,0) else dmNeg=0 endif sTR = (sTR[1] - sTR[1]) / adxLen + tr sDMPos = (sDMPos[1] - sDMPos[1]) / adxLen + dmPos sDMNeg = (sDMNeg[1] - sDMNeg[1]) / adxLen + dmNeg DIP = sDMPos / sTR * 100 DIN = sDMNeg / sTR * 100 DX = abs(DIP - DIN) / (DIP + DIN) * 100 aadx = average[adxLen](DX) // Heiken-Ashi if barindex<2 then xClose = close xOpen = open else xClose = TotalPrice xOpen = (xOpen[1] + close[1]) / 2 endif xHigh = max(high, max(xOpen, xClose)) xLow = min(low, min(xOpen, xClose)) // Trailing ATR v1 = abs(xHigh - xClose[1]) v2 = abs(xLow - xClose[1]) v3 = xHigh - xLow trueRange = max(v1, max(v2, v3)) if useHeiken then atr = WilderAverage[atrLen](trueRange) else atr = AverageTrueRange[atrLen] endif if aadx>aadx[1] and (adx < adxThresh or not aboveThresh) then m=m1 elsif aadx<aadx[1] or (adx > adxThresh and aboveThresh) then m=m2 else m = m[1] endif if DIP >= DIN then mUp=m else mUp=m2 endif if DIN >= DIP then mDn=m else mDn=m2 endif if useHeiken then src=xClose c=Xclose t=(xHigh+xLow)/2 else src=source c=close t=MedianPrice endif up = t - mUp * atr dn = t + mDn * atr if max(src[1], c[1]) > TUp[1] then TUp = max(up,TUp[1]) else TUp = up endif if min(src[1], c[1]) < TDown[1] then TDown = min(dn, TDown[1]) else TDown = dn endif //trend if min(src,min(c,close))>TDown[1] then trend=1 elsif max(src,max(c,close))<TUp[1] then trend=-1 else trend=trend[1] endif if trend=1 then sstop=TUp r=0 g=255 else sstop=TDown r=255 g=0 endif if trend<>trend[1] then drawtext("•",barindex,sstop,Dialog,Standard,30) coloured(r,g,0) endif return sstop coloured(r,g,0) style(line,2)

   

  

  GraHal

  Participant

  Topics: 215

  Replies: 8914

  Been thanked: 2235 times
  02/20/2025 at 5:16 PM #244109
  JS

  Nicolas, Can you explain the numerator logic – e.g. Line 35 is (sTR[1] – sTR[1]) which would appear to be either null or zero.

  • 
    Nicolas • 06/29/2018 #You are right, this is useless. Since I converted it from another programming language, I assume it was in the original code…

  

  JS

  Participant

  Topics: 27

  Replies: 1867

  Been thanked: 932 times
  02/20/2025 at 8:18 PM #244114
  GraHal

  Thanks JS, but please could not you (anybody) rejig the code so that the subsequent use of sTR in the Strategy is removed / replaced with something meaningful?
  Examples are Line 40 & 41 –

  DIP = sDMPos / sTR * 100

  DIN = sDMNeg / sTR * 100

  I recall ages ago working up a decent backtest performance with the ‘Adaptive Indicator’, but the Algo got Rejected every time it ran due to ‘not enough historical data’ (yes, I did use Defparam PreLoadbars = 10000.

  The error messages we see are not always ‘true to the words’ and I am thinking that this useless bit of code (STR) was causing my Rejection and also the problems now experienced by the OP / efahmy

   

  

  GraHal

  Participant

  Topics: 215

  Replies: 8914

  Been thanked: 2235 times
  02/20/2025 at 8:37 PM #244115
  JC_Bywan

  Assuming that’s the source code:

  https://www.tradingview.com/script/8TQl2WyE-Adaptive-ATR-ADX-Trend-V2-Strategy/

  Then for line 35 mentionned by GraHal, I would keep it and go instead with brackets modified like this (equivalent to “no brackets”, but just for the sake of better visibility…):

  sTR = sTR[1] - (sTR[1]) / adxLen + tr

  1	sTR = sTR[1] - (sTR[1]) / adxLen + tr

   

  Same thing by the way for lines 37 and 38, which could be modified as follows:

  sDMPos = sDMPos[1] - (sDMPos[1]) / adxLen + dmPos sDMNeg = sDMNeg[1] - (sDMNeg[1]) / adxLen + dmNeg

  1 2	sDMPos = sDMPos[1] - (sDMPos[1]) / adxLen + dmPos sDMNeg = sDMNeg[1] - (sDMNeg[1]) / adxLen + dmNeg

   

  To be tested to see if it helps…

  1 user thanked author for this post.

  GraHal

  

  JC_Bywan

  Moderator

  Topics: 20

  Replies: 2689

  Been thanked: 962 times
  02/20/2025 at 9:27 PM #244127
  JS

  I think the code should be adjusted like this:

  Adaptive ATR ADX Trend

  //PRC_Adaptive-ATR-ADX-Trend-v3 //------------ // Parameters //------------ atrLen = 21 m1 = 3.5 // ATR Multiplier - ADX Rising m2 = 1.75 // ATR Multiplier - ADX Falling adxLen = 14 adxThresh = 30 // ADX Threshold aboveThresh = 1 // Use ATR Falling Multiplier even if ADX is rising useHeiken = 1 // Use Heiken-Ashi bars //------------ // Source Data //------------ source = MedianPrice //------------ // ADX Calculation //------------ hR = High - High[1] lR = -(Low - Low[1]) IF hR > lR THEN dmPos = MAX(hR, 0) ELSE dmPos = 0 ENDIF IF lR > hR THEN dmNeg = MAX(lR, 0) ELSE dmNeg = 0 ENDIF sTR = (sTR[1] * (adxLen - 1) + TrueRange) / adxLen sDMPos = (sDMPos[1] * (adxLen - 1) + dmPos) / adxLen sDMNeg = (sDMNeg[1] * (adxLen - 1) + dmNeg) / adxLen DIP = sDMPos / sTR * 100 DIN = sDMNeg / sTR * 100 DX = ABS(DIP - DIN) / (DIP + DIN) * 100 aadx = Average[adxLen](DX) //------------ // Heiken-Ashi Calculation //------------ IF BarIndex < 2 THEN xClose = Close xOpen = Open ELSE xClose = TotalPrice xOpen = (xOpen[1] + Close[1]) / 2 ENDIF xHigh = MAX(High, MAX(xOpen, xClose)) xLow = MIN(Low, MIN(xOpen, xClose)) //------------ // Trailing ATR Calculation //------------ v1 = ABS(xHigh - Close[1]) v2 = ABS(xLow - Close[1]) v3 = xHigh - xLow trueRange = MAX(v1, MAX(v2, v3)) IF useHeiken THEN atr = WilderAverage[atrLen](trueRange) ELSE atr = AverageTrueRange[atrLen] ENDIF IF aadx > aadx[1] AND (aadx < adxThresh OR NOT aboveThresh) THEN m = m1 ELSIF aadx < aadx[1] OR (aadx > adxThresh AND aboveThresh) THEN m = m2 ELSE m = m[1] ENDIF IF DIP >= DIN THEN mUp = m ELSE mUp = m2 ENDIF IF DIN >= DIP THEN mDn = m ELSE mDn = m2 ENDIF //------------ // Trend Calculation //------------ IF useHeiken THEN src = xClose c = xClose t = (xHigh + xLow) / 2 ELSE src = source c = Close t = MedianPrice ENDIF up = t - mUp * atr dn = t + mDn * atr IF MAX(src[1], c[1]) > TUp[1] THEN TUp = MAX(up, TUp[1]) ELSE TUp = up ENDIF IF MIN(src[1], c[1]) < TDown[1] THEN TDown = MIN(dn, TDown[1]) ELSE TDown = dn ENDIF //------------ // Trend Detection //------------ IF MIN(src, MIN(c, Close)) > TDown[1] THEN trend = 1 ELSIF MAX(src, MAX(c, Close)) < TUp[1] THEN trend = -1 ELSE trend = trend[1] ENDIF IF trend = 1 THEN sstop = TUp r = 0 g = 255 ELSE sstop = TDown r = 255 g = 0 ENDIF IF trend <> trend[1] THEN DRAWTEXT("•", BarIndex, sstop, Dialog, Standard, 30) COLOURED(r, g, 0) ENDIF RETURN sstop COLOURED(r, g, 0) STYLE(line,2)

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147

  //PRC_Adaptive-ATR-ADX-Trend-v3 //------------ // Parameters //------------ atrLen = 21 m1 = 3.5  // ATR Multiplier - ADX Rising m2 = 1.75 // ATR Multiplier - ADX Falling adxLen = 14 adxThresh = 30 // ADX Threshold aboveThresh = 1 // Use ATR Falling Multiplier even if ADX is rising useHeiken = 1   // Use Heiken-Ashi bars   //------------ // Source Data //------------ source = MedianPrice   //------------ // ADX Calculation //------------ hR = High - High[1] lR = -(Low - Low[1])   IF hR > lR THEN dmPos = MAX(hR, 0) ELSE dmPos = 0 ENDIF   IF lR > hR THEN dmNeg = MAX(lR, 0) ELSE dmNeg = 0 ENDIF   sTR = (sTR[1] * (adxLen - 1) + TrueRange) / adxLen sDMPos = (sDMPos[1] * (adxLen - 1) + dmPos) / adxLen sDMNeg = (sDMNeg[1] * (adxLen - 1) + dmNeg) / adxLen   DIP = sDMPos / sTR * 100 DIN = sDMNeg / sTR * 100 DX = ABS(DIP - DIN) / (DIP + DIN) * 100 aadx = Average[adxLen](DX)   //------------ // Heiken-Ashi Calculation //------------ IF BarIndex < 2 THEN xClose = Close xOpen = Open ELSE xClose = TotalPrice xOpen = (xOpen[1] + Close[1]) / 2 ENDIF   xHigh = MAX(High, MAX(xOpen, xClose)) xLow = MIN(Low, MIN(xOpen, xClose))   //------------ // Trailing ATR Calculation //------------ v1 = ABS(xHigh - Close[1]) v2 = ABS(xLow - Close[1]) v3 = xHigh - xLow   trueRange = MAX(v1, MAX(v2, v3))   IF useHeiken THEN atr = WilderAverage[atrLen](trueRange) ELSE atr = AverageTrueRange[atrLen] ENDIF   IF aadx > aadx[1] AND (aadx < adxThresh OR NOT aboveThresh) THEN m = m1 ELSIF aadx < aadx[1] OR (aadx > adxThresh AND aboveThresh) THEN m = m2 ELSE m = m[1] ENDIF   IF DIP >= DIN THEN mUp = m ELSE mUp = m2 ENDIF   IF DIN >= DIP THEN mDn = m ELSE mDn = m2 ENDIF   //------------ // Trend Calculation //------------ IF useHeiken THEN src = xClose c = xClose t = (xHigh + xLow) / 2 ELSE src = source c = Close t = MedianPrice ENDIF   up = t - mUp * atr dn = t + mDn * atr   IF MAX(src[1], c[1]) > TUp[1] THEN TUp = MAX(up, TUp[1]) ELSE TUp = up ENDIF   IF MIN(src[1], c[1]) < TDown[1] THEN TDown = MIN(dn, TDown[1]) ELSE TDown = dn ENDIF   //------------ // Trend Detection //------------ IF MIN(src, MIN(c, Close)) > TDown[1] THEN trend = 1 ELSIF MAX(src, MAX(c, Close)) < TUp[1] THEN trend = -1 ELSE trend = trend[1] ENDIF   IF trend = 1 THEN sstop = TUp r = 0 g = 255 ELSE sstop = TDown r = 255 g = 0 ENDIF   IF trend <> trend[1] THEN DRAWTEXT("•", BarIndex, sstop, Dialog, Standard, 30) COLOURED(r, g, 0) ENDIF   RETURN sstop COLOURED(r, g, 0) STYLE(line,2)

   

  1 user thanked author for this post.

  GraHal

  

  JS

  Participant

  Topics: 27

  Replies: 1867

  Been thanked: 932 times
• Author
  Posts