Swing Indicator

• 10/25/2017 at 4:22 PM #50496
  Henry

  A request that was addressed to ProRealTime:

  Good morning, I would like to recode this swing indicator in tradestation format to prorealcode language.

  inputs: filter(2), stats(0);
  vars : xBar(0) , xHigh(0), xLow(0), xCount(0), xSwitch(0);
  vars : xSkip(0), xConfirm(0);
  vars : pBar(0) , pHigh(0), pLow(0);
  vars : bFirst(1);

  if xSwitch = 0 then
  begin
  if High >= xHigh then
  begin
  xHigh = High;
  xLow = Low;
  xBar = BarNumber;
  xSkip = 0;
  end
  else
  begin
  xSkip = xSkip + 1;
  if xSkip >= filter then
  begin
  xConfirm = 1;
  xCount = 1;
  while xCount < filter
  begin
  if (Low[xCount] <= Low[xCount-1]) or (xLow <= Low[filter-1])
  then
  begin
  xCount = filter;
  xConfirm = 0;
  end;
  xCount = xCount + 1;
  end;
  if xConfirm = 1 then
  begin
  xSwitch = 1;
  if stats = 0 then
  plot1[BarNumber-xBar](xHigh,”Swing”)
  else
  begin
  if bFirst = 0 then
  begin
  plot2[BarNumber-xBar](xHigh-pLow,”Range”);
  plot3[BarNumber-xBar](xBar -pBar,”Duration”);
  end;
  bFirst = 0;
  end;
  pHigh = xHigh;
  pLow = xLow;
  pBar = xBar;
  xHigh = High;
  xLow = Low;
  xBar = BarNumber;
  xSkip = 0;
  end;
  end;
  end;
  end
  else
  begin
  if Low <= xLow then
  begin
  xHigh = High;
  xLow = Low;
  xBar = BarNumber;
  xSkip = 0;
  end
  else
  begin
  xSkip = xSkip + 1;
  if xSkip >= filter then
  begin
  xConfirm = 1;
  xCount = 1;
  while xCount < filter
  begin
  if (High[xCount] >= High[xCount-1]) or (xHigh >=
  High[filter-1]) then
  begin
  xCount = filter;
  xConfirm = 0;
  end;
  xCount = xCount + 1;
  end;
  if xConfirm = 1 then
  begin
  xSwitch = 0;
  if stats = 0 then
  plot1[BarNumber-xBar](xLow,”Swing”)
  else
  begin
  plot2[BarNumber-xBar](pHigh-xLow,”Range”);
  plot3[BarNumber-xBar](xBar -pBar,”Duration”);
  end;
  pHigh = xHigh;
  pLow = xLow;
  pBar = xBar;
  xLow = Low;
  xHigh = High;
  xBar = BarNumber;
  xSkip = 0;
  end;
  end;
  end;
  end;

  if ((date = lastcalcdate) and (time = lastcalctime)) then
  begin
  if xSwitch = 0 then
  begin
  if stats = 0 then
  plot1[BarNumber-xBar](xHigh,”Swing”)
  else
  begin
  plot2[BarNumber-xBar](xHigh-pLow,”Range”);
  plot3[BarNumber-xBar](xBar -pBar,”Duration”);
  end;
  end
  else
  begin
  if stats = 0 then
  plot1[BarNumber-xBar](xLow,”Swing”)
  else
  begin
  plot2[BarNumber-xBar](pHigh-xLow,”Range”);
  plot3[BarNumber-xBar](xBar -pBar,”Duration”);
  end;
  end;
  end;

  Suggestion for an anwser:

  Add a filter variable and then add the indicator on the price graph:

  if xSwitch = 0 then if High >= xHigh then xHigh = High xLow = Low xSkip = 0 else xSkip = xSkip + 1 if xSkip >= filter then xConfirm = 1 xCount = 1 while xCount < filter if (Low[xCount] <= Low[xCount-1]) or (xLow <= Low[filter-1])then xCount = filter xConfirm = 0 endif xCount = xCount + 1 wend if xConfirm = 1 then xSwitch = 1 MyxHigh=xHigh xHighBar=Barindex-xskip xHigh = High xLow = Low xSkip = 0 endif endif endif else if Low <= xLow then xHigh = High xLow = Low xSkip = 0 else xSkip = xSkip + 1 if xSkip >= filter then xConfirm = 1 xCount = 1 while xCount < filter if (High[xCount] >= High[xCount-1]) or (xHigh >= High[filter-1]) then xCount = filter xConfirm = 0 endif xCount = xCount + 1 wend if xConfirm = 1 then xSwitch = 0 myxlow=xLow xLowBar=Barindex-xskip xLow = Low xHigh = High xSkip = 0 endif endif endif endif DRAWSEGMENT(xLowBar, myxlow, xHighBar, MyxHigh) COLOURED(255,0,0) return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59

  if xSwitch = 0  then if High >= xHigh then xHigh  = High xLow   = Low xSkip  = 0 else xSkip  = xSkip + 1 if xSkip      >= filter then xConfirm    = 1 xCount      = 1 while xCount < filter   if (Low[xCount] <= Low[xCount-1]) or (xLow <= Low[filter-1])then xCount   = filter xConfirm = 0 endif xCount      = xCount + 1 wend if xConfirm   = 1 then xSwitch = 1 MyxHigh=xHigh xHighBar=Barindex-xskip   xHigh   = High xLow    = Low xSkip   = 0 endif endif endif else if Low <= xLow then xHigh = High xLow  = Low xSkip = 0 else xSkip = xSkip + 1 if xSkip >= filter then xConfirm = 1 xCount   = 1 while xCount < filter if (High[xCount] >= High[xCount-1]) or (xHigh >= High[filter-1]) then xCount   = filter xConfirm = 0 endif xCount   = xCount + 1 wend if xConfirm = 1 then xSwitch = 0 myxlow=xLow xLowBar=Barindex-xskip xLow    = Low xHigh   = High xSkip   = 0 endif endif endif endif DRAWSEGMENT(xLowBar, myxlow, xHighBar, MyxHigh) COLOURED(255,0,0) return

   

  4 users thanked author for this post.

  ckat55, Lighthouse, swapping, Nicolas

  

  Henry

  Participant

  Topics: 36

  Replies: 4

  Been thanked: 13 times
  10/27/2017 at 1:22 PM #50721
  Marco

  hi ,

  good

   

  thanks Henry

   

   

  

  Marco

  Participant

  Topics: 4

  Replies: 15

  Been thanked: 1 time
  10/27/2017 at 4:25 PM #50740
  Nicolas

  This is how it looks, thanks to Henry 🙂 , I’ll add it in the library soon for everyone’s benefit.

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  03/22/2019 at 10:56 AM #94386
  massimo mamprin

  Come si definisce la variabile filter ???

  

  massimo mamprin

  Participant

  Topics: 1

  Replies: 12

  Been thanked: 0 times
  03/22/2019 at 11:42 AM #94395
  Vonasi

  massimo mamprin – English only in the English forums please.

  

  Vonasi

  Moderator

  Topics: 192

  Replies: 5088

  Been thanked: 1811 times
  03/22/2019 at 11:54 AM #94396
  robertogozzi

  Filter seems to be what is commonly called Period.

  Write

  Filter=20

  1

  Filter=20

  as the first line. Change it whenever you want to.

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17150

  Been thanked: 4039 times
  03/24/2019 at 12:28 PM #94554
  massimo mamprin

  Thank you

  How can I change the colour of the line

  In PRT i can make the input about the number of the bar when i change the colour the line is the same colour

  Do you know can I change

  Thanks

  

  massimo mamprin

  Participant

  Topics: 1

  Replies: 12

  Been thanked: 0 times
  03/24/2019 at 2:03 PM #94557
  robertogozzi

  You can add 3 variables for colours:

  – Red

  – Green

  – Blue

  you can then set them with the properties.

  Change the last part of line 58 as follows:

  COLOURED(Red,Green,Blue)

  1	COLOURED(Red,Green,Blue)

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17150

  Been thanked: 4039 times
  03/24/2019 at 9:48 PM #94568
  massimo mamprin

  I try but give me error (sintassi)

  

  massimo mamprin

  Participant

  Topics: 1

  Replies: 12

  Been thanked: 0 times
  03/24/2019 at 10:43 PM #94572
  robertogozzi

  Post the code you have written.

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17150

  Been thanked: 4039 times
  03/25/2019 at 9:59 AM #94585
  massimo mamprin

   

  if High >= xHigh then xHigh  = High xLow   = Low xSkip  = 0 else xSkip  = xSkip + 1 if xSkip      >= filter then xConfirm    = 1 xCount      = 1 while xCount < filter if (Low[xCount] <= Low[xCount-1]) or (xLow <= Low[filter-1])then xCount   = filter xConfirm = 0 endif xCount      = xCount + 1 wend if xConfirm   = 1 then xSwitch = 1 MyxHigh=xHigh xHighBar=Barindex-xskip xHigh   = High xLow    = Low xSkip   = 0 endif endif endif else if Low <= xLow then xHigh = High xLow  = Low xSkip = 0 else xSkip = xSkip + 1 if xSkip >= filter then xConfirm = 1 xCount   = 1 while xCount < filter if (High[xCount] >= High[xCount-1]) or (xHigh >= High[filter-1]) then xCount   = filter xConfirm = 0 endif xCount   = xCount + 1 wend if xConfirm = 1 then xSwitch = 0 myxlow=xLow xLowBar=Barindex-xskip xLow    = Low xHigh   = High xSkip   = 0 endif endif endif endif DRAWSEGMENT(xLowBar, myxlow, xHighBar, MyxHigh) COLOURED(255,0,0) return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62

  if High >= xHigh then xHigh  = High xLow   = Low xSkip  = 0 else xSkip  = xSkip + 1 if xSkip      >= filter then xConfirm    = 1 xCount      = 1   while xCount < filter if (Low[xCount] <= Low[xCount-1]) or (xLow <= Low[filter-1])then xCount   = filter xConfirm = 0 endif xCount      = xCount + 1 wend   if xConfirm   = 1 then xSwitch = 1 MyxHigh=xHigh xHighBar=Barindex-xskip xHigh   = High xLow    = Low xSkip   = 0 endif endif endif else if Low <= xLow then xHigh = High xLow  = Low xSkip = 0 else xSkip = xSkip + 1 if xSkip >= filter then xConfirm = 1 xCount   = 1   while xCount < filter if (High[xCount] >= High[xCount-1]) or (xHigh >= High[filter-1]) then xCount   = filter xConfirm = 0 endif xCount   = xCount + 1 wend   if xConfirm = 1 then xSwitch = 0 myxlow=xLow xLowBar=Barindex-xskip xLow    = Low xHigh   = High xSkip   = 0 endif endif endif endif   DRAWSEGMENT(xLowBar, myxlow, xHighBar, MyxHigh) COLOURED(255,0,0)   return

  EDIT by Vonasi: Code tidied up using ‘Insert PRT Code’ button for you. 🙂

  

  massimo mamprin

  Participant

  Topics: 1

  Replies: 12

  Been thanked: 0 times
  03/25/2019 at 10:04 AM #94587
  robertogozzi

  I want to point out two issues:

  • To write code, please use the <> “insert PRT code” button, to make code easier to read and understand
  • When you Copy remove any line number (try not to select them if possible) after Pasting the code

  the latter being the cause of reported syntax errors.

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17150

  Been thanked: 4039 times
  03/29/2019 at 3:09 PM #95013
  Matriciel

  Hi,
  What is the difference with a traditional “ZigZag”?

  

  Matriciel

  Participant

  Topics: 25

  Replies: 110

  Been thanked: 24 times
  03/29/2019 at 4:21 PM #95029
  Nicolas

  ZigZag like many other indicators plots the tops and bottoms. You can take any calculation method to find and link them with segments and you’ll get something similar to zigzag.

  1 user thanked author for this post.

  Matriciel

  

  Nicolas

  Keymaster

  Topics: 81

  Replies: 20863

  Been thanked: 4773 times
  10/07/2019 at 10:35 PM #109561
  Robb

  Hi All, Hi Nicolas,

  I copied and pasted the code, added the variable filter=20.

  No sintax errors, but on the chart nothing appears and I don’t understand why.

  Thank you in advance

  Roberto

  

  Robb

  Participant

  Topics: 7

  Replies: 30

  Been thanked: 0 times
• Author
  Posts