Wedges based in Cycle Highs and Lows

• 10/13/2020 at 2:00 PM #147294
  Malend

  I have programmed an indicator to define the Highs and Lows based on Cycles, made by the Stochastics. Of course you can use other oscilators as well. Just edit it in the programming.
  The highs and lows will be confirmed after the cycle has closed. Now I would like to add an extended line connecting the last 2 highs and an extended line to connect the last 2 lows. It is a way to see when wedges start to show up. See the image.

  Another thing is that sometimes it doesn’t show me the high/low after the cycle has closed. When I edit the settings in the menu, which are only about the transparency of the vertical lines, it shows up, or after I have validated the indicator again. I don’t know why that happens.

  Highs and Lows by Stochastic Cycles

  // This indicator marks highs and lows based on the Stochastic cycle K = stochastic[5,2] D = average[3](K) sma50 = average[50] macdl = macdline[5,20,30] M = momentum[42] //start of cycle low looking for the lowest price and lowest MACD as long as Stochastic %D<50 If D =< 50 and D[1] => 50 then incyclelow = 1 lowestprice2 = lowestprice Lowestprice = low macdlowest2 = macdlowest macdlowest = macdl Dlowest2 = Dlowest Dlowest = D Mlowest2 = Mlowest Mlowest = M endif //End of cycle low If D => 50 and D[1] < 50 then incyclelow = 0 endif //lowest macd and price in Stochastic cycle %D<50 if incyclelow then lowestprice = min(lowestprice, low) macdlowest = min(macdlowest, macdl) Dlowest = min(Dlowest, D) Mlowest = min(Mlowest, M) endif //what is the lowest price bar of this cycle? if lowestprice<>lowestprice[1] then lowestpriceBar=barindex endif if macdlowest<>macdlowest[1] then macdlowestBar=barindex macdlowestPrice=low-10*pointsize endif if Dlowest<>Dlowest[1] then DlowestBar = barindex endif if Mlowest<>Mlowest[1] then MlowestBar = barindex endif //LONG if incyclelow = 0 then DRAWSEGMENT(lowestpriceBar,lowestprice,lowestpriceBar,lowestprice-50) COLOURED(0,groen,0) STYLE(dottedline, 1) DRAWSEGMENT(lowestpriceBar,lowestprice,lowestpriceBar-4,lowestprice) COLOURED(300,0,0) STYLE(line, 3) endif //____________________________________________________________________________________________________________________ //start of cycle high looking for the higestest price and higest MACD as long as Stochastic %D>50 If D => 50 and D[1] =< 50 then incyclehigh = 1 highestprice2 = highestprice HighestPrice = high macdhighest2 = macdhighest macdhighest = macdl Dhighest2 = Dhighest Dhighest = D Mhighest2 = Mhighest Mhighest = M endif //End of cycle high If D =< 50 and D[1] > 50 then incyclehigh = 0 endif //highest stoch and price in cycle high if incyclehigh then highestPrice = max(highestPrice, high) macdhighest = max(macdhighest, macdl) Mhighest = max(Mhighest, M) endif //what is the lowest price bar of this cycle? if highestprice<>highestprice[1] then highestpriceBar=barindex endif if macdhighest<>macdhighest[1] then macdhighestBar=barindex macdhighestPrice=low-10*pointsize endif if Dhighest<>Dhighest[1] then DhighestBar=barindex endif if Mhighest<>Mhighest[1] then MhighestBar = barindex endif //SHORT if incyclehigh = 0 then DRAWSEGMENT(highestpriceBar,highestprice,highestpriceBar,highestprice+50) COLOURED(rood,0,0) STYLE(dottedline, 1) DRAWSEGMENT(highestpriceBar,highestprice,highestpriceBar-4,highestprice) COLOURED(0,300,0) STYLE(line, 3) endif return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106

  // This indicator marks highs and lows based on the Stochastic cycle K = stochastic[5,2] D = average[3](K) sma50 = average[50] macdl = macdline[5,20,30] M = momentum[42]   //start of cycle low looking for the lowest price and lowest MACD as long as Stochastic %D<50 If D =< 50 and D[1] => 50 then incyclelow = 1 lowestprice2 = lowestprice Lowestprice = low macdlowest2 = macdlowest macdlowest = macdl Dlowest2 = Dlowest Dlowest = D Mlowest2 = Mlowest Mlowest = M endif //End of cycle low If D => 50 and D[1] < 50 then incyclelow = 0 endif //lowest macd and price in Stochastic cycle %D<50 if incyclelow then lowestprice = min(lowestprice, low) macdlowest = min(macdlowest, macdl) Dlowest = min(Dlowest, D) Mlowest =  min(Mlowest, M)   endif   //what is the lowest price bar of this cycle? if lowestprice<>lowestprice[1] then lowestpriceBar=barindex endif if macdlowest<>macdlowest[1] then macdlowestBar=barindex macdlowestPrice=low-10*pointsize endif if Dlowest<>Dlowest[1] then DlowestBar = barindex endif if Mlowest<>Mlowest[1] then MlowestBar = barindex endif   //LONG if incyclelow = 0 then DRAWSEGMENT(lowestpriceBar,lowestprice,lowestpriceBar,lowestprice-50) COLOURED(0,groen,0) STYLE(dottedline, 1) DRAWSEGMENT(lowestpriceBar,lowestprice,lowestpriceBar-4,lowestprice) COLOURED(300,0,0) STYLE(line, 3) endif     //____________________________________________________________________________________________________________________   //start of cycle high looking for the higestest price and higest MACD as long as Stochastic %D>50 If D => 50 and D[1] =< 50 then incyclehigh = 1 highestprice2 = highestprice HighestPrice = high macdhighest2 = macdhighest macdhighest = macdl Dhighest2 = Dhighest Dhighest = D Mhighest2 = Mhighest Mhighest = M endif //End of cycle high If D =< 50 and D[1] > 50 then incyclehigh = 0 endif //highest stoch and price in cycle high if incyclehigh then highestPrice = max(highestPrice, high) macdhighest = max(macdhighest, macdl) Mhighest = max(Mhighest, M) endif   //what is the lowest price bar of this cycle? if highestprice<>highestprice[1] then highestpriceBar=barindex endif if macdhighest<>macdhighest[1] then macdhighestBar=barindex macdhighestPrice=low-10*pointsize endif if Dhighest<>Dhighest[1] then DhighestBar=barindex endif if Mhighest<>Mhighest[1] then MhighestBar = barindex endif   //SHORT if incyclehigh = 0 then DRAWSEGMENT(highestpriceBar,highestprice,highestpriceBar,highestprice+50) COLOURED(rood,0,0) STYLE(dottedline, 1) DRAWSEGMENT(highestpriceBar,highestprice,highestpriceBar-4,highestprice) COLOURED(0,300,0) STYLE(line, 3) endif   return

   

  

  Malend

  Participant

  Topics: 14

  Replies: 100

  Been thanked: 4 times
  10/13/2020 at 2:04 PM #147295
  Malend

  Sorry, for some reason I can’t add the image, JPEG 163k size. I also tried a PNG…..doesn’t work either.

  

  Malend

  Participant

  Topics: 14

  Replies: 100

  Been thanked: 4 times
  10/13/2020 at 2:23 PM #147298
  robertogozzi

  There are many variables missing or not defined.

  Can you please post a full working code?

  Eben better it would be attaching the ITF file.

  Thank you 🙂

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17272

  Been thanked: 4119 times
  10/13/2020 at 3:03 PM #147301
  Malend

  Ciao Roberto,
  Here is the ITF file

  1 user thanked author for this post.

  robertogozzi

  

  Malend

  Participant

  Topics: 14

  Replies: 100

  Been thanked: 4 times
  10/13/2020 at 3:06 PM #147303
  Malend

  I took away the setting in the menu where you could adjust the transparency of the vertical lines. The vertical line mark the candle with the high/low. The horizontal segment moves marks the price of the high/low.

   

  

  Malend

  Participant

  Topics: 14

  Replies: 100

  Been thanked: 4 times
  10/13/2020 at 3:13 PM #147304
  Malend

  Another try with the image.

  

  Malend

  Participant

  Topics: 14

  Replies: 100

  Been thanked: 4 times
  10/13/2020 at 4:23 PM #147315
  robertogozzi

  The code is still not working, many variables are not used.

  When posting code, please make sure it’s fully functional! People may want to help you, but only if you help them not waste their time uselessly!

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17272

  Been thanked: 4119 times
  10/13/2020 at 4:32 PM #147316
  Malend

  It is fully functional. I even checked it with Nicolas. And it works for me.
  I know the MACD and the Momentum aren’t used, although they are described, but they are also not in the programming. The signals you get in the chart are Lows and Highs based on the Stochastic [5,2,3]. They show up in my chart. See the image I included.
  Please let me know what doesn’t work for you.
  I took out the unused parameters, so here again.

  

  Malend

  Participant

  Topics: 14

  Replies: 100

  Been thanked: 4 times
  10/13/2020 at 4:48 PM #147320
  Malend

  In the image here you see what shows up in the chart right now. But I would like to have the extended lines from the last two Highs connected and the last tw low connected as in the image above I posted 3:13 PM.

  

  Malend

  Participant

  Topics: 14

  Replies: 100

  Been thanked: 4 times
  10/13/2020 at 5:42 PM #147333
  robertogozzi

  I see it’s for v11.

  What TF and instrument is the one in your pics?

  What time is the unmarked low?

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17272

  Been thanked: 4119 times
  10/13/2020 at 6:08 PM #147335
  Malend

  I use it on different time frames. This one is on EURUSD 200 ticks.
  The unmarked low doesn’t stay unmarked, as I said, when I refresh the indicator by only open the indicator editor it marks it, or by making the whole indicator invisble first and then visible again. I don’t know why. So the dropp out  in the image is allready working, but then a new one, mainly the last ones, sometimes don’t show up.

  

  Malend

  Participant

  Topics: 14

  Replies: 100

  Been thanked: 4 times
  10/13/2020 at 6:25 PM #147338
  robertogozzi

  I cannot see the missing LOW you are referring, what time was it?

  Moreover, the candlesticks I see are pretty much different from yours, is that Spot EurUsd?

  If I can’t replicate exactly your trades, I can’t help you.

   

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17272

  Been thanked: 4119 times
  10/13/2020 at 7:01 PM #147341
  Malend

  Yes, it is Spot Eur Usd, 200 ticks.
  Aren’t you able to see the horizontal green and red lines? These are the Highs (green) and the Lows (red) based on the stochastic cycles. Now I want 2 extended lines. The first one connects the last 2 Highs and the other one connects the last 2 Lows.
  I have added a new dropp out this evening. You see the time bar 19:25:07

   

  

  Malend

  Participant

  Topics: 14

  Replies: 100

  Been thanked: 4 times
  10/15/2020 at 2:01 PM #147484
  robertogozzi

  To draw those lines (supported by v11 only), you need to use two slightly different copies, with different names, of the same indicator.

  This is the same indicator as yours (ITF file attached, as well as a screenshot), but I commented out drawing red and green segments, then I added instructions to keep track of the last two green and red segment to draw those elongated lines at the end:

  DEFPARAM DrawOnLastBarOnly = true ONCE MyHigh1 = 0 ONCE MyHigh2 = 0 ONCE MyLow1 = 0 ONCE MyLow2 = 0 ONCE BarHigh1 = 0 ONCE BarHigh2 = 0 ONCE BarLow1 = 0 ONCE BarLow2 = 0 // This indicator marks highs and lows based on the Stochastic cycle K = stochastic[5,2] D = average[3](K) //start of cycle low looking for the lowest price and lowest MACD as long as Stochastic %D<50 If D =< 50 and D[1] => 50 then incyclelow = 1 lowestprice2 = lowestprice Lowestprice = low Dlowest2 = Dlowest Dlowest = D endif //End of cycle low If D > 50 and D[1] < 50 then incyclelow = 0 endif //lowest macd and price in Stochastic cycle %D<50 if incyclelow then lowestprice = min(lowestprice, low) Dlowest = min(Dlowest, D) endif //what is the lowest price bar of this cycle? if lowestprice<>lowestprice[1] then lowestpriceBar=barindex endif //LONG if incyclelow = 0 then if lowestpricebar <> BarLow1 then MyLow2 = MyLow1 BarLow2 = BarLow1 MyLow1 = lowestPrice BarLow1 = lowestpriceBar ENDIF //DRAWSEGMENT(lowestpriceBar,lowestprice,lowestpriceBar,lowestprice-50) COLOURED(0,50,0) STYLE(dottedline, 1) //DRAWSEGMENT(lowestpriceBar,lowestprice,lowestpriceBar-4,lowestprice) COLOURED(300,0,0) STYLE(line, 3) endif //____________________________________________________________________________________________________________________ //start of cycle high looking for the higestest price and higest MACD as long as Stochastic %D>50 If D => 50 and D[1] =< 50 then incyclehigh = 1 highestprice2 = highestprice HighestPrice = high endif //End of cycle high If D < 50 and D[1] > 50 then incyclehigh = 0 endif //highest stoch and price in cycle high if incyclehigh then highestPrice = max(highestPrice, high) endif //what is the lowest price bar of this cycle? if highestprice<>highestprice[1] then highestpriceBar=barindex endif //SHORT if incyclehigh = 0 then if highestpricebar <> BarHigh1 then MyHigh2 = MyHigh1 BarHigh2 = BarHigh1 MyHigh1 = highestPrice BarHigh1 = highestpriceBar ENDIF //DRAWSEGMENT(highestpriceBar,highestprice,highestpriceBar,highestprice+50) COLOURED(50,0,0) STYLE(dottedline, 1) //DRAWSEGMENT(highestpriceBar,highestprice,highestpriceBar-4,highestprice) COLOURED(0,300,0) STYLE(line, 3) endif DrawRay(BarHigh2,MyHigh2,BarHigh1,MyHigh1) coloured(0,0,255,255) DrawRay(BarLow2 ,MyLow2, BarLow1, MyLow1) coloured(0,0,255,255) return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93

  DEFPARAM DrawOnLastBarOnly = true   ONCE MyHigh1  = 0 ONCE MyHigh2  = 0 ONCE MyLow1   = 0 ONCE MyLow2   = 0 ONCE BarHigh1 = 0 ONCE BarHigh2 = 0 ONCE BarLow1  = 0 ONCE BarLow2  = 0   // This indicator marks highs and lows based on the Stochastic cycle K = stochastic[5,2] D = average[3](K)   //start of cycle low looking for the lowest price and lowest MACD as long as Stochastic %D<50 If D =< 50 and D[1] => 50 then incyclelow = 1 lowestprice2 = lowestprice Lowestprice = low Dlowest2 = Dlowest Dlowest = D endif //End of cycle low If D > 50 and D[1] < 50 then incyclelow = 0 endif //lowest macd and price in Stochastic cycle %D<50 if incyclelow then lowestprice = min(lowestprice, low) Dlowest = min(Dlowest, D) endif   //what is the lowest price bar of this cycle? if lowestprice<>lowestprice[1] then lowestpriceBar=barindex endif   //LONG if incyclelow = 0 then if lowestpricebar <> BarLow1 then MyLow2  = MyLow1 BarLow2 = BarLow1 MyLow1  = lowestPrice BarLow1 = lowestpriceBar ENDIF //DRAWSEGMENT(lowestpriceBar,lowestprice,lowestpriceBar,lowestprice-50) COLOURED(0,50,0)  STYLE(dottedline, 1) //DRAWSEGMENT(lowestpriceBar,lowestprice,lowestpriceBar-4,lowestprice)  COLOURED(300,0,0) STYLE(line, 3) endif   //____________________________________________________________________________________________________________________   //start of cycle high looking for the higestest price and higest MACD as long as Stochastic %D>50 If D => 50 and D[1] =< 50 then incyclehigh = 1 highestprice2 = highestprice HighestPrice = high   endif //End of cycle high If D < 50 and D[1] > 50 then incyclehigh = 0 endif //highest stoch and price in cycle high if incyclehigh then highestPrice = max(highestPrice, high)   endif   //what is the lowest price bar of this cycle? if highestprice<>highestprice[1] then highestpriceBar=barindex endif   //SHORT if incyclehigh = 0 then if highestpricebar <> BarHigh1 then MyHigh2  = MyHigh1 BarHigh2 = BarHigh1 MyHigh1  = highestPrice BarHigh1 = highestpriceBar ENDIF //DRAWSEGMENT(highestpriceBar,highestprice,highestpriceBar,highestprice+50) COLOURED(50,0,0)  STYLE(dottedline, 1) //DRAWSEGMENT(highestpriceBar,highestprice,highestpriceBar-4,highestprice)  COLOURED(0,300,0) STYLE(line, 3) endif   DrawRay(BarHigh2,MyHigh2,BarHigh1,MyHigh1) coloured(0,0,255,255) DrawRay(BarLow2 ,MyLow2, BarLow1, MyLow1)  coloured(0,0,255,255)   return

  as to missing Red/Green segments, please let me know instrument, TF, date and time there should have been one.

  

  robertogozzi

  Moderator

  Topics: 69

  Replies: 17272

  Been thanked: 4119 times
• Author
  Posts