Why does my indicator not work for currency?

• 11/22/2023 at 1:19 PM #224135
  edktrading

  Hi,

  I tried to create an indicator to show a yellow rectangle around some hours of the new york session.

  i did some copy pasting from other codes, because i am new to coding. see the attatched code.

  My problem, the code works fine for ES/MES , indexes.

  But i want is also to work for currancypairs, like EURUSD, etc.

  Can anyone tell me why it is not working?

  US Session

  starttime = 140000 endtime = 170000 if time = starttime then startbar = barindex endif if time = endtime then endbar = barindex endif if time >= starttime and time <= endtime then if high > hh then hh = high endif if low < ll or ll = 0 then ll = low endif endif hh = round(hh) ll = round(ll) if intradaybarindex = 0 then hh = 0 ll = 0 endif if time > endtime then DrawRectangle(startbar,hh,endbar,ll) coloured("Yellow",25) BorderColor("Yellow",25) endif return

  1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33

  starttime = 140000 endtime = 170000     if time = starttime then startbar = barindex endif if time = endtime then endbar = barindex endif   if time >= starttime and time <= endtime then if high > hh then hh = high endif if low < ll or ll = 0 then ll = low endif endif   hh = round(hh) ll = round(ll)   if intradaybarindex = 0 then hh = 0 ll = 0 endif   if time > endtime then DrawRectangle(startbar,hh,endbar,ll) coloured("Yellow",25) BorderColor("Yellow",25) endif   return

   

   

  

  edktrading

  Participant

  Topics: 4

  Replies: 12

  Been thanked: 1 time
  11/22/2023 at 1:42 PM #224139
  JC_Bywan

  Hi,

  delete both lines with “round”: lines 21 and 22

  Using “round()” brings you to the closest integer. On an index quoting in thousands, rounding it doesn’t change its value a lot, but on a currency where pips are in decimals… for example EURUSD, an hh at 1.09613 when rounded would become = 1 and rounding ll = 1.09314 would make it = 1 too… so that’s a flat rectangle located at 1, which is why you couln’t see anything.

  Code will work without these 2 lines.

  1 user thanked author for this post.

  edktrading

  

  JC_Bywan

  Moderator

  Topics: 20

  Replies: 2657

  Been thanked: 925 times
  11/22/2023 at 1:49 PM #224140
  edktrading

  Thanks a lot, you are my hero! 😉

  

  edktrading

  Participant

  Topics: 4

  Replies: 12

  Been thanked: 1 time
  11/28/2023 at 9:07 AM #224431
  edktrading

  Can someone help me with the following please: is it possible to see the rectancle during the session?

  Now you only see the rectangle in hindsight.

  I know it has to do with “if time > endtime then” but i tried different this, but no results….

  Thanks in advance!

  

  edktrading

  Participant

  Topics: 4

  Replies: 12

  Been thanked: 1 time
• Author
  Posts