Any reasons why this code is not working

rama · 2019-01-01T10:56:50+00:00

pr=2 mp=40 mp1=-30 floatingprofit = (((close-positionprice)*pointvalue)*countofposition)/pipsize //actual trade gains if floatingprofit>=(mp or mp1) then SELL AT close-pr stop endif floatingprofit = (((positionprice-close)*pointvalue)*countofposition)/pipsize //actual trade gains if floatingprofit>=(mp or mp1) then EXITSHORT AT close+pr stop endif I want to close all open positions short or long if loss is >=30 or profit >=40

Viewing 10 posts - 1 through 10 (of 10 total)

Author

Posts
01/01/2019 at 11:56 AM #87817 quote
rama
Participant

Senior
```
pr=2
mp=40
mp1=-30

floatingprofit = (((close-positionprice)*pointvalue)*countofposition)/pipsize //actual trade gains
if floatingprofit>=(mp or mp1) then
SELL AT close-pr stop
endif

floatingprofit = (((positionprice-close)*pointvalue)*countofposition)/pipsize //actual trade gains
if floatingprofit>=(mp or mp1) then
EXITSHORT AT close+pr stop
endif
```
I want to close all open positions short or long

if loss is >=30

or profit >=40
01/01/2019 at 12:13 PM #87819 quote
GraHal
Participant

Master
Just a thought … below won’t work if, for example, you are trying to exit within the bid-ask spread range (spread = 4 or more?).

I guess you’ve tried higher values for pr?
```
pr=2

SELL AT close-pr stop

EXITSHORT AT close+pr stop
```
01/01/2019 at 3:14 PM #87824 quote

Vonasi
Moderator

Master

COUNTOFPOSITION can be positive or negative which will completely mess up your calculations.

Also as GraHal says CLOSE +/- 2 will very likely be too close for a minimum order distance on most markets.

01/01/2019 at 7:52 PM #87835 quote

GraHal
Participant

Master

Isn’t COUNTOFPOSITION either 0 or greater?

When can it be negative?

01/01/2019 at 9:28 PM #87836 quote

Vonasi
Moderator

Master

GraHal wrote:

Isn’t COUNTOFPOSITION either 0 or greater?

When can it be negative?

When you are short.

[attachment file=87837]

GraHal thanked this post

Screenshot_1.png

01/01/2019 at 10:18 PM #87839 quote
GraHal
Participant

Master
@rama try below (AND increase pr > spread) … let us know if it works.
```
floatingprofit = (((close-positionprice)*pointvalue)*countoflongshares)/pipsize //actual trade gains
if floatingprofit>=(mp or mp1) then
SELL AT close-pr stop
endif
 
floatingprofit = (((positionprice-close)*pointvalue)*countofshortshares)/pipsize //actual trade gains
if floatingprofit>=(mp or mp1) then
EXITSHORT AT close+pr stop
endif
```
01/02/2019 at 11:09 AM #87859 quote

rama
Participant

Senior

I am testing the new code, I have tried with PR =1 and MP=any value(without mp1 condition) it works well

I am trying to add loss in the same code that is where it has problem

01/02/2019 at 11:22 AM #87860 quote
GraHal
Participant

Master
try below and let us know
```
if (floatingprofit>= mp) or (floatingprofit <= mp1) then
```
01/03/2019 at 3:27 PM #87959 quote

rama
Participant

Senior

I am running the program now with ,I will let you know the results

1

if (floatingprofit>= mp) or (floatingprofit <= mp1) then

01/03/2019 at 5:10 PM #87961 quote

verygrubby
Participant

Master

Vonasi wrote:

COUNTOFPOSITION can be positive or negative

I think the definition in the manual should be tweaked to make that a bit more obvious. All it says at the moment is “Counts the number of open shares or lots.”

Can a clarification be added (eg “a buy position would should as +1 and a sell position would show as -1”)?

*when I say manual I mean here: https://www.prorealcode.com/documentation/countofposition/

GraHal thanked this post
Author

Posts